Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-23 Thread Dylan Baker
On Monday, September 23, 2013 10:28:17 PM Marek Olšák wrote: Is there another, more readable way to emulate the ?: operator from C? I don't like adding unnecessary lines of code. Marek On Mon, Sep 23, 2013 at 10:23 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Saturday, September

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-20 Thread Marek Olšák
I'll send a new patch, stay tuned. Marek On Fri, Sep 20, 2013 at 10:32 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 01:21:59 Marek Olšák wrote: On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-20 Thread Dylan Baker
On Wednesday 18 September 2013 01:21:59 Marek Olšák wrote: On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote: On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16

[Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-20 Thread Marek Olšák
The Radeon driver writes GPU page faults to dmesg and we need to know which tests caused them. If there is any change in dmesg during a test run, the test result is changed as follows: * pass - dmesg-warn * warn - dmesg-warn * fail - dmesg-fail Dmesg is captured before and after each test and the

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-17 Thread Dylan Baker
On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote: On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them.

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-17 Thread Marek Olšák
On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote: On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-17 Thread Marek Olšák
On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change in dmesg during a test run, the test result

[Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Marek Olšák
The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change in dmesg during a test run, the test result is changed as follows: * pass - dmesg-warn * warn - dmesg-warn * fail - dmesg-fail Dmesg is captured before and after the test and the

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Aaron Watry
Stupid question, but I'm stuck in an airport and can't research the answer easily right now... Will this throw ?false? positives as a result of DPM performance level changes on kernel 3.11+ (assuming dpm is enabled)? Is there any way to filter these messages out besides disabling DPM?

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Alex Deucher
On Mon, Sep 16, 2013 at 4:40 PM, Aaron Watry awa...@gmail.com wrote: Stupid question, but I'm stuck in an airport and can't research the answer easily right now... Will this throw ?false? positives as a result of DPM performance level changes on kernel 3.11+ (assuming dpm is enabled)? Is

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Marek Olšák
We could filter the messages with another command-line option taking a regexp, but it's not a priority for me right now. Marek On Mon, Sep 16, 2013 at 10:40 PM, Aaron Watry awa...@gmail.com wrote: Stupid question, but I'm stuck in an airport and can't research the answer easily right now...

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Aaron Watry
That's good enough for me. Given that this is an optional piglit feature, it shouldn't mess up what I'm working on anyway, and I definitely see the utility of it for tracking down issues in a test run. --Aaron On Sep 16, 2013, at 6:00 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Mon,