Re: [Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility

2017-05-20 Thread Samuel Pitoiset
As discussed offline, I missed the HAS_ERRORS bits. On 05/19/2017 11:18 AM, Samuel Pitoiset wrote: Few comments below, you missed all negative-* tests. With those fixed, patch is: Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: ---

Re: [Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility

2017-05-19 Thread Samuel Pitoiset
Few comments below, you missed all negative-* tests. With those fixed, patch is: Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- .../bindbuffer-general-point.c | 1 +

[Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility

2017-05-17 Thread Timothy Arceri
--- .../bindbuffer-general-point.c | 1 + .../arb_uniform_buffer_object/buffer-targets.c | 1 + .../spec/arb_uniform_buffer_object/bufferstorage.c | 1 + .../spec/arb_uniform_buffer_object/deletebuffers.c | 1 + tests/spec/arb_uniform_buffer_object/dlist.c | 1 +