Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-23 Thread Ian Romanick
On 11/20/2015 04:56 PM, Dylan Baker wrote: > On Fri, Nov 20, 2015 at 03:05:49PM -0800, Ian Romanick wrote: >> On 11/20/2015 02:14 PM, Dylan Baker wrote: >>> On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: From: Ian Romanick If this test has

Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-23 Thread Dylan Baker
On Mon, Nov 23, 2015 at 12:16:33PM -0800, Ian Romanick wrote: > On 11/20/2015 04:56 PM, Dylan Baker wrote: > > On Fri, Nov 20, 2015 at 03:05:49PM -0800, Ian Romanick wrote: > >> On 11/20/2015 02:14 PM, Dylan Baker wrote: > >>> On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: >

Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-20 Thread Dylan Baker
On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: > From: Ian Romanick > > If this test has problems with odd sample counts, the test should detect > that and SKIP. I'm not sure I agree. I think it's pretty reasonable for all.py to only pass valid inputs to

Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-20 Thread Ian Romanick
On 11/20/2015 02:14 PM, Dylan Baker wrote: > On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: >> From: Ian Romanick >> >> If this test has problems with odd sample counts, the test should detect >> that and SKIP. > > I'm not sure I agree. I think it's

Re: [Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-20 Thread Dylan Baker
On Fri, Nov 20, 2015 at 03:05:49PM -0800, Ian Romanick wrote: > On 11/20/2015 02:14 PM, Dylan Baker wrote: > > On Thu, Nov 19, 2015 at 08:00:09PM -0800, Ian Romanick wrote: > >> From: Ian Romanick > >> > >> If this test has problems with odd sample counts, the test

[Piglit] [PATCH 3/9] all.py: Everything in MSAA_SAMPLE_COUNTS is already even

2015-11-19 Thread Ian Romanick
From: Ian Romanick If this test has problems with odd sample counts, the test should detect that and SKIP. Signed-off-by: Ian Romanick --- tests/all.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/all.py