Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-20 Thread Alejandro Piñeiro
On 20/08/18 04:11, Timothy Arceri wrote: > On 18/08/18 19:30, Alejandro Piñeiro wrote: >> On 18/08/18 06:36, Timothy Arceri wrote: >>> On 18/08/18 14:32, Timothy Arceri wrote: Won't this cause shader runner to needlessly parse the .shader_test file? >> >> True, good point. In any case, as

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-20 Thread Timothy Arceri
On 18/08/18 19:30, Alejandro Piñeiro wrote: On 18/08/18 06:36, Timothy Arceri wrote: On 18/08/18 14:32, Timothy Arceri wrote: Won't this cause shader runner to needlessly parse the .shader_test file? True, good point. In any case, as the test lacks a [test] section, full shader.py runs would

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-18 Thread Alejandro Piñeiro
On 18/08/18 06:36, Timothy Arceri wrote: > On 18/08/18 14:32, Timothy Arceri wrote: >> Won't this cause shader runner to needlessly parse the .shader_test >> file? True, good point. In any case, as the test lacks a [test] section, full shader.py runs would just check if the test links (assuming th

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-17 Thread Timothy Arceri
On 18/08/18 14:32, Timothy Arceri wrote: Won't this cause shader runner to needlessly parse the .shader_test file? The file extension is also confusing. Maybe we should name these type of files .shader_source or something similar rather than .shader_test ??? On 09/08/18 21:36, Alejandro Pi

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-17 Thread Timothy Arceri
Won't this cause shader runner to needlessly parse the .shader_test file? On 09/08/18 21:36, Alejandro Piñeiro wrote: From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by:

[Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-09 Thread Alejandro Piñeiro
From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts Signed-off-by: Alejandro Piñeiro --- tests/opengl.py| 1 + .../xfb_streams_without_invocations.s