Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-26 Thread Tapani Pälli
Hi; starting with the shortest .. :) I have one addition to the test, after linking try out giving NULL for the name field: glGetProgramResourceName(prog, GL_UNIFORM, pos, 0, length, NULL); With this addition; Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 03/25/2015 06:01 PM,

Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-26 Thread Tapani Pälli
On 03/26/2015 10:58 AM, Martin Peres wrote: On 26/03/15 10:45, Tapani Pälli wrote: Hi; starting with the shortest .. :) I have one addition to the test, after linking try out giving NULL for the name field: glGetProgramResourceName(prog, GL_UNIFORM, pos, 0, length, NULL); This is not

Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-26 Thread Martin Peres
On 26/03/15 10:45, Tapani Pälli wrote: Hi; starting with the shortest .. :) I have one addition to the test, after linking try out giving NULL for the name field: glGetProgramResourceName(prog, GL_UNIFORM, pos, 0, length, NULL); This is not really in the spec, hence why I did not add

[Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-25 Thread Martin Peres
Tests the error paths of GetProgramResourceName Signed-off-by: Martin Peres martin.pe...@linux.intel.com --- tests/all.py | 1 + .../arb_program_interface_query/CMakeLists.gl.txt | 1 + .../getprogramresourcename.c | 177