Re: [Piglit] [PATCH v1 1/2] piglit-framework-gl: add possibility to deinit test

2019-01-08 Thread Sergii Romantsov
Hello, Eric. Yes, and i also answered with some explanation: > And, in general, I would recommend just freeing data after usage,> rather > than having a deinit function. Looks like it may complicate a logic and code of test. Test may exit with any call to 'piglit_report_result' and it can happen

Re: [Piglit] [PATCH v1 1/2] piglit-framework-gl: add possibility to deinit test

2019-01-03 Thread Eric Anholt
Sergii Romantsov writes: > Hello, > is there any chance to get review? > In the goal is idea to get a simple mechanism to control resources freeing > (any extra memory allocations, files etc.) of any piglit-test on the exit. I gave some feedback, and I haven't seen a new version. signature.asc

Re: [Piglit] [PATCH v1 1/2] piglit-framework-gl: add possibility to deinit test

2019-01-03 Thread Sergii Romantsov
Hello, is there any chance to get review? In the goal is idea to get a simple mechanism to control resources freeing (any extra memory allocations, files etc.) of any piglit-test on the exit. On Wed, Nov 21, 2018 at 12:18 PM Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Each test can be

[Piglit] [PATCH v1 1/2] piglit-framework-gl: add possibility to deinit test

2018-11-21 Thread Sergii Romantsov
Each test can be initialized ('init') and displayed ('dipslay'). During initialization can be allocated resources. But there is no common unified mechanism to free resources on test finishing, except, probably, registaration of callabck with 'atexit'. To the piglit-configuration added callback-fun