Re: [Piglit] [PATCH v1 2/2] test: fix resources usage for depthstencil-render-miplevels

2018-11-26 Thread Sergii Romantsov
Hello, Eric > > Can you explain how not freeing memory could cause a core dump on exit? Core mostly was generated due: a number of levels is max_miplevel (level 0 is also available, so index should be counted as <=max_miplevel), but array that holds pointers is size of max_miplevel (so without

Re: [Piglit] [PATCH v1 2/2] test: fix resources usage for depthstencil-render-miplevels

2018-11-23 Thread Eric Anholt
Sergii Romantsov writes: > Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes core dump on > exit. > Issues: > 1. Allocation of memory many times to the same variable > 2. Not complete array to store pointers > 3. Absence of memory freeing Can you explain how not freeing memory

[Piglit] [PATCH v1 2/2] test: fix resources usage for depthstencil-render-miplevels

2018-11-21 Thread Sergii Romantsov
Usage test 'depthstencil-render-miplevels 200 s=z24_s8' causes core dump on exit. Issues: 1. Allocation of memory many times to the same variable 2. Not complete array to store pointers 3. Absence of memory freeing CC: Eric Anholt Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108819