Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-25 Thread Kenneth Graunke
On 05/17/2013 09:31 AM, Dylan Baker wrote: Drops almost all of the code used in this file, all of that functionality is now handled in the summary class. Instead, the majority of this file is just the argparse instance, and a few short lines calling the new summary class. V2: Fixes the

Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-22 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: On 05/19/2013 07:30 AM, Ken Phillis Jr wrote: On Sun, May 19, 2013 at 1:07 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 05/18/2013 09:35 PM, Dylan Baker wrote: My problem with the current list format is its too complex, and is trying to

Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-19 Thread Ken Phillis Jr
On Sun, May 19, 2013 at 1:07 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 05/18/2013 09:35 PM, Dylan Baker wrote: My problem with the current list format is its too complex, and is trying to solve nonexistent problems. There is no reason one should need to rename the test results in

Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-19 Thread Kenneth Graunke
On 05/19/2013 07:30 AM, Ken Phillis Jr wrote: On Sun, May 19, 2013 at 1:07 AM, Kenneth Graunke kenn...@whitecape.org wrote: On 05/18/2013 09:35 PM, Dylan Baker wrote: My problem with the current list format is its too complex, and is trying to solve nonexistent problems. There is no reason

Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-18 Thread Dylan Baker
My problem with the current list format is its too complex, and is trying to solve nonexistent problems. There is no reason one should need to rename the test results in the HTML summary. It's only going to lead to headaches later on trying to identify what is actually in that column corrected

Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-17 Thread Ken Phillis Jr
I am wondering... Where is the help information over the lists file? The best placement to show an Example list file is to use the epilog argument to the ArgumentParser, and set the formatter_class to argparse.RawDescriptionHelpFormatter Documentation on this is as follows... Argument Parser

Re: [Piglit] [PATCH v2 04/11] piglit-summary-py: Use the new summary class to generate HTML

2013-05-17 Thread Dylan Baker
You're probably right. I'll make that change too. Though I am wondering if it's even worth having the list syntax, it's been broken for over two months and no one has complained or even noticed it until now. If it's still useful to someone I'll fix it, but if no one's using it it is a fairly