Re: [Piglit] [patch v3 13/15] arb_arrays_of_arrays/compiler/subroutine.vert: make parse correctly

2014-07-31 Thread Timothy Arceri
On Mon, 2014-07-28 at 17:34 -0700, Dylan Baker wrote: > This currently uses 3 require extensions lines, this doesn't actually > work and never has, but with patches earlier in this series this stops > parsing since the parser raises an error. Reviewed-by: Timothy Arceri > > Signed-off-by: Dylan

Re: [Piglit] [patch v3 13/15] arb_arrays_of_arrays/compiler/subroutine.vert: make parse correctly

2014-07-28 Thread Chris Forbes
I haven't had time to examine your python changes in detail, but patches 5, 9, 10, 13 (the ones that fix test headers) are: Reviewed-by: Chris Forbes On Tue, Jul 29, 2014 at 12:34 PM, Dylan Baker wrote: > This currently uses 3 require extensions lines, this doesn't actually > work and never has

[Piglit] [patch v3 13/15] arb_arrays_of_arrays/compiler/subroutine.vert: make parse correctly

2014-07-28 Thread Dylan Baker
This currently uses 3 require extensions lines, this doesn't actually work and never has, but with patches earlier in this series this stops parsing since the parser raises an error. Signed-off-by: Dylan Baker --- tests/spec/arb_arrays_of_arrays/compiler/subroutine.vert | 4 +--- 1 file changed,