Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-25 Thread Dylan Baker
On Wed, Nov 25, 2015 at 06:32:25AM -0800, yann.argo...@linux.intel.com wrote: > > On Tue, Nov 24, 2015 at 04:14:23AM -0800, yann.argo...@linux.intel.com > > wrote: > > > > > I don't like the aproach of passing the returncode through every level > > of piglit at all. I'd much rather use an exceptio

Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-25 Thread Emil Velikov
On 25 November 2015 at 12:42, Daniel Vetter wrote: > On Tue, Nov 24, 2015 at 02:10:34PM +, Emil Velikov wrote: >> Hi Yan, >> >> The plan of having such a module is pretty sound. >> >> That said I think that the actual policy/implementation could use some >> tweaks. >> >> On 24 November 2015 a

Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-25 Thread yann . argotti
> On Tue, Nov 24, 2015 at 04:14:23AM -0800, yann.argo...@linux.intel.com > wrote: > > I don't like the aproach of passing the returncode through every level > of piglit at all. I'd much rather use an exception for this, either by > extending PiglitFatalError or by adding a new exception, and then

Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-25 Thread Daniel Vetter
On Tue, Nov 24, 2015 at 02:10:34PM +, Emil Velikov wrote: > Hi Yan, > > The plan of having such a module is pretty sound. > > That said I think that the actual policy/implementation could use some tweaks. > > On 24 November 2015 at 12:14, wrote: > > From: Yann Argotti > > Date: Tue, 24 No

Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-24 Thread Dylan Baker
On Tue, Nov 24, 2015 at 02:10:34PM +, Emil Velikov wrote: > Hi Yan, > > The plan of having such a module is pretty sound. > > That said I think that the actual policy/implementation could use some tweaks. > > On 24 November 2015 at 12:14, wrote: > > From: Yann Argotti > > Date: Tue, 24 No

Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-24 Thread Dylan Baker
On Tue, Nov 24, 2015 at 04:14:23AM -0800, yann.argo...@linux.intel.com wrote: > From: Yann Argotti > Date: Tue, 24 Nov 2015 12:16:34 +0100 > > This adds a policy which advises when user should reboot system to avoid > noisy test results due to system becoming unstable, for instance, and > ther

Re: [Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-24 Thread Emil Velikov
Hi Yan, The plan of having such a module is pretty sound. That said I think that the actual policy/implementation could use some tweaks. On 24 November 2015 at 12:14, wrote: > From: Yann Argotti > Date: Tue, 24 Nov 2015 12:16:34 +0100 > > This adds a policy which advises when user should reb

[Piglit] [PATCH] Add dmesg option for reboot policy

2015-11-24 Thread yann . argotti
From: Yann Argotti Date: Tue, 24 Nov 2015 12:16:34 +0100 This adds a policy which advises when user should reboot system to avoid noisy test results due to system becoming unstable, for instance, and therefore continues testing successfully. To do this, a new Dmesg class is proposed which is