Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
On 24/01/2019 16:15, Alejandro Piñeiro wrote: From: Neil Roberts v2: imported to piglit from a example vkrunner examples branch, also updated description on the top comment (Alejandro Piñeiro) v3: use location 1 instead of location 0 for one of the tests (Lionel) Reviewed-by: Lionel

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
On 24/01/2019 15:45, apinheiro wrote: On 24/1/19 16:28, Lionel Landwerlin wrote: Thanks a lot for explaining. I was wondering whether it would be worth checking something like this : (layout location = 1) out block myBlock {     vec4 a;     vec4 b; } And verify whether a would bet location

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread apinheiro
On 24/1/19 16:28, Lionel Landwerlin wrote: Thanks a lot for explaining. I was wondering whether it would be worth checking something like this : (layout location = 1) out block myBlock {     vec4 a;     vec4 b; } And verify whether a would bet location 1 and b location 2. So do you mean

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
Thanks a lot for explaining. I was wondering whether it would be worth checking something like this : (layout location = 1) out block myBlock {     vec4 a;     vec4 b; } And verify whether a would bet location 1 and b location 2. But this current version looks good to me : Reviewed-by:

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread apinheiro
On 24/1/19 12:28, Lionel Landwerlin wrote: I'm not sure whether my understanding of block-layout-location.vk_shader_test is correct. Is the expectation that the location of %name (0) is added to the location of its field (a, b, c, d)? Not sure if added is the proper word, but derived. So

Re: [Piglit] [PATCH] vulkan: Add some tests for block member decorations

2019-01-24 Thread Lionel Landwerlin
I'm not sure whether my understanding of block-layout-location.vk_shader_test is correct. Is the expectation that the location of %name (0) is added to the location of its field (a, b, c, d)? Thanks, -Lionel On 23/01/2019 15:07, Alejandro Piñeiro wrote: From: Neil Roberts v2: imported to