Re: [Piglit] Add OpenCL test for building program with build options v2
On Fri, Oct 12, 2012 at 04:49:11PM -0500, Aaron Watry wrote: On Thu, Oct 11, 2012 at 9:53 PM, Tom Stellard t...@stellard.net wrote: On Wed, Oct 10, 2012 at 06:44:01PM -0500, Aaron Watry wrote: I've created a reasonable number of tests of clBuildProgram based on the OpenCL 1.1 spec at: http://www.khronos.org/registry/cl/sdk/1.1/docs/man/xhtml/ This is a follow-up to a patch that I sent on Sept 27 [1]. [1] http://lists.freedesktop.org/archives/piglit/2012-September/003320.html [PATCH 01/11] Add CL build test for macro definitions without values [PATCH 02/11] Add CL build test for macro definitions with values [PATCH 03/11] Add CL build test for mixed macro definitions. [PATCH 04/11] Add CL build test for specified include directories [PATCH 05/11] Add CL build test for specified math intrinsics [PATCH 06/11] Add CL build test for optimizations options [PATCH 07/11] Add CL build test for disabling warnings [PATCH 08/11] Add build test for specifying CL version [PATCH 09/11] Add CL build test for -Werror [PATCH 10/11] Add CL build test for invalid CL version declarations [PATCH 11/11] Remove TODO item from build-program.c These look good to me. Reviewed-by: Tom Stellard thomas.stell...@amd.com When we feel that this has sufficient review, could someone push the patches for me? I don't have commit access to fd.o (yet?). I've committed these patches. Thanks! -Tom ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 1/2] util/gl: Add test config option 'requires_displayed_window'
Chad Versace chad.vers...@linux.intel.com writes: When running tests in -auto mode using waffle, piglit does not display the window on the screen. The nice benefit of this is that test runs are visually silent except for the rare glean and glx tests. However, not displaying the window breaks tests that read from the front buffer. After glXSwapBuffers, the content of the front buffer is undefined if the window is not displayed. Signed-off-by: Chad Versace chad.vers...@linux.intel.com Series is: Reviewed-by: Eric Anholt e...@anholt.net pgpZOI6dEZPTh.pgp Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] util: Fix visual selection when using waffle
There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless, but also we'd end up with the RGBX framebuffer config mostly untested. While it's useful to have RGBA framebuffers in most tests, we should not remove support for RGBX framebuffers entirely. Marek On Tue, Oct 16, 2012 at 9:57 PM, Eric Anholt e...@anholt.net wrote: Chad Versace chad.vers...@linux.intel.com writes: Only request a visual with alpha if the test requests PIGLIT_GL_VISUAL_ALPHA. When I wrote the waffle backend, I misunderstood the meaning of GLUT_RGBA. I interpreted GLUT_RGBA to indicate a request for a visual with all of RGBA channels present. Actually, it just indicates a request for a visual with RGBA color model, as opposed to GLUT_LUMINANCE and GLUT_INDEX. Fixes regression in fs-texelFetchOffest-2D. Reported-by: Marek Olšák mar...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com We should fix those tests to work correctly in the presence of alpha in the visual. The system could have all visuals with alpha, and the test should deal with it. That said, I'd like to see some sanity in the PIGLIT_GL_VISUAL now that we're not glut any more. The glut interface was awful and a total trap. I think we should replace RGB | ALPHA with RGBA, and make RGB ask for RGB and RGBA ask for RGBA. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [ANNOUNCE] waffle-1.1.1
Waffle 1.1.1 - 16 Oct 2012 == Waffle 1.1.1 is a bugfix release. It fixes bugs discovered since 1.1.0. Downloads and documentation are available at: http://people.freedesktop.org/~chadversary/waffle/releases.html#1.1.1 For the cautious, the SHA256 sum is: 7219d2e02338f7f5410e83087a0465b0a59710e738b771b9b32c0d2b2305c596 There is also a signed waffle-1.1.1 tag in my git repo: git://people.freedesktop.org/~chadversary/waffle Bugfixes - Fix the build for cmake 2.8.5 by bundling the GNUInstallDirs module into waffle. - Clarify the simple build instructions in README.txt. Changes --- The full set changes can be viewed with `git log waffle-1.1.0..waffle-1.1.1`. Chad Versace (4): doc/building: Remove duplicate instructions found in README readme: Clarify build instructions cmake: Bundle the GNUInstallDirs module from cmake-2.8.9 waffle: Bump version to 1.1.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] util: Fix visual selection when using waffle
On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless, but also we'd end up with the RGBX framebuffer config mostly untested. While it's useful to have RGBA framebuffers in most tests, we should not remove support for RGBX framebuffers entirely. We should modify this test to complain if it gets a visual that has alpha. glGetIntegerv(GL_ALPHA_BITS, v) if (v != 0) skip? warn? other? Marek On Tue, Oct 16, 2012 at 9:57 PM, Eric Anholt e...@anholt.net wrote: Chad Versace chad.vers...@linux.intel.com writes: Only request a visual with alpha if the test requests PIGLIT_GL_VISUAL_ALPHA. When I wrote the waffle backend, I misunderstood the meaning of GLUT_RGBA. I interpreted GLUT_RGBA to indicate a request for a visual with all of RGBA channels present. Actually, it just indicates a request for a visual with RGBA color model, as opposed to GLUT_LUMINANCE and GLUT_INDEX. Fixes regression in fs-texelFetchOffest-2D. Reported-by: Marek Olšák mar...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com We should fix those tests to work correctly in the presence of alpha in the visual. The system could have all visuals with alpha, and the test should deal with it. That said, I'd like to see some sanity in the PIGLIT_GL_VISUAL now that we're not glut any more. The glut interface was awful and a total trap. I think we should replace RGB | ALPHA with RGBA, and make RGB ask for RGB and RGBA ask for RGBA. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] util: Fix visual selection when using waffle
Chad Versace chad.vers...@linux.intel.com writes: On 10/16/2012 12:57 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: Only request a visual with alpha if the test requests PIGLIT_GL_VISUAL_ALPHA. When I wrote the waffle backend, I misunderstood the meaning of GLUT_RGBA. I interpreted GLUT_RGBA to indicate a request for a visual with all of RGBA channels present. Actually, it just indicates a request for a visual with RGBA color model, as opposed to GLUT_LUMINANCE and GLUT_INDEX. Fixes regression in fs-texelFetchOffest-2D. Reported-by: Marek Olšák mar...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com We should fix those tests to work correctly in the presence of alpha in the visual. The system could have all visuals with alpha, and the test should deal with it. That said, I'd like to see some sanity in the PIGLIT_GL_VISUAL now that we're not glut any more. The glut interface was awful and a total trap. I think we should replace RGB | ALPHA with RGBA, and make RGB ask for RGB and RGBA ask for RGBA. If we go down that route, I wish to see the ALPHA enum completely removed. That would eliminate any confusion over what's difference between between `RGB | ALPHA` and just `RGBA`?. What do you think? Oh, sorry, I thought I was clear on that. Yeah, ALPHA should die. pgpZrRPQ0WEZW.pgp Description: PGP signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
