On Sat, Dec 22, 2012 at 1:07 PM, Vinson Lee v...@freedesktop.org wrote:
Fixes uninitialized scalar variable defect reported by Coverity.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/spec/arb_vertex_array_object/isvertexarray.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
---
tests/all.tests| 1 -
tests/shaders/CMakeLists.gl.txt| 1 -
tests/shaders/glsl-fs-mix-constant.c | 81 --
tests/shaders/glsl-fs-mix-constant.frag| 7 ---
tests/shaders/glsl-fs-mix-constant.shader_test
Shader runner tests are easier to read at a glance than C tests.
---
tests/all.tests | 1 -
tests/shaders/CMakeLists.gl.txt | 1 -
tests/shaders/glsl-fs-mix.c | 92 ---
tests/shaders/glsl-fs-mix.frag| 6 ---
This series deletes roughly 20% of Piglit's import of Glean:
1. Benchmarking
Piglit is a not a benchmarking suite---it's a test suite. It has no
infrastructure for even running these tests, so there's no need to
keep them around.
2. Image output code
Jose nuked most of this,
Piglit is not a benchmarking suite, and this is a benchmark, not a test.
---
tests/glean/CMakeLists.gl.txt | 1 -
tests/glean/treadpixperf.cpp | 551 --
tests/glean/treadpixperf.h| 88 ---
3 files changed, 640 deletions(-)
delete mode 100644
Piglit is not a benchmarking suite, and these are benchmarks, not tests.
---
tests/glean/CMakeLists.gl.txt |1 -
tests/glean/tvtxperf.cpp | 1423 -
tests/glean/tvtxperf.h| 147 -
3 files changed, 1571 deletions(-)
delete mode 100644
Piglit is not a benchmarking suite, and this is a benchmark, not a test.
---
tests/glean/CMakeLists.gl.txt | 1 -
tests/glean/tchgperf.cpp | 317 --
tests/glean/tchgperf.h| 72 --
3 files changed, 390 deletions(-)
delete mode 100644
This allows some further simplifications as well: there's no need for
separate testFunctionality, runSubTests, and runOne functions.
---
tests/glean/tfbo.cpp | 153 +++
tests/glean/tfbo.h | 4 --
2 files changed, 9 insertions(+), 148
There never was any benchmarking code in this test; this was just cut
and pasted from somewhere else.
---
tests/glean/ttexture_srgb.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/glean/ttexture_srgb.h b/tests/glean/ttexture_srgb.h
index 1095565..8875b2d 100644
---
These don't appear to use the Timer functionality, so there's no need to
include it.
---
tests/glean/tshaderapi.cpp | 1 -
tests/glean/ttexcombine4.cpp | 1 -
tests/glean/ttexswizzle.cpp| 1 -
tests/glean/tvertarraybgra.cpp | 1 -
4 files changed, 4 deletions(-)
diff --git
This was previously used for benchmarking code. There isn't any now.
---
tests/glean/CMakeLists.gl.txt | 1 -
tests/glean/timer.cpp | 232 --
tests/glean/timer.h | 74 --
3 files changed, 307 deletions(-)
delete mode
These were used to try and settle the system before a benchmark, and
aren't terribly useful now that there are no benchmarks.
---
tests/glean/environ.cpp | 9 -
tests/glean/environ.h | 2 --
tests/glean/winsys.cpp | 8
tests/glean/winsys.h| 1 -
4 files changed, 20
I suspect most people simply use piglit-summary-html.py to compare
results across test runs. Piglit also supports comparing more than two
test runs.
In some cases, Glean's code did offer more detailed information such as
image comparisons (although not all tests implemented such features).
Jose removed the rgbTriStrip test and TIFF output, which was the only
remaining user of this code.
---
tests/glean/environ.cpp | 15 ---
tests/glean/environ.h | 11 ---
2 files changed, 26 deletions(-)
diff --git a/tests/glean/environ.cpp b/tests/glean/environ.cpp
index
At this point, Glean wasn't writing anything interesting anyway;
it was just clutter.
Since there's no need to specify a results directory on the command line
any longer, this patch also removes the -r option, making run tests
the default action.
This also allows us to simplify the Piglit runner
Now that result comparison is gone, there's no real need to store an
enum here...except for --listtests, it's always run. Simplify.
---
tests/glean/main.cpp| 24
tests/glean/options.cpp | 1 -
tests/glean/options.h | 4
3 files changed, 8 insertions(+), 21
This wasn't used for anything.
---
tests/glean/CMakeLists.gl.txt | 1 -
tests/glean/codedid.cpp | 146 --
tests/glean/codedid.h | 92 --
3 files changed, 239 deletions(-)
delete mode 100644 tests/glean/codedid.cpp
It turns out these frequently-used OpenGL operations weren't used
at all.
---
tests/glean/glutils.cpp | 157
tests/glean/glutils.h | 42 -
2 files changed, 199 deletions(-)
diff --git a/tests/glean/glutils.cpp
Both of these were unused.
---
tests/glean/geomutil.cpp | 156 ---
tests/glean/geomutil.h | 20 --
2 files changed, 176 deletions(-)
diff --git a/tests/glean/geomutil.cpp b/tests/glean/geomutil.cpp
index 01645f7..1852332 100644
---
19 matches
Mail list logo
