Re: [Piglit] [PATCH 2/2] draw-pixels: update BYTE_TO_FLOAT() macro to match Mesa

2014-09-26 Thread Jason Ekstrand
Yeah, I'm OK with this too. At some point it would be good to put a lite effort into making both formulas valid so that piglit works on both legacy and post 3.2 contexts. But that's more of a to do list item than a comment on this patch. --Jason On Sep 25, 2014 3:21 PM, Brian Paul

[Piglit] [PATCH] cmake: bump cmake requirement to 2.8.11

2014-09-26 Thread Emil Velikov
Latest waffle (1.4.0) requires cmake 2.8.11 and considering that waffle and piglit are build hand-in-hand, do the same here. Suggested-by: Chad Versace chad.vers...@linux.intel.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- I'm not entirely sure how many people build waffle

Re: [Piglit] [PATCH V2] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-26 Thread Tom Stellard
On Fri, Sep 26, 2014 at 07:11:03AM +0800, xionghu@intel.com wrote: From: Luo xionghu@intel.com the option CL_KERNEL_GLOBAL_WORK_SIZE for clGetKernelWorkGroupInfo should call built in kernel or custom device according to the spec, this patch calls the built in kernel to query the

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-26 Thread Tom Stellard
On Thu, Sep 25, 2014 at 10:19:16PM -0400, Jan Vesely wrote: Didn't notice somebody dropped Tom from the cc list. On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote: On Wed, 2014-09-03 at 20:20 -0700, Dylan Baker wrote: I'd caught this error in a branch as well, but noticed there were no

Re: [Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-26 Thread Thomas Wood
On 25 September 2014 22:27, Dylan Baker baker.dyla...@gmail.com wrote: Hi Thomas, I had a chance to run this (both this version and your original version), and the performance hit is massive on both GL and CL testing. I'm concerned with introducing a mechanism as generic when it made my test

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-26 Thread Jan Vesely
On Fri, 2014-09-26 at 07:22 -0700, Tom Stellard wrote: On Thu, Sep 25, 2014 at 10:19:16PM -0400, Jan Vesely wrote: Didn't notice somebody dropped Tom from the cc list. On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote: On Wed, 2014-09-03 at 20:20 -0700, Dylan Baker wrote: I'd

[Piglit] [PATCH] cl: Add log1p tests

2014-09-26 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index dfc1d1d..48b4507 100644

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-26 Thread Tom Stellard
On Fri, Sep 26, 2014 at 01:51:15PM -0400, Jan Vesely wrote: On Fri, 2014-09-26 at 07:22 -0700, Tom Stellard wrote: On Thu, Sep 25, 2014 at 10:19:16PM -0400, Jan Vesely wrote: Didn't notice somebody dropped Tom from the cc list. On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote:

Re: [Piglit] [PATCH] cl: Add log1p tests

2014-09-26 Thread Tom Stellard
On Fri, Sep 26, 2014 at 01:05:35PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com --- Reviewed-by: Tom Stellard thomas.stell...@amd.com generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH] CL: Add atomic_add global tests

2014-09-26 Thread Tom Stellard
On Tue, Sep 23, 2014 at 11:13:06AM -0500, Aaron Watry wrote: Adds two separate files, one which tests atomic_add without usage of the return values, and another which tests with return usage. At least the Radeon HD (EG/SI) line has two separate sets of instructions depending on whether the

Re: [Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-26 Thread Dylan Baker
Interesting, the first time I ran these I saw a large slowdown, but I can't see it now. So, I'll take it then Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Friday, September 26, 2014 05:05:41 PM Thomas Wood wrote: On 25 September 2014 22:27, Dylan Baker baker.dyla...@gmail.com wrote: Hi

Re: [Piglit] [PATCH] framework/tests: add a test for the timeout mechanism

2014-09-26 Thread Dylan Baker
I'd prefer this split into two seperate tests, but it's fine either way Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Thursday, September 25, 2014 06:13:05 PM Thomas Wood wrote: Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/tests/exectest_test.py | 20

[Piglit] [PATCH 1/1] cl: Run concurrent on Linux render nodes, or non-Linux

2014-09-26 Thread Jan Vesely
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- Something like this? tests/cl.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/cl.py b/tests/cl.py index f618f59..2d3c930 100644 --- a/tests/cl.py +++ b/tests/cl.py @@ -7,6 +7,9 @@ __all__ =

Re: [Piglit] [PATCH 1/1] cl: Run concurrent on Linux render nodes, or non-Linux

2014-09-26 Thread Dylan Baker
On Friday, September 26, 2014 07:02:49 PM Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- Something like this? tests/cl.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/cl.py b/tests/cl.py index f618f59..2d3c930 100644

Re: [Piglit] Atomic Writes for piglit backends

2014-09-26 Thread Dylan Baker
bump. On Tuesday, September 23, 2014 05:55:47 PM Dylan Baker wrote: For a long time piglit has had a considerable problem with resuming interrupted runs. This problem comes from the recovery tool, a very fragile piece of code that relies on the formatting of the json to walk backwards