Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2015-02-06 Thread Jose Fonseca
I haven't tried this sort of code with MSVC 2013 U4, but at least in the past, MSVC 2013 was refusing certain kinds of variable length arrays. And Jan's patch is a stepping stone to -Wvla option when compiling (option which apply to the whole tree, including parts that are not built with

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2015-02-06 Thread Dylan Baker
Is this actually necessary? I though that we required MSVC 2013 u4, because it has c99 support. Also, dma_buf tests require libdrm_intel, which doesn't exist/work on windows, so I don't think anyone will be building them with msvc anytime soon. Dylan On Fri, Feb 06, 2015 at 11:49:08AM -0500,

Re: [Piglit] [PATCHv2 03/23] arb_shader_image_load_store: Import grid execution helpers.

2015-02-06 Thread Vinson Lee
On Sat, Jan 31, 2015 at 7:41 AM, Francisco Jerez curroje...@riseup.net wrote: Define helper functions that are able to run a piece of GLSL code on an arbitrary shader stage (as of now VS, TCS, TES, GS, FS and CS are supported) for a given execution size. This makes every shader stage expose a

[Piglit] [PATCH] cl-api-create-sampler: Fix memory leak.

2015-02-06 Thread Vinson Lee
Fix resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/cl/api/create-sampler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cl/api/create-sampler.c b/tests/cl/api/create-sampler.c index 99423a3..dcdef05 100644 ---

[Piglit] [Bug 86361] [Bisected]Piglit compile-program.c make fail

2015-02-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86361 Serge Martin edb+freedesk...@sigluy.net changed: What|Removed |Added Status|VERIFIED|CLOSED ---

Re: [Piglit] [PATCH] cl: fix clCompileProgram compil error with CL1.1

2015-02-06 Thread EdB
On Thursday 05 February 2015 13:49:37 Jan Vesely wrote: On Tue, 2015-01-06 at 21:23 +0100, EdB wrote: Ping pushed thanks Le 2014-12-06 23:56, Jan Vesely a écrit : On Sat, 2014-12-06 at 12:17 +0100, EdB wrote: Hello The bug is Verified.Fixed. I don't have commit access.

Re: [Piglit] [PATCH] gl-1.0-blend: print current blend state if probe fails

2015-02-06 Thread Laura Ekstrand
Looks good to me. Reviewed-by: Laura Ekstrand la...@jlekstrand.net On Thu, Feb 5, 2015 at 4:47 PM, Brian Paul bri...@vmware.com wrote: --- tests/spec/gl-1.0/blend.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/spec/gl-1.0/blend.c

Re: [Piglit] [PATCH 1/1] cl: Fix tolerance for division in scalar arithmetic test

2015-02-06 Thread Jan Vesely
ping On Mon, 2015-01-26 at 15:20 -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- RFC: I only tagged numerical results, it did not make sense to me to do it for NaNs and Infs R600: Fail - Pass tests/cl/program/execute/scalar-arithmetic-float.cl | 14

Re: [Piglit] [PATCH 2/3] Use alloca instead of variable length arrays

2015-02-06 Thread Jan Vesely
ping On Fri, 2014-12-12 at 19:13 -0500, Jan Vesely wrote: On Fri, 2014-12-12 at 14:49 -0800, Matt Turner wrote: On Fri, Dec 12, 2014 at 2:13 PM, Jan Vesely jan.ves...@rutgers.edu wrote: On Fri, 2014-12-12 at 13:37 -0800, Matt Turner wrote: On Fri, Dec 12, 2014 at 1:23 PM, Jan Vesely

Re: [Piglit] [PATCH 1/1] cl: Fix tolerance for division in scalar arithmetic test

2015-02-06 Thread Tom Stellard
On Mon, Jan 26, 2015 at 03:20:34PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com --- RFC: I only tagged numerical results, it did not make sense to me to do it for NaNs and Infs I think this is fine. R600: