Re: [Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

Quoting Jan Vesely (2017-08-23 12:38:53) > Hi Dylan, > > do you mind taking a look at the python parts? > > thanks, > Jan Sure, I have a few comments, but mostly this looks okay, my comments are mostly style nits anyway. Dylan > On Wed, 2017-08-16 at 20:39 -0400, Jan Vesely wrote: > > v2:

Re: [Piglit] [PATCH v2 3/3] cl: Replace handwritten vload tests with a generator

Hi Dylan, do you mind taking a look at the python parts? thanks, Jan On Wed, 2017-08-16 at 20:39 -0400, Jan Vesely wrote: > v2: simplify > mark local storage volatile > Passes on beignet(IVB), and intel CPU > > Signed-off-by: Jan Vesely > --- > clover on carrizo

Re: [Piglit] [PATCH] draw-pixels: fix KHR_no_error logic

On 08/23/2017 06:11 AM, Timothy Arceri wrote: --- This was my fault. The flaw was in my suggestion from the code review. You probably need to use PIGLIT_HAS_ERRORS as well. tests/general/draw-pixels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git