Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-04-11 Thread Dylan Baker
Quoting Mark Janes (2018-04-10 18:54:46) > Dylan Baker writes: > > > Quoting Marek Olšák (2018-04-10 14:22:10) > >> On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker wrote: > >> > >> Quoting Eric Anholt (2018-04-09 17:10:35) > >> > Marek Olšák

[Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map tests to make textures cube complete

2018-04-11 Thread Anthony Pesch
From: Anthony Pesch Update cube map tests to ensure cube map textures are cube complete before querying them. Querying a cube map which is not cube complete should set INVALID_OPERATION as per the OpenGL 4.6 Core spec: "An INVALID_OPERATION error is generated if the

[Piglit] [PATCH 2/3] arb_get_texture_sub_image: fix depth parameter when performing zero-sized texture queries

2018-04-11 Thread Anthony Pesch
From: Anthony Pesch Change zero-sized texture queries to pass a valid depth parameter, otherwise they should error as per the OpenGL 4.6 Core spec: "An INVALID_VALUE error is generated if the effective target is TEXTURE_1D, TEXTURE_1D_ARRAY, TEXTURE_2D or TEXTURE_RECTANGLE,

[Piglit] [PATCH] framework: update deqp mustpass list for text based mustpass

2018-04-11 Thread Dylan Baker
The current code has bit-rotted quite a bit, in late 2016 the format was changed from XML based to txt based, but the code was never updated. --- framework/test/deqp.py | 22 ++ piglit.conf.example| 6 +++--- 2 files changed, 9 insertions(+), 19 deletions(-) diff --git

Re: [Piglit] [PATCH] framework: update deqp mustpass list for text based mustpass

2018-04-11 Thread Eric Anholt
Dylan Baker writes: > The current code has bit-rotted quite a bit, in late 2016 the format was > changed from XML based to txt based, but the code was never updated. > --- I think you can remove the elementtree import now. Other than that, Reviewed-by: Eric Anholt

Re: [Piglit] [PATCH 1/3] arb_get_texture_sub_image: fix expected error when querying a level which hasn't been explicitly defined

2018-04-11 Thread Juan A. Suarez Romero
Pushed! On Wed, 2018-04-11 at 09:45 -0700, Anthony Pesch wrote: > From: Anthony Pesch > > Change expected error from INVALID_OPERATION to INVALID_VALUE when querying a > level which hasn't been explicitly defined. The level is valid, however, the > level hasn't been

Re: [Piglit] [PATCH] framework: update deqp mustpass list for text based mustpass

2018-04-11 Thread Dylan Baker
Quoting Dylan Baker (2018-04-11 13:39:26) > Quoting Eric Anholt (2018-04-11 12:09:34) > > Dylan Baker writes: > > > > > The current code has bit-rotted quite a bit, in late 2016 the format was > > > changed from XML based to txt based, but the code was never updated. > > >

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-04-11 Thread Marek Olšák
On Tue, Apr 10, 2018 at 9:54 PM, Mark Janes wrote: > Dylan Baker writes: > > > Quoting Marek Olšák (2018-04-10 14:22:10) > >> On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker > wrote: > >> > >> Quoting Eric Anholt (2018-04-09

Re: [Piglit] [PATCH] framework: update deqp mustpass list for text based mustpass

2018-04-11 Thread Dylan Baker
Quoting Eric Anholt (2018-04-11 12:09:34) > Dylan Baker writes: > > > The current code has bit-rotted quite a bit, in late 2016 the format was > > changed from XML based to txt based, but the code was never updated. > > --- > > I think you can remove the elementtree import

Re: [Piglit] [PATCH] framework: update deqp mustpass list for text based mustpass

2018-04-11 Thread Dylan Baker
Quoting Dylan Baker (2018-04-11 13:39:26) > Quoting Eric Anholt (2018-04-11 12:09:34) > > Dylan Baker writes: > > > > > The current code has bit-rotted quite a bit, in late 2016 the format was > > > changed from XML based to txt based, but the code was never updated. > > >