On ARM, musl does not define FE_* when the architecture does not have VFP (which
is the right interpretation).
As these tests depend on calling fesetround(), skip the test if FE_UPWARD isn't
available.
Signed-off-by: Ross Burton
---
tests/general/roundmode-getintegerv.c | 12
If built with -Werror=format-security then Piglit fails to build:
/tests/spec/arb_texture_view/rendering-layers-image.c:150:8:
error: format not a string literal and no format arguments
[-Werror=format-security]
(desc)); \
^~
In this case test->uniform_type is being turned
On Friday, 2018-11-30 15:50:51 +, Ross Burton wrote:
> If built with -Werror=format-security then Piglit fails to build:
>
> /tests/spec/arb_texture_view/rendering-layers-image.c:150:8:
> error: format not a string literal and no format arguments
> [-Werror=format-security]
>
On Friday, 2018-11-30 18:31:16 +, Burton, Ross wrote:
> On Fri, 30 Nov 2018 at 17:44, Eric Engestrom wrote:
> > On Friday, 2018-11-30 16:33:23 +, Ross Burton wrote:
> > > On ARM, musl does not define FE_* when the architecture does not have VFP
> > > (which
> > > is the right
On 30/11/2018 13:58, Eric Engestrom wrote:
Instead of using the fact this one driver currently doesn't support this
one format, let's just use a format that will never be supported by
anyone.
Maybe put it in tests/util/piglit-framework-gl/piglit_drm_dma_buf.h ?
Signed-off-by: Eric
On Fri, 30 Nov 2018 at 12:45, Eric Engestrom wrote:
> On Friday, 2018-11-30 10:45:06 +, Ross Burton wrote:
> I'm not sure this macro has any reason to exist though, it's only used once,
> doesn't do any macro magic, uses each of its params exactly once...
> I would really recommend dropping
On 30/11/2018 13:59, Eric Engestrom wrote:
Signed-off-by: Eric Engestrom
Reviewed-by: Lionel Landwerlin
---
tests/opengl.py | 3 +--
.../ext_image_dma_buf_import/CMakeLists.gles1.txt | 2 +-
...ntel_unsupported_format.c =>
On Fri, 30 Nov 2018 at 17:44, Eric Engestrom wrote:
> On Friday, 2018-11-30 16:33:23 +, Ross Burton wrote:
> > On ARM, musl does not define FE_* when the architecture does not have VFP
> > (which
> > is the right interpretation).
> >
> > As these tests depend on calling fesetround(), skip
Erm, yeah, sorry about that. Grabbing a patch that we've been
shipping without actually looking at it.
Ross
On Fri, 30 Nov 2018 at 12:37, Eric Engestrom wrote:
>
> On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote:
> > From: Khem Raj
> >
> > On ARM, musl does not define FE_* when arch
Okay, revised patch submitted, which hopefully does the right thing this time.
Ross
On Fri, 30 Nov 2018 at 15:54, Burton, Ross wrote:
>
> Erm, yeah, sorry about that. Grabbing a patch that we've been
> shipping without actually looking at it.
>
> Ross
> On Fri, 30 Nov 2018 at 12:37, Eric
On Friday, 2018-11-30 16:33:23 +, Ross Burton wrote:
> On ARM, musl does not define FE_* when the architecture does not have VFP
> (which
> is the right interpretation).
>
> As these tests depend on calling fesetround(), skip the test if FE_UPWARD
> isn't
> available.
>
> Signed-off-by:
From: Pascal Bach
WAYLAND_wayland-client_INCLUDEDIR is an internal variable and is not correctly
set when cross compiling. WAYLAND_INCLUDE_DIRS includes the correct path even
when cross compiling.
Signed-off-by: Pascal Bach
---
tests/util/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+),
If built with -Werror=format-security then Piglit fails to build:
/tests/spec/arb_texture_view/rendering-layers-image.c:150:8:
error: format not a string literal and no format arguments
[-Werror=format-security]
(desc)); \
^~
In this case test->uniform_type is being turned
From: Khem Raj
On ARM, musl does not define FE_* when arch does not have
VFP, (which is right interpretation), therefore check if
it is defined before using it.
Fixes errors like:
tests/general/roundmode-pixelstore.c:82:19: error: 'FE_UPWARD' undeclared
(first use in this function)
ret =
On Friday, 2018-11-30 10:45:06 +, Ross Burton wrote:
> If built with -Werror=format-security then Piglit fails to build:
>
> /tests/spec/arb_texture_view/rendering-layers-image.c:150:8:
> error: format not a string literal and no format arguments
> [-Werror=format-security]
>
On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote:
> From: Khem Raj
>
> On ARM, musl does not define FE_* when arch does not have
> VFP, (which is right interpretation), therefore check if
> it is defined before using it.
>
> Fixes errors like:
>
>
Hello,
Could somebody take a look at this patch?
Thanks a lot,
Andrii.
On Tue, Nov 6, 2018 at 12:33 PM andrey simiklit
wrote:
> Hi all,
>
> Have somebody some suggestions for this test?
> This patch is needed to test an issue (assertion in mesa) which will be
> fixed by this mesa patch:
>
Signed-off-by: Eric Engestrom
---
tests/opengl.py | 3 +--
.../ext_image_dma_buf_import/CMakeLists.gles1.txt | 2 +-
...ntel_unsupported_format.c => unsupported_format.c} | 11 +--
3 files changed, 3 insertions(+), 13 deletions(-)
rename
Instead of using the fact this one driver currently doesn't support this
one format, let's just use a format that will never be supported by
anyone.
Signed-off-by: Eric Engestrom
---
.../ext_image_dma_buf_import/intel_unsupported_format.c| 7 ++-
1 file changed, 6 insertions(+), 1
DRM_FORMAT_INVALID was meant to be an nonexistent format but ironically,
the name does exist now, so let's just rename it to what it really means.
Signed-off-by: Eric Engestrom
---
tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Figured as much, hence marked as "extra credit" :)
On Fri, Nov 30, 2018 at 12:02 AM Marek Olšák wrote:
>
> Yeah, I know you meant a different one. I'm not really so into writing tests
> for AMD_texture_texture4 though.
>
> Marek
>
> On Thu, Nov 29, 2018 at 6:02 PM Ilia Mirkin wrote:
>>
>> I
21 matches
Mail list logo
