Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Hello, Thanks for review. I will fix all these issues and provide v2 shortly :) Thanks, Andrii. On Mon, Dec 3, 2018 at 12:37 PM Erik Faye-Lund wrote: > Just a few nits, do with them as you like. The test itself looks good > to me :) > > Reviewed-by: Erik Faye-Lund > > On Tue, 2018-10-23 at

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

On Mon, 2018-12-03 at 13:31 +0200, andrey simiklit wrote: > Hello, > > Thanks for review. > I will fix all these issues and provide v2 shortly :) > > Thanks, > Andrii. > > On Mon, Dec 3, 2018 at 12:37 PM Erik Faye-Lund < > erik.faye-l...@collabora.com> wrote: > > Just a few nits, do with them

Re: [Piglit] [PATCH] travis: reflect new best-practice travis-ci configuration

This is: Reviewed-by: Andres Gomez On Sun, 2018-12-02 at 11:28 -0500, Rhys Kidd wrote: > Travis-CI has or will shortly make in early December 2018 a number of > beneficial > changes to their Linux continuous integration testing infrastructure [0][1]. > An accompanying benefit of this change is

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Just a few nits, do with them as you like. The test itself looks good to me :) Reviewed-by: Erik Faye-Lund On Tue, 2018-10-23 at 16:44 +0300, asimiklit.w...@gmail.com wrote: > From: Andrii Simiklit > > Test that usage of upside down miptree doesn't cause assertion > > The miptree: > > level

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

On Mon, Dec 3, 2018 at 1:50 PM Erik Faye-Lund wrote: > On Mon, 2018-12-03 at 13:31 +0200, andrey simiklit wrote: > > Hello, > > > > Thanks for review. > > I will fix all these issues and provide v2 shortly :) > > > > Thanks, > > Andrii. > > > > On Mon, Dec 3, 2018 at 12:37 PM Erik Faye-Lund < >

[Piglit] [PATCH v2] miptree: test ability to use upside down miptree

From: Andrii Simiklit Test that usage of upside down miptree doesn't cause assertion The miptree: level 0 = 1x1 level 1 = 2x2 level 2 = 4x4 ... level n = NxN should be acceptable for case when we don't use a min filter. v2: - Unnecessary function calls were removed - The 'glClearColor'

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Hello, I think that I found one more issue (small but anyway issue) in my patch. The texture which is created in 'setup_texture' function is never released ( I would like to delete it at end of the 'piglit_display'. Regards, Andrii. On Mon, Dec 3, 2018 at 4:14 PM andrey simiklit wrote: > On

Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree

Hello, If this patch is acceptable by everybody then I guess that we need to push the following mesa patch before this one to avoid errors from Intel CI because the fix for an issue which is tested by this test is still there. https://patchwork.freedesktop.org/patch/254397/ One of the last

Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree

It's preferable to push piglit tests first, and produce the CI test failure. CI staff will track the failure, and attribute it to the piglit patch. When the subsequent mesa patch is pushed, we track the resolution. The process gives us artifacts in git that help to analyze driver differences

[Piglit] [PATCH v2 02/19] nv_image_formats/copy-image-formats: Convert to use subtests

This allows the framework to know what tests will be run, and doesn't actually make the implementation much more complicated. --- .../nv_image_formats/copy-image-formats.c | 66 +++ 1 file changed, 37 insertions(+), 29 deletions(-) diff --git

[Piglit] [PATCH v2 06/19] tests: Use a helper function in gl-1.0-rendermode-feedback

This is ground work for using proper subtest handling, it's a big enough change it makes sense to me to split it into a separate commit. --- tests/spec/gl-1.0/rendermode-feedback.c | 77 + 1 file changed, 40 insertions(+), 37 deletions(-) diff --git

[Piglit] [PATCH v2 12/19] tests/ext_transform_feedback-max-varyings: Always report subtests

--- tests/spec/ext_transform_feedback/max-varyings.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/ext_transform_feedback/max-varyings.c b/tests/spec/ext_transform_feedback/max-varyings.c index 1f83b60aa..b8c98a5d5 100644 --- a/tests/spec/ext_transform_feedback/max-varyings.c

[Piglit] [PATCH v2 19/19] tests/ext_polygon_offset_clamp-draw: use subtest framework

v2: - don't put config inside #ifdef opengl - de-duplicate comment --- tests/spec/ext_polygon_offset_clamp/draw.c | 124 + 1 file changed, 78 insertions(+), 46 deletions(-) diff --git a/tests/spec/ext_polygon_offset_clamp/draw.c

[Piglit] [PATCH v2 17/19] tests/ext_semaphore-api-errors: Use subtest mechanism

--- tests/spec/ext_semaphore/api-errors.c | 110 +++--- 1 file changed, 63 insertions(+), 47 deletions(-) diff --git a/tests/spec/ext_semaphore/api-errors.c b/tests/spec/ext_semaphore/api-errors.c index a7fd93ade..be8a0c7cf 100644 --- a/tests/spec/ext_semaphore/api-errors.c

[Piglit] [PATCH v2 10/19] tests/gl-1.0-beginend-coverage: enumerate subtests

This doesn't add support for running specific subtests, but it does enumerate the ones that exist. --- tests/spec/gl-1.0/beginend-coverage.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/spec/gl-1.0/beginend-coverage.c

[Piglit] [PATCH v2 18/19] tests/ext_semaphore-api-errors: Fix typo "usigned" -> "unsigned"

--- tests/spec/ext_semaphore/api-errors.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/ext_semaphore/api-errors.c b/tests/spec/ext_semaphore/api-errors.c index be8a0c7cf..b1c426cc5 100644 --- a/tests/spec/ext_semaphore/api-errors.c +++

[Piglit] [PATCH v2 14/19] tests/ext_transform_feedback-max-varyings: remove duplicate configs

This has config.supports_gl_compat_version = 10, then calls piglit_require_GL_version(20), so just set the value in the config to 20 and remove the other. --- tests/spec/ext_transform_feedback/max-varyings.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Piglit] [PATCH v2 13/19] tests/ext_transform_feedback-max-varyings: fix result reporting

Currently if the first subtest failed then the second subtest (AoA) would always report fail, this is bad. Instead we want to report fail, but leave status (which is set to warn in the implementation doesn't meet certain assumptions by the test), so that the second test can report accurately. ---

[Piglit] [PATCH v2 03/19] mesa_pack_invert/readpixels: enumerate subtests

It's not immediately obvious whether this test is suitable for piglit_run_selected_subtests, so just enumerate the subtests it has so that the framework can catch crashes. --- tests/spec/mesa_pack_invert/readpixels.c | 9 + 1 file changed, 9 insertions(+) diff --git

[Piglit] [PATCH v2 07/19] tests: use subtest framework for gl-1.0-rendermode-feedback

--- tests/spec/gl-1.0/rendermode-feedback.c | 57 +++-- 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/tests/spec/gl-1.0/rendermode-feedback.c b/tests/spec/gl-1.0/rendermode-feedback.c index 532c55914..2260370a3 100644 ---

[Piglit] [PATCH v2 08/19] tests: use subtest frameowrk in gl-1.0-dlist-beginend

--- tests/spec/gl-1.0/dlist-beginend.c | 138 ++--- 1 file changed, 85 insertions(+), 53 deletions(-) diff --git a/tests/spec/gl-1.0/dlist-beginend.c b/tests/spec/gl-1.0/dlist-beginend.c index 644b84cce..eca32c1f3 100644 --- a/tests/spec/gl-1.0/dlist-beginend.c +++

[Piglit] [PATCH v2 04/19] tests: Use piglit_run_selected_subtest in gl-3.0-render-integer

--- tests/spec/gl-3.0/render-integer.c | 100 - 1 file changed, 55 insertions(+), 45 deletions(-) diff --git a/tests/spec/gl-3.0/render-integer.c b/tests/spec/gl-3.0/render-integer.c index 2937ec50c..ca2e1fe40 100644 --- a/tests/spec/gl-3.0/render-integer.c +++

[Piglit] [PATCH v2 09/19] tests/gl-1.0/beginend-coverage: Run nondlist tests

Which have never been run, though the array has been present since the test was added. --- tests/spec/gl-1.0/beginend-coverage.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/gl-1.0/beginend-coverage.c b/tests/spec/gl-1.0/beginend-coverage.c index d36cc11c4..67792296a 100644

[Piglit] [PATCH v2 11/19] tests/ext_window_rectangles-dlist: enumerate subtests

I can't really test that this works, so just enumerating will have to be enough. --- tests/spec/ext_window_rectangles/dlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/ext_window_rectangles/dlist.c b/tests/spec/ext_window_rectangles/dlist.c index 59836544f..3f1eb9d73

[Piglit] [PATCH v2 15/19] tests/ext_transform_feedback-max-varyings: use subtest framework

This allows each test to be selected at runtime. --- .../ext_transform_feedback/max-varyings.c | 147 +++--- 1 file changed, 94 insertions(+), 53 deletions(-) diff --git a/tests/spec/ext_transform_feedback/max-varyings.c b/tests/spec/ext_transform_feedback/max-varyings.c index

[Piglit] [PATCH v2 05/19] tests: Fix indent in gl-1.0/vertex-program-two-side

It's just cosmetic. --- tests/spec/gl-2.0/vertex-program-two-side.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c b/tests/spec/gl-2.0/vertex-program-two-side.c index 4623c70a6..65e6b7650 100644 ---

[Piglit] [PATCH v2 16/19] tests/ext_semaphore_fd-api-errors: Enumerate subtests

--- tests/spec/ext_semaphore_fd/api-errors.c | 52 ++-- 1 file changed, 31 insertions(+), 21 deletions(-) diff --git a/tests/spec/ext_semaphore_fd/api-errors.c b/tests/spec/ext_semaphore_fd/api-errors.c index b0e14b636..2a1414e50 100644 ---

[Piglit] [PATCH v2 01/19] test/logicop: Use piglit_subtest mechanism

This coverts the test to use the piglit_run_selected_subtests function, which provides a nicer mechanism for running selected subtests, and enumerates all subtests ahead of time. --- tests/spec/gl-1.0/logicop.c | 97 - 1 file changed, 41 insertions(+), 56