- Original Message -
The call to glTexImage2D(internalFormat=GL_DEPTH_STENCIL,
format=GL_RGBA,
type=GL_UNSIGNED_BYTE) generated in invalid operation error since the
formats disagreed. The subsquent glFramebufferTexture2D() calls
failed
too. And Mesa hit a failed assertion (ex:
This patch series tests that MSAA works properly across a variety of
framebuffer formats, in particular: integer formats, floating point
formats, RED and RG formats, and sRGB formats.
Patches 01-03 lay the necessary infrastructure groundwork, by
refactoring piglit-util-gl.c and
This patch splits off a new piglit-util function,
piglit_compare_images_color(), from the existing
piglit_probe_image_color() function. The new function compares two
images in memory, so that the caller can take responsibility for
calling glReadPixels().
In addition, this patch creates a
In order to test that MSAA works properly for integer framebuffers, we
will need to be able to adjust the outputs of the
ColorGradientSunburst program to cover the range of signed or unsigned
integers, rather than the range [0, 1] that is appropriate for testing
normalized color framebuffers.
This patch adapts the MSAA formats test so that it can draw to
integer framebuffers, by creating 3 instantiations of the
ColorGradientSunburst class, one for testing vec4's (for floating
point and normalized formats), one for testing ivec4's (for signed
integer formats), and one for testing
This patch adapts the MSAA formats test so that when drawing into
integer framebuffers, it applies the necessary scale and offset to
cover the entire range of possible integer values. When reading
pixels back from the framebuffer, the test applies the inverse scale
and offset, so that the result
The MSAA formats test now properly tests integer framebuffer
formats. This patch updates all.tests to cause integer framebuffer
formats to be tested.
---
tests/all.tests |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/tests/all.tests b/tests/all.tests
index
---
tests/spec/ext_framebuffer_multisample/formats.cpp | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp
b/tests/spec/ext_framebuffer_multisample/formats.cpp
index d2386ad..a55f053 100644
---
The switch statement in visualize_image() wasn't properly handling
formats whose base internal format is GL_RED or GL_RG. As a result,
tests of these formats showed up as a black screen. This patch addes
switch cases to handle the formats properly.
---
When setting up a floating-point format, the GL implementation
responds to queries GL_ATTACHMENT_{RED,GREEN,BLUE,ALPHA}_SIZE with the
total number of bits in the floating-point value, regardless of
whether those bits are used for sign, exponent, or mantissa. However,
for the purpose of setting a
The MSAA formats test now properly tests RED and RG format
framebuffers. This patch updates all.tests to cause those formats to
be tested.
---
tests/all.tests |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/tests/all.tests b/tests/all.tests
index a01ba4a..2a636f3
The MSAA formats test now properly tests floating point formats.
This patch updates all.tests to cause those formats to be tested.
---
tests/all.tests |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tests/all.tests b/tests/all.tests
index 3f4ab26..a01ba4a 100644
---
From the GL spec, version 4.2, section 4.1.11 (Additional Multisample
Fragment Operations):
If a framebuffer object is not bound, after all operations have
been completed on the multisample buffer, the sample values for
each color in the multisample buffer are combined to produce a
The MSAA formats test now properly tests sRGB format framebuffers.
This patch updates all.tests to cause those formats to be tested.
---
tests/all.tests |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/all.tests b/tests/all.tests
index 755eace..2102faa 100644
---
sRGB buffers use a different blending operation to do multisample
resolves from non-sRGB buffers. Accordingly, when testing sRGB
formats, we need to use an sRGB reference image. This patch modifies
the MSAA formats test so that when testing an sRGB format, it
renders the reference image using
This patch adapts the MSAA formats test to pass the proper
parameters to glReadPixels() when checking that the proper image has
been rendered. Since glReadPixels() requires an integral type when
reading pixels from an integer framebuffer, we read the pixels into a
temporary integer buffer and
In order to test that MSAA works properly for integer framebuffers, we
will need to be able to output ivec4 and uvec4 types when rendering
the test image. This patch makes that possible by adapting the
Sunburst GLSL program so that it can be compiled to output ivec4's,
uvec4's, or vec4's.
---
Theorically, we should also test that as the fragment shader level,
but the code would be way more complex and the code paths are shared
in mesa.
That was designed to fix the issue in llvmpipe (which also exists in
textureSize). NVidia passes. Surprisingly enough, softpipe fails.
On 06/15/2012 10:27 AM, Brian Paul wrote:
On Fri, Jun 15, 2012 at 11:18 AM, Chad Versace
chad.vers...@linux.intel.com wrote:
On 06/13/2012 10:25 AM, Chad Versace wrote:
On 06/13/2012 09:06 AM, Brian Paul wrote:
On 06/12/2012 05:02 PM, Chad Versace wrote:
Could you check this into a branch
19 matches
Mail list logo
