Re: [Piglit] [PATCH 06/16] msaa/formats: Compare integer formats properly.

2012-06-21 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry wrote: > This patch adapts the MSAA "formats" test to use > piglit_compare_images_color() to check pass/fail instead of > piglit_probe_image_color().  This will allow integer formats to be > tested. > --- >  tests/spec/ext_framebuffer_multisample/formats

Re: [Piglit] [PATCH 04/16] msaa/formats: Adapt test pattern drawing to handle integer formats.

2012-06-21 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry wrote: > This patch adapts the MSAA "formats" test so that it can draw to > integer framebuffers, by creating 3 instantiations of the > ColorGradientSunburst class, one for testing vec4's (for floating > point and normalized formats), one for testing ive

Re: [Piglit] [PATCH 03/16] msaa: Make it possible to scale and offset ColorGradientSunburst.

2012-06-21 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry wrote: > In order to test that MSAA works properly for integer framebuffers, we > will need to be able to adjust the outputs of the > ColorGradientSunburst program to cover the range of signed or unsigned > integers, rather than the range [0, 1] that is

Re: [Piglit] [PATCH 02/16] msaa: Make it possible to change output type when drawing sunbursts.

2012-06-21 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry wrote: > In order to test that MSAA works properly for integer framebuffers, we > will need to be able to output ivec4 and uvec4 types when rendering > the test image.  This patch makes that possible by adapting the > Sunburst GLSL program so that it can

[Piglit] [PATCH] Make piglitutil library API-independent

2012-06-21 Thread Blaž Tomažič
Currently all utility libraries (piglitutil, piglitutil_gles1, piglitutil_gles2) have built-in the same API-independent code and the code from piglit-util.{c,h} contains OpenGL functionality. To share more code across different APIs (e.g. OpenCL, OpenGL) this code should be split. piglit-util.{c,h}

Re: [Piglit] [PATCH 01/16] util: Make a separate function to compare in-memory images.

2012-06-21 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry wrote: > This patch splits off a new piglit-util function, > piglit_compare_images_color(), from the existing > piglit_probe_image_color() function.  The new function compares two > images in memory, so that the caller can take responsibility for > calli

Re: [Piglit] NOTICE: piglit_{width, height, window_mode} are no longer used

2012-06-21 Thread Chad Versace
On 06/21/2012 06:50 AM, Brian Paul wrote: > On 06/20/2012 05:58 PM, Chad Versace wrote: >> I just committed a series that changes the way test executables should be >> written. This only affects tests written in C. >> The variables piglit_width, piglit_height, and piglit_window_mode are no >> lon

[Piglit] [PATCH] ext_framebuffer_multisample: fix turn-on-off test

2012-06-21 Thread Anuj Phogat
Set combine_depth_stencil flag to true while creating multisample FBO. This is to avoid "Framebuffer not complete" error message with drivers which don't allow creating separate depth and stencil attachments to a FBO. e.g. NVIDIA's proprietary drivers. Signed-off-by: Anuj Phogat --- .../ext_fram

[Piglit] [PATCH] msaa: Test that the "centroid" interpolation qualifier works correctly.

2012-06-21 Thread Paul Berry
This patch adds tests to verify that: - When GL_MULTISAMPLE is disabled, the "centroid" keyword is ignored, and interpolation is performed at pixel centers (consistent with the GL rules for non-antialiased rendering). - When GL_MULTISAMPLE is enabled and the "centroid" keyword is used, inte

Re: [Piglit] [PATCH] Test that dFdx/dFdy work properly on fbos

2012-06-21 Thread Paul Berry
On 20 June 2012 17:44, Chad Versace wrote: > On 06/20/2012 03:16 PM, Paul Berry wrote: > > This test exposes a bug in Mesa on i965 hardware (as of commit > > f2f05e5): the GLSL function dFdy() produces incorrect results when > > rendering to an FBO. This is a consequence of the fact that FBOs >

Re: [Piglit] NOTICE: piglit_{width, height, window_mode} are no longer used

2012-06-21 Thread Brian Paul
On 06/20/2012 05:58 PM, Chad Versace wrote: I just committed a series that changes the way test executables should be written. This only affects tests written in C. The variables piglit_width, piglit_height, and piglit_window_mode are no longer used. If you want to write this: int piglit

Re: [Piglit] [PATCH] Add a test to check whether the LODs are independant in parallel texture lookups.

2012-06-21 Thread Olivier Galibert
On Wed, Jun 20, 2012 at 07:56:08AM -0700, Jose Fonseca wrote: > I haven't tested it, but considering the recent discussion on mesa-dev about > this, it looks good to me. > > Do you have commit access to piglit? I don't have commit access to anything on fdo yet. Best, OG.