[Piglit] tests failing on freeglut

2012-06-22 Thread Dave Airlie
Hi guys, I haven't ran piglit in ages, went to give it a spin this morning and getting a lot of fails due to ./bin/fbo-fragcoord -auto -fbo freeglut ERROR: Function glutSwapBuffers called without first calling 'glutInit'. Which is perfectly true, but I've no idea where we should fix this.

Re: [Piglit] tests failing on freeglut

2012-06-22 Thread Paul Berry
On 22 June 2012 03:15, Dave Airlie airl...@gmail.com wrote: Hi guys, I haven't ran piglit in ages, went to give it a spin this morning and getting a lot of fails due to ./bin/fbo-fragcoord -auto -fbo freeglut ERROR: Function glutSwapBuffers called without first calling 'glutInit'.

Re: [Piglit] [PATCH] max-texture-size: allow INVALID_VALUE if first TexImage fails with OUT_OF_MEMORY

2012-06-22 Thread Marek Olšák
On Tue, Jun 19, 2012 at 7:41 PM, Eric Anholt e...@anholt.net wrote: On Fri, 15 Jun 2012 04:28:54 +0200, Marek Olšák mar...@gmail.com wrote: The GL spec says that the behavior of a command returning OUT_OF_MEMORY is undefined, therefore the following call to TexSubImage may return

Re: [Piglit] [PATCH] Make piglitutil library API-independent

2012-06-22 Thread Tom Stellard
On Fri, Jun 22, 2012 at 02:25:57AM +0200, Blaž Tomažič wrote: Currently all utility libraries (piglitutil, piglitutil_gles1, piglitutil_gles2) have built-in the same API-independent code and the code from piglit-util.{c,h} contains OpenGL functionality. To share more code across different APIs

Re: [Piglit] [PATCH 08/16] msaa/formats: Make it possible to specify a test set on the command line.

2012-06-22 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: ---  tests/spec/ext_framebuffer_multisample/formats.cpp |   13 ++---  1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp

Re: [Piglit] [PATCH 09/16] msaa/formats: Add EXT_texture_integer tests.

2012-06-22 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: The MSAA formats test now properly tests integer framebuffer formats.  This patch updates all.tests to cause integer framebuffer formats to be tested. ---  tests/all.tests |    9 +  1 files changed, 9

Re: [Piglit] [PATCH 14/16] msaa: Verify accuracy of sRGB MSAA resolves.

2012-06-22 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: From the GL spec, version 4.2, section 4.1.11 (Additional Multisample Fragment Operations):    If a framebuffer object is not bound, after all operations have    been completed on the multisample buffer, the sample

Re: [Piglit] [PATCH 15/16] msaa/formats: Fix testing of sRGB formats.

2012-06-22 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: sRGB buffers use a different blending operation to do multisample resolves from non-sRGB buffers.  Accordingly, when testing sRGB formats, we need to use an sRGB reference image.  This patch modifies the MSAA formats

Re: [Piglit] [PATCH] glsl-1.30: Verify proper conversion of large floats to uints.

2012-06-22 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/13/2012 04:59 PM, Paul Berry wrote: This patch adds two new tests that exercise a bug in Mesa/i965: conversion from float to uint was being done in a two step process: convert first to int and then to uint. Since i965 uses saturating

Re: [Piglit] [PATCH 10/16] msaa/formats: Adjust tolerance appropriately for floating-point formats.

2012-06-22 Thread Anuj Phogat
On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: When setting up a floating-point format, the GL implementation responds to queries GL_ATTACHMENT_{RED,GREEN,BLUE,ALPHA}_SIZE with the total number of bits in the floating-point value, regardless of whether those bits

Re: [Piglit] [PATCH 1/2] Add test to verify glSampleCoverage with multisample fbo

2012-06-22 Thread Paul Berry
On 20 June 2012 18:52, Anuj Phogat anuj.pho...@gmail.com wrote: This test varifies that the coverage value set by glSampleCoverage() decides the number of samples in multisample buffer covered by an incoming fragment, which will receive the fragment data. V2: Add the testing for

Re: [Piglit] [PATCH 2/2] Add test to verify sample alpha to coverage with multisample fbo

2012-06-22 Thread Paul Berry
On 20 June 2012 19:01, Anuj Phogat anuj.pho...@gmail.com wrote: This test varifies that with GL_SAMPLE_ALPHA_TO_COVERAGE enabled, the coverage value is set by fragment alpha value. Coverage value decides the number of samples in multisample buffer covered by an incoming fragment, which

Re: [Piglit] [PATCH 2/2] msaa: Test that msaa blits are clipped and scissored correctly.

2012-06-22 Thread Chad Versace
On 06/12/2012 03:14 PM, Paul Berry wrote: There are three reasons why the set of rectangles passed to glBlitFramebuffer() might need to be clipped before performing the blit: 1. If the destination rectangle falls (partly or completely) outside the bounds of the draw framebuffer. 2. If

Re: [Piglit] [PATCH] ext_framebuffer_multisample: fix turn-on-off test

2012-06-22 Thread Paul Berry
On 21 June 2012 13:39, Anuj Phogat anuj.pho...@gmail.com wrote: Set combine_depth_stencil flag to true while creating multisample FBO. This is to avoid Framebuffer not complete error message with drivers which don't allow creating separate depth and stencil attachments to a FBO. e.g. NVIDIA's

Re: [Piglit] [PATCH 14/16] msaa: Verify accuracy of sRGB MSAA resolves.

2012-06-22 Thread Paul Berry
On 22 June 2012 13:28, Anuj Phogat anuj.pho...@gmail.com wrote: On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: From the GL spec, version 4.2, section 4.1.11 (Additional Multisample Fragment Operations): If a framebuffer object is not bound, after all

Re: [Piglit] [PATCH] Make piglitutil library API-independent

2012-06-22 Thread Chad Versace
Blaz, Thanks for splitting the earlier patch into this series of 5. As a result, the changes were much easier to review. Everything looks good to me and is Reviewed-by: Chad Versace chad.vers...@linux.intel.com When you feel that the review process is complete and are ready to commit this,