Re: [Piglit] [PATCH 3/3] Transform feedback: Move piglit_require_transform_feedback().

2012-07-02 Thread Jordan Justen
Patch Series: Reviewed-by: Jordan Justen I assume you recommend I use piglit-util-gl.c for * piglit_require_primitive_restart * piglit_EnablePrimitiveRestart * piglit_DisablePrimitiveRestart (RE: [PATCH v2 1/2] util: add primitive restart util routines) Thanks, -Jordan On Mon, Jul 2, 2012 at 2

[Piglit] [PATCH 3/3] Transform feedback: Move piglit_require_transform_feedback().

2012-07-02 Thread Paul Berry
With the transform feedback wrapper functions removed, piglit_require_transform_feedback() was the only function left in piglit-transform-feedback.{c.h}. This patch moves it to piglit-util.c so that it won't get lonely. --- tests/util/CMakeLists.gl.txt |2 - tests/util/piglit-transf

[Piglit] [PATCH 2/3] Transform feedback: Eliminate wrapper functions.

2012-07-02 Thread Paul Berry
The wrapper functions in tests/util/piglit-transform-feedback.{c,h} (e.g. piglit_BeginTransformFeedback()), are no longer needed, since the piglit-dispatch mechanism automatically redirects to the EXT variants when GL 3.0 is not supported. This patch removes the unnecessary wrapper functions. ---

[Piglit] [PATCH 1/3] Transform feedback: Stop using wrapper functions.

2012-07-02 Thread Paul Berry
The wrapper functions in tests/util/piglit-transform-feedback.{c,h} (e.g. piglit_BeginTransformFeedback()) are no longer needed, since the piglit-dispatch mechanism automatically redirects to the EXT variants when GL 3.0 is not supported. This patch stops using the wrapper functions; the next patc

Re: [Piglit] [PATCH v2 2/2] ext_transform_feedback: Test Tranform Feedback with Primitive Restart

2012-07-02 Thread Jordan Justen
Whoops. I forgot to add the shader. I'll send another version. -Jordan On Mon, Jul 2, 2012 at 1:19 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- >  tests/all.tests                                    |    1 + >  .../spec/ext_transform_feedback/CMakeLists.gl.txt  |    1 + >  .../

[Piglit] [PATCH v2 2/2] ext_transform_feedback: Test Tranform Feedback with Primitive Restart

2012-07-02 Thread Jordan Justen
Signed-off-by: Jordan Justen --- tests/all.tests|1 + .../spec/ext_transform_feedback/CMakeLists.gl.txt |1 + .../ext_transform_feedback/primitive-restart.c | 115 3 files changed, 117 insertions(+) create mode 100644 tests/s

[Piglit] [PATCH v2 1/2] util: add primitive restart util routines

2012-07-02 Thread Jordan Justen
Add routines to handle GL 3.1 vs. GL_NV_primitive_restart differences for detecting & using primitive restart. Signed-off-by: Jordan Justen --- tests/util/CMakeLists.gl.txt |2 + tests/util/piglit-core-ext-wrappers.c | 66 + tests/util/piglit-core-e

[Piglit] [PATCH v2 0/2] Add transform feedback testing with primitive-restart testing

2012-07-02 Thread Jordan Justen
v2: * Support primitive restart on GL 3.1 & GL_NV_primitive_restart * Make sure index 0xff exists in the vertex array. Therefore if primitive restart is not working, then the number of generated primitives will increase, and this will cause an error to be generated. * Do not assert if a

Re: [Piglit] [PATCH] Add negative test for GL_SAMPLE_ALPHA_TO_ONE

2012-07-02 Thread Eric Anholt
Anuj Phogat writes: > This test varifies that alpha value is not changed with > GL_SAMPLE_ALPHA_TO_ONE enabled if GL_MULTISAMPLE is disabled > or buffer is not a multisample buffer. The "negative-" prefix on a test name has been for API tests that should just produce errors, and is something we

[Piglit] [PATCH] util: check for valid file type in piglit_load_text_file()

2012-07-02 Thread Brian Paul
Piglit would segfault if piglit_load_text_file() was accidentally passed a directory name instead of a filename. Now return NULL if the file is not regular or a symlink. --- tests/util/piglit-util.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/tests/util/piglit-u

[Piglit] [PATCH 7/7] GL_ARB_ubo/maxblocks: New test for rendering with varying numbers of blocks.

2012-07-02 Thread Eric Anholt
--- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + tests/spec/arb_uniform_buffer_object/maxblocks.c | 336 3 files changed, 338 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object/

[Piglit] [PATCH 6/7] GL_ARB_ubo/row-major: New test for setting/getting matrix layout qualifiers.

2012-07-02 Thread Eric Anholt
--- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + tests/spec/arb_uniform_buffer_object/row-major.c | 218 3 files changed, 220 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object/

[Piglit] [PATCH 3/7] GL_ARB_ubo/getactiveuniformblockname: New test for API behavior.

2012-07-02 Thread Eric Anholt
--- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + .../getactiveuniformblockname.c| 211 3 files changed, 213 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object

[Piglit] [PATCH 4/7] GL_ARB_ubo/getactiveuniformname: New test for API behavior.

2012-07-02 Thread Eric Anholt
This is a lot like getactiveuniformblockname. --- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + .../getactiveuniformname.c | 210 3 files changed, 212 insertions(+) create mod

[Piglit] [PATCH 5/7] GL_ARB_ubo/referenced-by-shader: Test two glGetActiveUniformBlockiv enums.

2012-07-02 Thread Eric Anholt
--- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + .../referenced-by-shader.c | 131 3 files changed, 133 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object/

[Piglit] [PATCH 1/7] GL_ARB_ubo/getprogramiv: New test for API behavior on linked programs.

2012-07-02 Thread Eric Anholt
--- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + .../spec/arb_uniform_buffer_object/getprogramiv.c | 150 3 files changed, 152 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object/

[Piglit] [PATCH 2/7] GL_ARB_ubo/uniformblockbinding: New test for setting/getting block bindings.

2012-07-02 Thread Eric Anholt
--- tests/all.tests|1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + .../uniformblockbinding.c | 159 3 files changed, 161 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object/

Re: [Piglit] [PATCH] Make piglitutil library API-independent

2012-07-02 Thread Eric Anholt
Chad Versace writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/26/2012 05:56 AM, Blaž Tomažič wrote: >> On pet, 2012-06-22 at 15:12 -0700, Chad Versace wrote: > >> I have received an email from Eric Anholt about the patches (don't >> know why he didn't cc the mailing list, he pr