[Piglit] [PATCH] oes_standard_derivatives: Add touch tests for the extension

2012-07-16 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Make sure that all the functions are available when they should be. This is currently broken in Mesa. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52003 --- tests/all.tests

Re: [Piglit] [PATCH 5/9] util: Add piglit_join_paths()

2012-07-16 Thread Chad Versace
+while (true) { +const char *p = va_arg(va, const char*); + +while (*p != 0) { +if (size_written == buf_size - 1) +break; You should probably return immediately here, otherwise you might set buf[buf_size -1 ] =

[Piglit] [PATCH 2/2] msaa: Check for proper error for operations prohibited on MSAA buffers.

2012-07-16 Thread Paul Berry
From the GL 3.0 spec, section 4.3.3, in the documentation for CopyPixels(): An INVALID_OPERATION error will be generated if the object bound to READ_FRAMEBUFFER_BINDING is framebuffer complete and the value of SAMPLE_BUFFERS is greater than zero. The same applies to CopyTexImage...()

[Piglit] [PATCH 01/12] msaa: Share visualize_image function by moving it to common.cpp

2012-07-16 Thread anuj . phogat
From: Anuj Phogat anuj.pho...@gmail.com visualize_image function is utilized by multiple msaa test cases. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/spec/ext_framebuffer_multisample/common.cpp | 84 tests/spec/ext_framebuffer_multisample/common.h|

[Piglit] [PATCH 09/12] msaa: Rewrite sample-alpha-to-coverage test to utilize the shared code

2012-07-16 Thread Anuj Phogat
Lot of the functions defined in this test case are also shared by draw-buffers-common.cpp. So this refactoring is done to avoid code duplication. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../ext_framebuffer_multisample/CMakeLists.gl.txt |3 +- .../sample-alpha-to-coverage.cpp

[Piglit] [PATCH 10/12] msaa: Rewrite sample-alpha-to-one test to utilize shared code

2012-07-16 Thread Anuj Phogat
Lot of the functions defined in this test case are also shared by draw-buffers-common.cpp. So this refactoring is done to avoid code duplication. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../ext_framebuffer_multisample/CMakeLists.gl.txt |3 +- .../sample-alpha-to-one.cpp

[Piglit] [PATCH 11/12] msaa: Add depth buffer testing support in draw-buffer-common.cpp

2012-07-16 Thread Anuj Phogat
Computes expected depth values and probes the depth buffer only for coverage value equal to 0.0 and 1.0 because depth buffer behaviour is undefined for intermediate coverage values. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../draw-buffers-common.cpp| 190

[Piglit] [PATCH 12/12] msaa: Add depth buffer testing to sample-alpha-to-coverage test case

2012-07-16 Thread Anuj Phogat
Tests the depth buffer only for coverage value equal to 0.0 and 1.0 because depth buffer behaviour is undefined for intermediate coverage values. This test found an issue with the current implemantation of msaa for i965 on mesa. Following patch on mesa makes this test to pass: [PATCH] i965/msaa: