Re: [Piglit] [PATCH] Test that glBlitFramebuffer works properly with nonzero miplevels.

2012-08-15 Thread Chad Versace
On 08/14/2012 01:23 PM, Paul Berry wrote: This patch adds a test to verify the proper operation of glBlitFramebuffer when blitting to and from miplevels other than zero. --- tests/all.tests|3 + .../spec/arb_framebuffer_object/CMakeLists.gl.txt |1

Re: [Piglit] [PATCH] ext_framebuffer_multisample: relax MSAA precision

2012-08-15 Thread Marek Olšák
It might be caused by the sample positions extending outside of the pixel boundary. I'll see if a different configuration passes the test. Marek On Wed, Aug 15, 2012 at 12:16 AM, Paul Berry stereotype...@gmail.com wrote: On 13 August 2012 10:31, Marek Olšák mar...@gmail.com wrote: r600g needs

Re: [Piglit] [PATCH 2/2] msaa: Add test to verify alpha-to-coverage when nothing is bound to draw buffer zero

2012-08-15 Thread Paul Berry
On 23 July 2012 15:28, Anuj Phogat anuj.pho...@gmail.com wrote: When nothing is bound to draw buffer zero, GL_SAMPLE_ALPHA_TO_COVERAGE still needs to work properly. Note: Test case passes using NVIDIA's proprietary linux drivers but fails on Mesa i965 drivers. Reviewed-by: Paul Berry

Re: [Piglit] [PATCH 3/3] msaa: Add test to verify sample-alpha-to-one with dual source blending

2012-08-15 Thread Paul Berry
On 31 July 2012 20:17, Anuj Phogat anuj.pho...@gmail.com wrote: src0_alpha should be modified if sample-alpha-to-one is enabled. Both src0 and src1 colorcan be used to determine blending factors. Note: Test passes on mesa i965 drivers but fails on NVIDIA's proprietary linux drivers. No

[Piglit] [PATCH] arb_fbo: Test glBlitFramebuffer on depth textures with nonzero miplevels

2012-08-15 Thread Chad Versace
Extend the framebuffer-blit-levels test to verify that glBlitFramebuffer works when blitting to and from miplevels other than zero for depth textures. CC: Paul Berry stereotype...@gmail.com --- .../framebuffer-blit-levels.c | 125 - 1 file changed, 94

Re: [Piglit] [PATCH] arb_fbo: Test glBlitFramebuffer on depth textures with nonzero miplevels

2012-08-15 Thread Chad Versace
On 08/15/2012 02:17 PM, Paul Berry wrote: On 15 August 2012 12:51, Chad Versace chad.vers...@linux.intel.com mailto:chad.vers...@linux.intel.com wrote: Extend the framebuffer-blit-levels test to verify that glBlitFramebuffer works when blitting to and from miplevels other than

Re: [Piglit] [PATCH 1/3] msaa: Make changes in shared code to accomodate dual-src-blending test cases

2012-08-15 Thread Anuj Phogat
[snip] +void +compute_blend_color(float *frag_color, int rect_count, + bool sample_alpha_to_one) +{ + float src_blend_factor, dst_blend_factor; + /* Taking in to account alpha values output by +* fragment shader. +*/ + float src0_alpha

[Piglit] [PATCH 1/3] msaa: Make changes in shared code to accomodate dual-src-blending test cases

2012-08-15 Thread Anuj Phogat
These changes are required to enable dual-src-blending test cases to use the shared code: Generate fragment shader which outputs relevant color values. Modify compute_expected_color() function to support dual-src-blending. V2: Removed unnecessary blitting code in case of dual-src-blending.