Chad,
Does this look close to the correct way to add GBM support
following your recent piglit framework refactor series?
-Jordan
--
Use gbm for testing if the PIGLIT_PLATFORM environment variable
is set to gbm.
Signed-off-by: Jordan Justen
---
CMakeLists.txt
Chris Forbes writes:
> These cases were missed by the original semantic patch due to using
> fprintf(stderr,... instead of printf.
Reviewed-by: Eric Anholt
pgpauaf6hL7Yi.pgp
Description: PGP signature
___
Piglit mailing list
Piglit@lists.freedesktop
Series tested and
Reviewed-by: Jordan Justen
On Fri, Sep 28, 2012 at 10:44 AM, Chad Versace
wrote:
> This series is on my framework-gl-v22 branch. It is 1.6 MB worth of patches,
> so I expect some patches to be dropped by the mailing list. For reference,
> the point where it diverges from maste
Brian Paul writes:
> ---
> tests/util/piglit-util-gl-common.c | 85
>
> tests/util/piglit-util-gl-common.h | 13 ++
Series is:
Reviewed-by: Eric Anholt
pgp9yzKMUvGNU.pgp
Description: PGP signature
___
P
Now I remember, I was waiting to send review to go look at the original
file to see if my review note made sense. I think there's a little
cleanup available:
Paul Berry writes:
> static void
> create_test_data(GLfloat *data, GLenum texture_format,
>unsigned level, unsigned widt
Generated from the following semantic patch.
@@
expression RET, MSG;
@@
- RET = glGetError();
- if (RET != 0) {
+ if (!piglit_check_gl_error(GL_NO_ERROR))
(
- printf(MSG,RET);
|
- fprintf(stderr,MSG,RET);
)
piglit_report_result(PIGLIT_
These cases were missed by the original semantic patch due to using
fprintf(stderr,... instead of printf.
Signed-off-by: Chris Forbes
---
tests/spec/arb_transform_feedback2/draw-auto.c | 5 +
tests/spec/ext_transform_feedback/interleaved.c | 5 +
tests/spec/ext_transform_feedback/output
On 09/19/2012 10:12 AM, Jordan Justen wrote:
> This better matches the interface of glGetStringi, which should be used
> for GL >= 3.0.
>
> Signed-off-by: Jordan Justen
The series is
Reviewed-by: Chad Versace
___
Piglit mailing list
Piglit@lists.free
Great! Just to be clear, I don't think that _all_ the
assert(glGetError() == 0); checks need to be replaced. In some cases
they seemed to be development/sanity checks (which could probably just
be removed). But in other cases it seems to be used to check that new
extension enum tokens are ac
