Re: [Piglit] [PATCH] draw-vertices-2101010: add half-scale color tests

2012-10-22 Thread Eric Anholt
Chris Forbes chr...@ijw.co.nz writes: Picks up the driver not bothering to normalize attribute values. This was broken in an early version of my i965 support for this extension. Could we get some enums instead of the integer index values? pgp2ROZR1dHMG.pgp Description: PGP signature

Re: [Piglit] [PATCH 1/2] GLX_OML_sync_control: Add new tests.

2012-10-22 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 10/19/2012 11:13 AM, Eric Anholt wrote: I was going to go touch this code in Mesa, then I realised that we didn't have a single test for it. v2: Rebase on Chad's BUILD_* sedjob, and explicitly test various swap intervals. A couple comments

Re: [Piglit] [PATCH 0/8] Add GBM support

2012-10-22 Thread Chad Versace
On 10/19/2012 06:32 PM, Jordan Justen wrote: On Fri, Oct 19, 2012 at 9:54 AM, Chad Versace chad.vers...@linux.intel.com wrote: This series looks good to me. Reviewed-by: Chad Versace chad.vers...@linux.intel.com I wanted to test the series, but the python patches wouldn't apply :( I

Re: [Piglit] [PATCH] add a PIGLIT_BUILD_GL_TESTS option

2012-10-22 Thread Chad Versace
NAK. Reasons below. As an alternative to this patch's method, I would change PIGLIT_HAS_X11 to be a cmake option, enabled by default on Linux, and base decisions on the option. I generally frown on build systems that make decisions based on autodetected dependencies. On 10/18/2012 11:11 AM,

Re: [Piglit] [PATCH] add a PIGLIT_BUILD_GL_TESTS option

2012-10-22 Thread Negreanu Marius
On Mon, Oct 22, 2012 at 11:52 PM, Chad Versace chad.vers...@linux.intel.com wrote: NAK. Reasons below. As an alternative to this patch's method, I would change PIGLIT_HAS_X11 to be a cmake option, enabled by default on Linux, and base decisions on the option. I generally frown on build

[Piglit] [PATCH] GLX_OML_sync_control: Add new tests.

2012-10-22 Thread Eric Anholt
I was going to go touch this code in Mesa, then I realised that we didn't have a single test for it. v2: Rebase on Chad's BUILD_* sedjob, and explicitly test various swap intervals. v3: Rewrite wrapping loops. --- tests/all.tests|8 ++