Re: [Piglit] [PATCH 1/2] arb_texture_cube_map_array: sample-cube-map-array-shadow sample from second layer

2012-11-05 Thread Brian Paul
On 11/03/2012 02:37 AM, Dave Airlie wrote: This test wasn't actually testing array behaviour at all, so wouldn't catch the case where the layer was getting lost. This modifies the test so that it samples from the second layer, and makes the contents of the first layer incorrect to catch this

Re: [Piglit] [PATCH 1/6] cmake: Use find_package to find Waffle

2012-11-05 Thread Chad Versace
On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com * replace pkg_check_modules with find_package * add FindWaffle.cmake Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com --- :100644 100644 2f4c213... 719cda1... M

Re: [Piglit] [PATCH 2/6] cmake,util: Add Android Waffle support

2012-11-05 Thread Chad Versace
This looks mostly correct. Two comments below. On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com +static void +enter_event_loop(struct piglit_winsys_framework

Re: [Piglit] [PATCH 3/6] cmake: Add an Android platform and toolchain

2012-11-05 Thread Chad Versace
On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com --- :00 100644 000... 9dd8b3c... A cmake/Modules/Compiler/Android.cmake :00 100644 000...

Re: [Piglit] [PATCH 5/6] cmake: Remove the REQUIRED flag for PNG

2012-11-05 Thread Chad Versace
Brian and Jose, Is libpng needed for the Windows build? It is unused on Linux. On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com I haven't found any references to png, except the README file, so I guess it's ok to remove the REQUIRED

Re: [Piglit] [PATCH 6/6] cmake: Request GLUT only when Waffle is not used

2012-11-05 Thread Chad Versace
On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanu adrian.m.negre...@intel.com Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com --- :100644 100644 b48fb5f... 9f1ca49... MCMakeLists.txt CMakeLists.txt | 30 +++--- 1

Re: [Piglit] [PATCH 5/6] cmake: Remove the REQUIRED flag for PNG

2012-11-05 Thread Brian Paul
I don't see any need for libpng either. -Brian On 11/05/2012 12:17 PM, Chad Versace wrote: Brian and Jose, Is libpng needed for the Windows build? It is unused on Linux. On 10/24/2012 06:11 AM, gro...@gmail.com wrote: From: Adrian Marius Negreanuadrian.m.negre...@intel.com I haven't found

[Piglit] [PATCH] Add test glsl-uniform-out-of-bounds-2.c

2012-11-05 Thread Frank Henigman
This test shows the problem fixed by my add bounds checking for uniform array access patch, sent to mesa-dev on Nov. 2. Check behavior of glGetUniformLocation, glGetUniform and glUniform(Matrix) when attempting to access non-existent array elements. --- tests/all.tests

Re: [Piglit] [PATCH] hiz, new depth test

2012-11-05 Thread Chad Versace
On 10/31/2012 06:38 AM, Tapani Pälli wrote: Hello, Here is a new test that tries to demonstrate failure with hiz code when frambuffer depth and color do not match. This failure happens for example with MESA_FORMAT_RGB565 color buffer and MESA_FORMAT_X8_Z24 depth buffer. This test seems to

[Piglit] [PATCH] Skip testing textures with depth-stencil formats in glGenerateMipmap

2012-11-05 Thread Anuj Phogat
depth-stencil formats are disallowed in glGenerateMipmap because the stencil component is not filterable. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/fbo/fbo-generatemipmap-formats.c | 41 +++ 1 files changed, 35 insertions(+), 6 deletions(-) diff

Re: [Piglit] [PATCH] hiz, new depth test

2012-11-05 Thread Chad Versace
On 11/05/2012 12:04 PM, Chad Versace wrote: On 10/31/2012 06:38 AM, Tapani Pälli wrote: Hello, Here is a new test that tries to demonstrate failure with hiz code when frambuffer depth and color do not match. This failure happens for example with MESA_FORMAT_RGB565 color buffer and

[Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-05 Thread Chad Versace
In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel Sandybridge. CC: Matt Turner matts...@gmail.com --- tests/egl/spec/egl_khr_create_context/invalid-gl-version.c | 3 +++ 1 file

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-11-05 Thread Marek Olšák
Why hasn't this patch been pushed yet? I guess we could later drop the ALPHA flag and have just RGB and RGBA. Marek On Mon, Oct 15, 2012 at 8:41 PM, Chad Versace chad.vers...@linux.intel.com wrote: Only request a visual with alpha if the test requests PIGLIT_GL_VISUAL_ALPHA. When I wrote

Re: [Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-05 Thread Matt Turner
On Mon, Nov 5, 2012 at 2:53 PM, Chad Versace chad.vers...@linux.intel.com wrote: In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel Sandybridge. CC: Matt Turner matts...@gmail.com

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-11-05 Thread Chad Versace
On 11/05/2012 03:57 PM, Marek Olšák wrote: Why hasn't this patch been pushed yet? I simply forgot. It's now pushed. I guess we could later drop the ALPHA flag and have just RGB and RGBA. I agree that we should. But I just haven't found enough time and intereset yet to write a script to do

Re: [Piglit] [PATCH] egl: Test more invalid GLES2 context versions

2012-11-05 Thread Chad Versace
On 11/05/2012 04:01 PM, Matt Turner wrote: On Mon, Nov 5, 2012 at 2:53 PM, Chad Versace chad.vers...@linux.intel.com wrote: In test egl-create-context-invalid-gl-version, try to create OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Fails with mesa-84b437 on Intel

[Piglit] [PATCH] egl: Test more invalid GLES1/GLES2 context versions (v2)

2012-11-05 Thread Chad Versace
In test egl-create-context-invalid-gl-version, try to create OpenGL ES1 and OpenGL ES2 contexts with additional invalid versions: 3.2, 3.9, 4.7. Also, quote the bit of the EGL_KHR_create_context spec that states EGL_BAD_MATCH should be emitted in this case. Fails with mesa-84b437 on Intel