On Fri, Jan 10, 2014 at 10:30 AM, Chad Versace
chad.vers...@linux.intel.com wrote:
On Tue, Jan 07, 2014 at 12:02:43AM +0800, Daniel Kurtz wrote:
Add these gles specific tests to CMakelists so they will be built when
targeting GLES.
Signed-off-by: Daniel Kurtz djku...@chromium.org
---
On Tue, Jan 07, 2014 at 12:02:37AM +0800, Daniel Kurtz wrote:
When using the PIGLIT_GL_TEST_CONFIG_* macros to create a test, a
piglit_gl_framework, 'gl_fw' is used to store gl framework state,
including core and extension gl dispatch handlers.
Just before running the actual test code,
On Tue, Jan 07, 2014 at 12:02:38AM +0800, Daniel Kurtz wrote:
We access tex[0] throught tex[3].
So, tex must have at least 4 elements.
This fixes a gcc warning:
warning: array subscript is above array bounds [-Warray-bounds]
glBindTexture(GL_TEXTURE_3D, tex[3]);
On Tue, Jan 07, 2014 at 12:02:39AM +0800, Daniel Kurtz wrote:
This test was missing from all.tests.
Signed-off-by: Daniel Kurtz djku...@chromium.org
---
tests/all.tests | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/all.tests b/tests/all.tests
index edf066b..5e7d007 100644
On Tue, Jan 07, 2014 at 12:02:41AM +0800, Daniel Kurtz wrote:
From GLSL_ES_Specification_3.0 [0]:
There is no default precision qualifier for the following sampler types in
either the vertex or fragment language:
sampler2DArray
[0]
On Tue, Jan 07, 2014 at 12:02:40AM +0800, Daniel Kurtz wrote:
glGenFramebuffers is not supported for OpenGL ES 1.X, so init_gl is
hard coded to always fail for ES1. Thus, there is no way to use a
fbo_framework w/ ES1. In this case, just fail faster in
piglit_fbo_framework_create() instead of
On Tue, Jan 07, 2014 at 12:02:42AM +0800, Daniel Kurtz wrote:
According to OpenGL ES 1.1 [0] and OpenGL ES 2.0 [1], for
glCopyTexImage2D:
GL_INVALID_ENUM is generated if internalformat is not an accepted constant.
[0] http://www.khronos.org/opengles/sdk/1.1/docs/man/glCopyTexImage2D.xml
The test relies on 0.01 being rounded to 3 in the uniform int texture.
However on NVIDIA hardware when using a 2D blit, 2.55 becomes 2, and so
the test fails. I don't see anything in the OpenGL spec that guarantees
any specific rounding logic (e.g. OpenGL 4.4 section 2.3.4.2) when
converting, so
On Fri, Jan 10, 2014 at 10:50:50AM -0800, Matt Turner wrote:
On Fri, Jan 10, 2014 at 10:30 AM, Chad Versace
chad.vers...@linux.intel.com wrote:
On Tue, Jan 07, 2014 at 12:02:43AM +0800, Daniel Kurtz wrote:
Add these gles specific tests to CMakelists so they will be built when
targeting
From: Ian Romanick ian.d.roman...@intel.com
There were two problem here. First, it is illegal in GLSL to redecalre
a built-in variable. Section 3.7 (Identifiers) of the GLSL 4.40 spec
says:
However, as noted in the specification, there are some cases where
previously declared variables
From: Ian Romanick ian.d.roman...@intel.com
Any minmax test should fail if the query either generates an error or
doesn't write a value to the destination. To facilitate this, the
storage location is initialized to a value that is unlikely to be
generated by the GL (0xDEADBEEF) instead of .
From: Ian Romanick ian.d.roman...@intel.com
This made it a bit easier to notice which cases were actually failing.
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
Cc: Jon Ashburn j...@lunarg.com
Cc: Courtney Goeltzenleuchter court...@lunarg.com
---
tests/spec/arb_viewport_array/minmax.c |
From: Ian Romanick ian.d.roman...@intel.com
Signed-off-by: Ian Romanick ian.d.roman...@intel.com
---
tests/shaders/glsl-arb-fragment-coord-conventions.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/shaders/glsl-arb-fragment-coord-conventions.c
(If you don't use Piglit's Waffle backend, then you can safely ignore
this announcement).
(If commit dca9752 from 2014-01-10 didn't break your build, then you too
can safely this announcement).
A recent commit, dca9752, bumped Piglit's Waffle requirement from 1.2 to
1.3. This was required to add
Fix GCC maybe-uninitialized warning.
fbo-rg.c:485:34: warning: 'internal_format' may be used uninitialized in this
function [-Wmaybe-uninitialized]
pass = render_and_check_textures(internal_format);
^
Signed-off-by: Vinson Lee v...@freedesktop.org
---
Fix GCC maybe-uninitialized warning.
fbo-scissor-blit.c:109:5: warning: 'blit_to_fbo' may be used uninitialized in
this function [-Wmaybe-uninitialized]
if (blit_to_fbo)
^
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/fbo/fbo-scissor-blit.c | 4 +++-
1 file changed, 3
Fix GCC maybe-uninitialized warning.
fbo-stencil.c:332:2: warning: 'res' may be used uninitialized in this function
[-Wmaybe-uninitialized]
return res;
^
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/fbo/fbo-stencil.c | 1 +
1 file changed, 1 insertion(+)
diff --git
This patch fixes these GCC warnings.
primitive-restart.c: In function 'read_index_value':
primitive-restart.c:253:1: warning: control reaches end of non-void function
[-Wreturn-type]
}
^
primitive-restart.c: In function 'test_draw_by_index':
primitive-restart.c:445:18: warning: 'restart_index'
Fix GCC maybe-uninitialized warnings.
glslparsertest.c: In function 'attach_dummy_shader':
glslparsertest.c:153:9: warning: 'shader_template' may be used uninitialized in
this function [-Wmaybe-uninitialized]
sprintf(shader_text,
^
glslparsertest.c: In function 'piglit_init':
Fix GCC maybe-uninitialized warning.
asmparsertest.c: In function 'piglit_init':
asmparsertest.c:243:10: warning: 'target' may be used uninitialized in this
function [-Wmaybe-uninitialized]
compile(argv[i], target, use_ARB);
^
Signed-off-by: Vinson Lee v...@freedesktop.org
---
Fix GCC maybe-uninitialized warning.
glsl-link-test.c: In function 'piglit_init':
glsl-link-test.c:124:10: warning: 'expect' may be used uninitialized in this
function [-Wmaybe-uninitialized]
fprintf(stderr,
^
Signed-off-by: Vinson Lee v...@freedesktop.org
---
This patch fixes these GCC warnings.
shaders/shader_runner.c: In function 'compare':
shader_runner.c:376:1: warning: control reaches end of non-void function
[-Wreturn-type]
}
^
shader_runner.c: In function 'comparison_string':
shader_runner.c:395:1: warning: control reaches end of non-void
22 matches
Mail list logo
