Re: [Piglit] running piglit tests with gl_version 31

2014-06-11 Thread Tapani
On 06/10/2014 04:55 PM, Dylan Baker wrote: Do you have s3tc installed? Yes I believe I have. Does this have some effect on the context creation? On Tuesday, June 10, 2014 08:42:26 AM Tapani Pälli wrote: On 06/09/2014 05:44 PM, Ilia Mirkin wrote: On Mon, Jun 9, 2014 at 5:58 AM, Tapani Pälli

Re: [Piglit] running piglit tests with gl_version 31

2014-06-11 Thread Dylan Baker
I don't think so, It's a pretty common reason to not get a 3.x+ context though. On Wednesday, June 11, 2014 10:48:18 AM Tapani wrote: On 06/10/2014 04:55 PM, Dylan Baker wrote: Do you have s3tc installed? Yes I believe I have. Does this have some effect on the context creation? On

[Piglit] [PATCH] polygon-line-aa test case added.

2014-06-11 Thread Iago Toral Quiroga
This tests correct rendering of polygons using antialised GL_LINE mode for one face and GL_FILL for the other one. On some Intel hardware at least this used to require special handling that has caused regressions in the past. The test checks that the GL_FILL face of the polygon renders properly.

[Piglit] [PATCH] exectest.py: Return early if _run_command() hits the except block

2014-06-11 Thread Dylan Baker
If the except block is hit in Test._run_command(), the test has a status of skip, but the test continues to run anyway. This is not consistent with the way Test.check_for_skip_scenario() works, and means more time is spent in python than needs to be. This patch adds a small check after

Re: [Piglit] [PATCH] exectest.py: Return early if _run_command() hits the except block

2014-06-11 Thread Jose Fonseca
Yes, that looks sensible and I've confirmed it fixed the mis-categorized skip-crashes too. Thanks Dylan. Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - If the except block is hit in Test._run_command(), the test has a status of skip, but the test continues

[Piglit] [PATCH v2] polygon-line-aa test case added.

2014-06-11 Thread Iago Toral Quiroga
This tests correct rendering of polygons using antialised GL_LINE mode for one face and GL_FILL for the other one. On some Intel hardware at least this used to require special handling that has caused regressions in the past. The test checks that the GL_FILL face of the polygon renders properly.

Re: [Piglit] [PATCH] Hook up two new EXT_packed_depth_stencil tests added recently

2014-06-11 Thread Brian Paul
On 06/11/2014 12:09 AM, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- tests/all.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/all.py b/tests/all.py index 3830013..4cd5e97 100644 --- a/tests/all.py +++

Re: [Piglit] [PATCH] arb_sample_shading: make sure gl_SampleMask has no effect when no ms

2014-06-11 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jun 11, 2014 at 2:11 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- .../arb_sample_shading/execution/builtin-gl-sample-mask-simple.cpp | 5 -

[Piglit] [PATCH] cl: Add test for alignment problems

2014-06-11 Thread Bruno Jiménez
This test currently give an endless loop when we try to add the first buffer for second time. --- tests/cl.py | 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/alignment-checker.c | 119 3 files changed, 121

[Piglit] [PATCH] arb_uniform_buffer_object: add new rendering test

2014-06-11 Thread Brian Paul
Add a test that actually draws something with uniform buffer objects along the lines of what an application might do. --- tests/all.py |1 + .../arb_uniform_buffer_object/CMakeLists.gl.txt|1 + tests/spec/arb_uniform_buffer_object/rendering.c |

[Piglit] [PATCH 2/5] cl: Add isgreater(float, float) relational tests

2014-06-11 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/generated_tests/generate-cl-relational-builtins.py b/generated_tests/generate-cl-relational-builtins.py index

[Piglit] [PATCH 1/5] cl: Add TRUE definition with type dependent value for generated tests

2014-06-11 Thread Aaron Watry
Scalar true is 1, but vector true is -1. This means that getValue needs to know if we are requesting TRUE for a scalar or vector. Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/genclbuiltins.py | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-)

[Piglit] [PATCH 3/5] cl: Add isgreaterequal(float, float) relational tests

2014-06-11 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-relational-builtins.py b/generated_tests/generate-cl-relational-builtins.py index

[Piglit] [PATCH 5/5] cl: Add signbit(float) relational tests

2014-06-11 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 9 + 1 file changed, 9 insertions(+) diff --git a/generated_tests/generate-cl-relational-builtins.py b/generated_tests/generate-cl-relational-builtins.py index f22f5d1..833a836 100644

[Piglit] [PATCH 4/5] cl: Add isnotequal(float, float) relational tests

2014-06-11 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-relational-builtins.py b/generated_tests/generate-cl-relational-builtins.py index

Re: [Piglit] [PATCH] cl-api-create-context-from-type: Remove unused variables.

2014-06-11 Thread Tom Stellard
On Sun, Jun 01, 2014 at 08:32:09PM -0700, Vinson Lee wrote: This patch fixes these GCC warnings. create-context-from-type.c: In function ‘piglit_cl_test’: create-context-from-type.c:173:24: warning: variable ‘invalid_platform_context_properties’ set but not used

[Piglit] Cleaning up Piglit's crazy build system and GLES1 dispatch

2014-06-11 Thread Chad Versace
I'm working to clean up Piglit's crazy build system, which builds each target multiple times, once for each supported API. You can track my progress here: git://people.freedesktop.org/~chadversary/piglit refs/heads/unify-build

[Piglit] [PATCH] fbo: test that swizzle doesn't affect mipmap generation

2014-06-11 Thread Robert Bragg
This is a regression test for a mesa meta bug fix whereby a swizzle set via GL_ARB_texture_swizzle was being applied while iteratively generating a mipmap. This meant the swizzle would be applied twice by the time the application sampled those generated layers. The bug was originally noticed with

[Piglit] [PATCH 1/3] cl: Add isequal(float) relational tests

2014-06-11 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/generated_tests/generate-cl-relational-builtins.py b/generated_tests/generate-cl-relational-builtins.py index 833a836..2a55fb7 100644

[Piglit] [PATCH 3/3] cl: Add mix tests

2014-06-11 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index b6b4e43..47752e8 100644 ---

[Piglit] [PATCH 2/3] cl: Add 3-arg TTS kernel type

2014-06-11 Thread Aaron Watry
For built-ins with (vec, vec, scalar) arguments (such as mix) Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/genclbuiltins.py | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/generated_tests/genclbuiltins.py

Re: [Piglit] [PATCH v2] polygon-line-aa test case added.

2014-06-11 Thread Dylan Baker
On Wednesday, June 11, 2014 01:03:20 PM Iago Toral Quiroga wrote: This tests correct rendering of polygons using antialised GL_LINE mode for one face and GL_FILL for the other one. On some Intel hardware at least this used to require special handling that has caused regressions in the past.

Re: [Piglit] [PATCH] exectest.py: Return early if _run_command() hits the except block

2014-06-11 Thread Dylan Baker
On Wednesday, June 11, 2014 03:31:26 AM Dylan Baker wrote: If the except block is hit in Test._run_command(), the test has a status of skip, but the test continues to run anyway. This is not consistent with the way Test.check_for_skip_scenario() works, and means more time is spent in python

[Piglit] [PATCH] python: remove all tabs

2014-06-11 Thread Dylan Baker
Python doesn't really support mixed spaces and tabs well, and in python3 upstream finally did the sensible thing and made mixed tab and space indents a runtime error. This patch was generated with the following command on Linux: find . -name '*py' | xargs sed -i -e 's@\t@@g' It was then

Re: [Piglit] [PATCH] Hook up two new EXT_packed_depth_stencil tests added recently

2014-06-11 Thread Michel Dänzer
On 11.06.2014 21:03, Brian Paul wrote: On 06/11/2014 12:09 AM, Michel Dänzer wrote: From: Michel Dänzer michel.daen...@amd.com Signed-off-by: Michel Dänzer michel.daen...@amd.com --- tests/all.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/all.py b/tests/all.py index