Re: [Piglit] [PATCH 0/3] arb_gpu_shader5: tests to verify 'stream' layout qualifier

2014-06-25 Thread Samuel Iglesias Gonsálvez
On Fri, 2014-06-20 at 17:02 +0200, Samuel Iglesias Gonsalvez wrote: Hello, This batch of patches adds tests for testing the layout's qualifier called 'stream' which was introduced in ARB_gpu_shader5 extension. Each patch adds tests in different directories: compiler, linker and execution

Re: [Piglit] [PATCH] cl: Fix out-of-bounds write in get-num-groups

2014-06-25 Thread Tom Stellard
On Wed, Jun 25, 2014 at 12:35:50PM +0200, Lars-Dominik Braun wrote: --- Each work-item writes three values. 4*4*4*3 is 192. Reviewed-by: Tom Stellard thomas.stell...@amd.com I can commit this. -Tom I’m new to piglit and do not have commit access.

[Piglit] [PATCH] util/framework/glut: check if we have a core profile

2014-06-25 Thread Brian Paul
For the GLUT framework, check the context version and whether GL_ARB_compatibility is supported to determine if we should set piglit_is_core_profile. Fixes some issues when running GL 3.1 and later on Windows. --- tests/util/piglit-framework-gl/piglit_glut_framework.c |8 1 file

Re: [Piglit] [PATCH] arb_texture_buffer_object-get: use piglit_get_gl_enum_name() in error msg

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 8:45 AM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH]

Re: [Piglit] [PATCH] util/framework/glut: check if we have a core profile

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 8:45 AM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH]

Re: [Piglit] [PATCH] util/framework/glut: check if we have a core profile

2014-06-25 Thread Brian Paul
Thanks, but I think I'm going to do a bit more in this area. New patch(es) to come, after more testing... -Brian On 06/25/2014 10:28 AM, Charmaine Lee wrote: Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit

[Piglit] [PATCH 1/2] piglit-dispatch: fix get_core_proc_address() for Windows

2014-06-25 Thread Brian Paul
Even for functions such as glGetStringi() which are in OpenGL 3.0, we call get_core_proc_address() with gl_10x_version = 10 (seems to be a larger problem in the dispatch code generation). That means we try GetProcAddress(OPENGL32.DLL) and fail. Now, if GetProcAddress() fails, try

[Piglit] [PATCH 2/2] util/framework/glut: do more core/compat profile checking

2014-06-25 Thread Brian Paul
Check if actually got a core profile. Then, if the tests requires a compat profile, skip the test. --- .../piglit-framework-gl/piglit_glut_framework.c| 22 1 file changed, 22 insertions(+) diff --git a/tests/util/piglit-framework-gl/piglit_glut_framework.c

Re: [Piglit] [PATCH 1/2] piglit-dispatch: fix get_core_proc_address() for Windows

2014-06-25 Thread Charmaine Lee
The series looks good to me. Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 10:50 AM To: piglit@lists.freedesktop.org Subject:

[Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Brian Paul
GL_MAX_UNIFORM_BLOCK_SIZE is in bytes. A component is regarded as being four bytes in size. So to compute the number of components, divide the block size by 4. With this change, nvidia's driver passes the test. Found by Kai Ninomiya of VMware. --- tests/spec/arb_uniform_buffer_object/minmax.c

Re: [Piglit] [PATCH] arb_uniform_buffer_object-minmax: divide block size by 4 to get components

2014-06-25 Thread Charmaine Lee
Reviewed-by: Charmaine Lee charmai...@vmware.com From: Piglit piglit-boun...@lists.freedesktop.org on behalf of Brian Paul bri...@vmware.com Sent: Wednesday, June 25, 2014 12:27 PM To: piglit@lists.freedesktop.org Subject: [Piglit] [PATCH]

[Piglit] [PATCH 1/3] programs/run.py: Fix options recording

2014-06-25 Thread Dylan Baker
This was accidentally removed in a previous commit. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/programs/run.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/framework/programs/run.py b/framework/programs/run.py index bd9bd2e..ab3ce0e 100644 ---

[Piglit] [PATCH 2/3] results. make assert in JSONWriter.close_json() more verbose

2014-06-25 Thread Dylan Baker
Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/results.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/results.py b/framework/results.py index 1a6a652..a715b29 100644 --- a/framework/results.py +++ b/framework/results.py @@ -168,7 +168,9 @@

Re: [Piglit] [PATCH 1/3] programs/run.py: Fix options recording

2014-06-25 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu On Wed, Jun 25, 2014 at 7:05 PM, Dylan Baker baker.dyla...@gmail.com wrote: This was accidentally removed in a previous commit. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/programs/run.py | 2 ++ 1 file changed, 2

[Piglit] [PATCH] fbo-generatemipmap-array: Remove unused variable.

2014-06-25 Thread Vinson Lee
Fix clang unused-const-variable warning. tests/fbo/fbo-generatemipmap-array.c:51:20: warning: unused variable 'red' [-Wunused-const-variable] static const float red[] = {1, 0, 0, 0}; ^ Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/fbo/fbo-generatemipmap-array.c

[Piglit] [PATCH] fbo-incomplete-invalid-texture: Remove unused variable.

2014-06-25 Thread Vinson Lee
Fix clang unused-const-variable warning. fbo-incomplete-invalid-texture.c:40:20: warning: unused variable 'green' [-Wunused-const-variable] static const float green[] = { 0.f, 1.f, 0.f, 1.f }; ^ Signed-off-by: Vinson Lee v...@freedesktop.org ---

[Piglit] [PATCH] Bump python version requirement to 2.7.x

2014-06-25 Thread Dylan Baker
Python 2.6.6 was the final feature release of the 2.6 branch, it was released in August 2010. Python 2.6.9 was the last security release, it was released in October 2013. There is no support from upstream for 2.6, either for bugs or security problems, OSX, linux, windows all have 2.7 available to

[Piglit] [PATCH] blendminmax: Remove unused variables.

2014-06-25 Thread Vinson Lee
Fix clang unused-const-variable variables. blendminmax.c:47:22: warning: unused variable 'Near' [-Wunused-const-variable] static const GLfloat Near = 5.0, Far = 25.0; ^ blendminmax.c:47:34: warning: unused variable 'Far' [-Wunused-const-variable] static const GLfloat Near =

[Piglit] [PATCH] blendsquare: Removed unused variables.

2014-06-25 Thread Vinson Lee
Fix clang unused-const-variable warnings. blendsquare.c:47:22: warning: unused variable 'Near' [-Wunused-const-variable] static const GLfloat Near = 5.0, Far = 25.0; ^ blendsquare.c:47:34: warning: unused variable 'Far' [-Wunused-const-variable] static const GLfloat Near =

[Piglit] [PATCH] stencil-twoside: Remove unused variables.

2014-06-25 Thread Vinson Lee
Fix clang unused-const-variable warnings. stencil-twoside.c:50:22: warning: unused variable 'Near' [-Wunused-const-variable] static const GLfloat Near = 5.0, Far = 25.0; ^ stencil-twoside.c:50:34: warning: unused variable 'Far' [-Wunused-const-variable] static const GLfloat

[Piglit] [PATCH] glsl-fs-color-matrix: Remove unused variable.

2014-06-25 Thread Vinson Lee
Fix clang unused-const-variable warning. glsl-fs-color-matrix.c:84:22: warning: unused variable 'black' [-Wunused-const-variable] static const GLfloat black[4] = { 0.0, 0.0, 0.0, 1.0 }; ^ Signed-off-by: Vinson Lee v...@freedesktop.org ---

[Piglit] [PATCH] cmake: Require Mako = 0.7

2014-06-25 Thread Chad Versace
Piglit began requiring Mako 0.7 as of commit ac1f382 dispatch: Generate piglit-dispatch from Khronos XML. Piglit has required Mako for a long time, and CMake did check for Mako. But CMake didn't check the version. This patch fixes CMake to require Mako = 0.7 and to provide the below hint on

Re: [Piglit] Piglit build fails: NameError: global name 'fake_whitespace' is not defined

2014-06-25 Thread Chad Versace
On Tue, Jun 24, 2014 at 05:44:06PM -0700, Dylan Baker wrote: just saw that. Glad you got it working On Tuesday, June 24, 2014 08:43:49 PM Tom Stellard wrote: chadv showed me how to update mako on IRC, so this is working for me now with version 1.0. He said he would add a check for this to

Re: [Piglit] [PATCH] cmake: Require Mako = 0.7

2014-06-25 Thread Dylan Baker
On Wednesday, June 25, 2014 08:47:24 PM Chad Versace wrote: Piglit began requiring Mako 0.7 as of commit ac1f382 dispatch: Generate piglit-dispatch from Khronos XML. Piglit has required Mako for a long time, and CMake did check for Mako. But CMake didn't check the version. This patch fixes