[Piglit] subtests overwriting one another in results file?

2014-07-02 Thread Ilia Mirkin
Dylan, looks like with your latest json-ification changes: $ bin/arb_viewport_array-bounds -fbo -auto Mesa: User error: GL_INVALID_VALUE in glViewportArrayv: index (0) width or height 0 (-10.30, 0.00) Mesa: User error: GL_INVALID_VALUE in glViewportIndexedf: index (1) width or height 0

[Piglit] [PATCH 1/2] exectest_test.py: Add test for PiglitTest.interpret_result() clobbering

2014-07-02 Thread Dylan Baker
This test demonstrates a bug in which PiglitTest clobbers subtest results. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/tests/exectest_test.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/framework/tests/exectest_test.py

[Piglit] [PATCH 2/2] results.py: Add update_recursive method to TestResult

2014-07-02 Thread Dylan Baker
This method is used during PiglitTest.interpret_result() to update subtest entries safely. I chose this approach since it is robust, reusable, and it felt more natural as a part of TestResult than putting it in PiglitTest.interpret_result() Signed-off-by: Dylan Baker baker.dyla...@gmail.com ---

Re: [Piglit] [PATCH 2/2] results.py: Add update_recursive method to TestResult

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 4:02 AM, Dylan Baker baker.dyla...@gmail.com wrote: This method is used during PiglitTest.interpret_result() to update subtest entries safely. I chose this approach since it is robust, reusable, and it felt more natural as a part of TestResult than putting it in

Re: [Piglit] [PATCH 2/2] results.py: Add update_recursive method to TestResult

2014-07-02 Thread Dylan Baker
Oops, that's what I get for writing and sending a patch at 1AM On Wednesday, July 02, 2014 10:36:53 AM Ilia Mirkin wrote: On Wed, Jul 2, 2014 at 4:02 AM, Dylan Baker baker.dyla...@gmail.com wrote: This method is used during PiglitTest.interpret_result() to update subtest entries safely. I

[Piglit] [Patch v2 2/2] results.py: Add recursive_update method to TestResult

2014-07-02 Thread Dylan Baker
This method is used during PiglitTest.interpret_result() to update subtest entries safely. I chose this approach since it is robust, reusable, and it felt more natural as a part of TestResult than putting it in PiglitTest.interpret_result() v2: - Fix commit message Signed-off-by: Dylan Baker

[Piglit] [Patch v2 1/2] exectest_test.py: Add test for PiglitTest.interpret_result() clobbering

2014-07-02 Thread Dylan Baker
This test demonstrates a bug in which PiglitTest clobbers subtest results. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/tests/exectest_test.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/framework/tests/exectest_test.py

Re: [Piglit] [Patch v2 2/2] results.py: Add recursive_update method to TestResult

2014-07-02 Thread Ilia Mirkin
On Wed, Jul 2, 2014 at 1:17 PM, Dylan Baker baker.dyla...@gmail.com wrote: This method is used during PiglitTest.interpret_result() to update subtest entries safely. I chose this approach since it is robust, reusable, and it felt more natural as a part of TestResult than putting it in

[Piglit] [PATCH] amd_vertex_shader_viewport_index: add render test

2014-07-02 Thread Ilia Mirkin
This is a copy of the render_viewport ARB_viewport_array test. I didn't think that it was worth it to copy the scissor/depth tests, since they basically test the same thing but making sure that scissor/depth are applied correctly. If that works for ARB_viewport_array, it really should work here

Re: [Piglit] [Patch v2 2/2] results.py: Add recursive_update method to TestResult

2014-07-02 Thread Dylan Baker
On Wednesday, July 02, 2014 10:39:57 AM Dylan Baker wrote: On Wednesday, July 02, 2014 01:28:09 PM Ilia Mirkin wrote: On Wed, Jul 2, 2014 at 1:17 PM, Dylan Baker baker.dyla...@gmail.com wrote: This method is used during PiglitTest.interpret_result() to update subtest entries safely. I

[Piglit] [PATCH 3/4] cl: Add tests for cos builtin

2014-07-02 Thread Tom Stellard
--- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index edf93da..d93f09f 100644 ---

[Piglit] [PATCH 2/4] cl: Add tests for atan builtin

2014-07-02 Thread Tom Stellard
--- generated_tests/genclbuiltins.py | 7 +-- generated_tests/generate-cl-math-builtins.py | 11 +++ tests/cl/program/program-tester.c| 1 - 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/generated_tests/genclbuiltins.py

[Piglit] [PATCH 3/4] Move piglit_get_luminance_intensity_bits to GL common code

2014-07-02 Thread Josh Triplett
This doesn't need to remain in the GL-specific utility library. Signed-off-by: Josh Triplett j...@joshtriplett.org --- tests/util/piglit-util-gl-common.c | 102 + tests/util/piglit-util-gl.c| 102 - 2 files changed,