Re: [Piglit] [Beignet] [PATCH] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-25 Thread Tom Stellard
On Thu, Sep 25, 2014 at 09:18:18AM +0800, Zhigang Gong wrote: On Wed, Sep 24, 2014 at 08:03:10AM -0700, Tom Stellard wrote: On Wed, Sep 24, 2014 at 01:13:18AM +, Luo, Xionghu wrote: Hi Tom, According to the opencl-1.2 spec in page 165, the option CL_KERNEL_GLOBAL_WORK_SIZE for

[Piglit] [PATCH 2/2] draw-pixels: update BYTE_TO_FLOAT() macro to match Mesa

2014-09-25 Thread Brian Paul
Use Mesa's UBYTE_TO_FLOAT_TEX() arithmetic. This lets Mesa pass the test. No regression with nvidia's driver either. --- tests/general/draw-pixels.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/general/draw-pixels.c b/tests/general/draw-pixels.c index

[Piglit] [PATCH 1/2] draw-pixels: report format/type for failures

2014-09-25 Thread Brian Paul
--- tests/general/draw-pixels.c | 56 ++- 1 file changed, 40 insertions(+), 16 deletions(-) diff --git a/tests/general/draw-pixels.c b/tests/general/draw-pixels.c index 46bacfa..27b1675 100644 --- a/tests/general/draw-pixels.c +++

Re: [Piglit] Interest in participating in the OPW with X.org

2014-09-25 Thread Brian Paul
On 09/25/2014 02:32 AM, Juliet Fru wrote: Hello Brian, There's definitely work that can be done for Piglit. For example, porting the old Glean tests to piglit's framework. I am currently downloading the code and would build immediately it is complete. I would do some research on

Re: [Piglit] Interest in participating in the OPW with X.org

2014-09-25 Thread Juliet Fru
Hello Brian, Piglit contains a copy of the Glean tests in piglit/tests/glean/. I'd suggest looking at a few of the simpler glean tests (like tpaths.cpp, tstencil2.cpp, toccluqury.cpp and try converting them to piglit's framework. Piglit's framework is pretty simple and you should be able to

Re: [Piglit] Interest in participating in the OPW with X.org

2014-09-25 Thread Emil Velikov
On 25/09/14 15:34, Brian Paul wrote: On 09/25/2014 02:32 AM, Juliet Fru wrote: Hello Brian, There's definitely work that can be done for Piglit. For example, porting the old Glean tests to piglit's framework. I am currently downloading the code and would build immediately it is

[Piglit] [PATCH] Create an initial to-do list

2014-09-25 Thread Brian Paul
I'm sure other people have items to add... --- TODO | 28 1 file changed, 28 insertions(+) create mode 100644 TODO diff --git a/TODO b/TODO new file mode 100644 index 000..fb5c405 --- /dev/null +++ b/TODO @@ -0,0 +1,28 @@ + +Piglit To-Do items + + +Port

Re: [Piglit] Interest in participating in the OPW with X.org

2014-09-25 Thread Brian Paul
On 09/25/2014 08:40 AM, Juliet Fru wrote: Hello Brian, Piglit contains a copy of the Glean tests in piglit/tests/glean/. I'd suggest looking at a few of the simpler glean tests (like tpaths.cpp, tstencil2.cpp, toccluqury.cpp and try converting them to piglit's framework.

Re: [Piglit] Interest in participating in the OPW with X.org

2014-09-25 Thread Juliet Fru
Hi Emil, [1] https://bugs.freedesktop.org/show_bug.cgi?id=65676 Thanks for the link would look into it. Thanks, Juliet ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] Interest in participating in the OPW with X.org

2014-09-25 Thread Juliet Fru
Hello Brian, Glean's use of C++ isn't too complex. If you have questions about it, just ask on this list. Would look into it later, tired for today. will ask questions if I run into some. Please post questions to the mailing list so others can reply too. Will do. Thanks, Juliet

[Piglit] [PATCH] framework/tests: add a test for the timeout mechanism

2014-09-25 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/tests/exectest_test.py | 20 1 file changed, 20 insertions(+) diff --git a/framework/tests/exectest_test.py b/framework/tests/exectest_test.py index 935719d..ebe02a4 100644 --- a/framework/tests/exectest_test.py

Re: [Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-25 Thread Jan Vesely
ping On Tue, 2014-09-16 at 17:49 -0400, Jan Vesely wrote: ping this fixes duplicate subtest names in generated tests On Thu, 2014-09-04 at 17:16 -0400, Jan Vesely wrote: This fixes hidden failures where summary would report the result of the last test with given name. v2: Tag

[Piglit] [PATCH 7/9] cl: Add tanh tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 232f983..531106d 100644

[Piglit] [PATCH 8/9] cl: Add cospi tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 531106d..9f5d75c 100644 ---

[Piglit] [PATCH 6/9] cl: Add sinh tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index ad43ffe..232f983 100644

[Piglit] [PATCH 5/9] cl: Add cosh tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 2d41837..ad43ffe 100644

[Piglit] [PATCH 3/9] cl: Add atanh tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 7d30766..5a1fa02 100644

[Piglit] [PATCH 1/9] cl: Add acosh tests

2014-09-25 Thread Aaron Watry
Also added myself to the file authors list Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py

[Piglit] [PATCH 2/9] cl: Add asinh tests

2014-09-25 Thread Aaron Watry
Also re-organize math imports slightly Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/generated_tests/generate-cl-math-builtins.py

[Piglit] [PATCH 4/9] cl: Add cbrt tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 5a1fa02..2d41837 100644 ---

[Piglit] [PATCH 9/9] cl: Add sinpi tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index 9f5d75c..dfc1d1d 100644 ---

Re: [Piglit] [PATCH 1/2] cl: Add atomic_max tests

2014-09-25 Thread Jan Vesely
On Tue, 2014-09-09 at 17:11 -0500, Aaron Watry wrote: v2: Properly test signed/unsigned values Signed-off-by: Aaron Watry awa...@gmail.com --- .../execute/builtin/atomic/atomic_max-local.cl | 81 ++ 1 file changed, 81 insertions(+) create mode 100644

Re: [Piglit] [PATCH 1/2] cl: Add atomic_max tests

2014-09-25 Thread Aaron Watry
On Thu, Sep 25, 2014 at 3:06 PM, Jan Vesely jan.ves...@rutgers.edu wrote: On Tue, 2014-09-09 at 17:11 -0500, Aaron Watry wrote: v2: Properly test signed/unsigned values Signed-off-by: Aaron Watry awa...@gmail.com --- .../execute/builtin/atomic/atomic_max-local.cl | 81

Re: [Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-25 Thread Tom Stellard
On Thu, Sep 25, 2014 at 03:36:23PM -0400, Jan Vesely wrote: ping Pushed, thanks! -Tom On Tue, 2014-09-16 at 17:49 -0400, Jan Vesely wrote: ping this fixes duplicate subtest names in generated tests On Thu, 2014-09-04 at 17:16 -0400, Jan Vesely wrote: This fixes hidden

[Piglit] [PATCH v2 1/5] arb_uniform_buffer_object: Random test generation infrastructure

2014-09-25 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This is the core of the random test generation infrastructure. This Python script can be used stand-alone to generate fully random tests, or it can be called from other Python code to generate tests in a more directed manner. Examples of both uses are

[Piglit] [PATCH] cl/atomic: Fix duplicate names for threaded int/uint tests

2014-09-25 Thread Aaron Watry
Signed-off-by: Aaron Watry awa...@gmail.com CC: Jan Vesely jan.ves...@rutgers.edu --- tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 4 ++-- tests/cl/program/execute/builtin/atomic/atomic_and-local.cl | 4 ++-- tests/cl/program/execute/builtin/atomic/atomic_cmpxchg-local.cl

Re: [Piglit] [PATCH 0/5] Randomized UBO tests of doom

2014-09-25 Thread Ian Romanick
On 09/24/2014 09:47 AM, Ian Romanick wrote: So, here it is. Finally. The first two patches provide the infrastructure for generating randomized UBO tests. I think these are pretty solid, but there are probably ways to impove the Python, etc. The remaining three patches are examples of

Re: [Piglit] [PATCH] cl/atomic: Fix duplicate names for threaded int/uint tests

2014-09-25 Thread Jan Vesely
Reviewed-by: Jan Vesely jan.ves...@rutgers.edu thanks On Thu, 2014-09-25 at 15:38 -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com CC: Jan Vesely jan.ves...@rutgers.edu --- tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 4 ++--

Re: [Piglit] [PATCH] framework: add a generic timeout mechanism

2014-09-25 Thread Dylan Baker
Hi Thomas, I had a chance to run this (both this version and your original version), and the performance hit is massive on both GL and CL testing. I'm concerned with introducing a mechanism as generic when it made my test runs so long that I gave up running them. We really do want a generic

Re: [Piglit] [PATCH 2/2] draw-pixels: update BYTE_TO_FLOAT() macro to match Mesa

2014-09-25 Thread Anuj Phogat
On Thu, Sep 25, 2014 at 6:52 AM, Brian Paul bri...@vmware.com wrote: Use Mesa's UBYTE_TO_FLOAT_TEX() arithmetic. This lets Mesa pass the I think you mean BYTE_TO_FLOAT_TEX() here. test. No regression with nvidia's driver either. --- tests/general/draw-pixels.c |2 +- 1 file changed, 1

Re: [Piglit] [PATCH 2/2] draw-pixels: update BYTE_TO_FLOAT() macro to match Mesa

2014-09-25 Thread Brian Paul
On 09/25/2014 03:56 PM, Anuj Phogat wrote: On Thu, Sep 25, 2014 at 6:52 AM, Brian Paul bri...@vmware.com wrote: Use Mesa's UBYTE_TO_FLOAT_TEX() arithmetic. This lets Mesa pass the I think you mean BYTE_TO_FLOAT_TEX() here. Yes, thanks. I'll fix that. test. No regression with nvidia's

Re: [Piglit] [PATCH v2 1/5] arb_uniform_buffer_object: Random test generation infrastructure

2014-09-25 Thread Daniel Martin
Hi Ian, I haven't tested the code, but while scroling through I've found at least one mistake (the second comment below): On Thu, Sep 25, 2014 at 01:36:40PM -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com ... +def vector_base_type(type): +Return the type of an

Re: [Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-25 Thread Jan Vesely
On Mon, 2014-09-22 at 11:31 -0700, Tom Stellard wrote: On Fri, Sep 19, 2014 at 07:30:41PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu For the whole series: Reviewed-by: Tom Stellard thomas.stell...@amd.com Do you need me to commit these? these too,

Re: [Piglit] [PATCH v2 1/5] arb_uniform_buffer_object: Random test generation infrastructure

2014-09-25 Thread Dylan Baker
On Friday, September 26, 2014 12:28:09 AM Daniel Martin wrote: Hi Ian, I haven't tested the code, but while scroling through I've found at least one mistake (the second comment below): On Thu, Sep 25, 2014 at 01:36:40PM -0700, Ian Romanick wrote: From: Ian Romanick

Re: [Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-25 Thread Tom Stellard
On Thu, Sep 25, 2014 at 06:50:46PM -0400, Jan Vesely wrote: On Mon, 2014-09-22 at 11:31 -0700, Tom Stellard wrote: On Fri, Sep 19, 2014 at 07:30:41PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu For the whole series: Reviewed-by: Tom Stellard

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-25 Thread Jan Vesely
Didn't notice somebody dropped Tom from the cc list. On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote: On Wed, 2014-09-03 at 20:20 -0700, Dylan Baker wrote: I'd caught this error in a branch as well, but noticed there were no users of this function so it didn't seem pressing to fix it.

[Piglit] [PATCH V2] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-25 Thread xionghu . luo
From: Luo xionghu@intel.com the option CL_KERNEL_GLOBAL_WORK_SIZE for clGetKernelWorkGroupInfo should call built in kernel or custom device according to the spec, this patch calls the built in kernel to query the GLOBAL_WORK_SIZE. v2: use built in kernel to qury the GLOBAL_WORK_SIZE if