Re: [Piglit] [PATCH 3/6] tests/igt.py: simplify setting the root

2015-01-23 Thread Dylan Baker
On Friday, January 23, 2015 15:02:01 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: This uses dict.get() to simplify and streamline the logic. --- tests/igt.py | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff

Re: [Piglit] [PATCH] gen_dispatch.py: PEP 8 fixes

2015-01-23 Thread Dylan Baker
Reviewed-by: Dylan Baker dylanx.c.ba...@intel.com On Thursday, January 22, 2015 21:58:41 Vinson Lee wrote: gen_dispatch.py:81:14: E241 multiple spaces after ':' gen_dispatch.py:81:27: E241 multiple spaces after ',' gen_dispatch.py:145:5: E303 too many blank lines (2) Signed-off-by: Vinson

Re: [Piglit] [PATCH 1/6] test/igt.py: Fix whitepace warnings for pylint

2015-01-23 Thread Dylan Baker
On Friday, January 23, 2015 15:00:51 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: --- tests/igt.py | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index

[Piglit] [Bug 88738] Request commit access to piglit

2015-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88738 --- Comment #4 from Serge Martin edb+freedesk...@sigluy.net --- Sorry, I used the default :o) -- You are receiving this mail because: You are the QA Contact for the bug. ___ Piglit mailing list

Re: [Piglit] [PATCH] deqp: (V5)Add option to run subset of external dEQP-GLES3

2015-01-23 Thread Dylan Baker
This looks good, thanks for working on this and fixing all of my comments. If you don't have commit access let me know and I'll commit this assuming Chad doesn't object. Reviewed-by: Dylan Baker dylanx.c.ba...@intel.com On Friday, January 23, 2015 17:09:21 Wang Shuo wrote: Google have already

Re: [Piglit] [PATCH 4/6] tests/igt.py: fix invalid name errors

2015-01-23 Thread Dylan Baker
On Friday, January 23, 2015 17:50:41 Thomas Wood wrote: On 23 January 2015 at 17:10, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, January 23, 2015 15:02:44 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8,

Re: [Piglit] [PATCH 6/6] igt.py: Use __future__ functions, mainly print_function

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: This makes igt more like the rest of piglit which uses the __future__ version of print, division, and import Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- tests/igt.py | 13 +++-- 1 file changed, 7

Re: [Piglit] [PATCH 6/6] igt.py: Use __future__ functions, mainly print_function

2015-01-23 Thread Dylan Baker
On Friday, January 23, 2015 17:53:29 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: This makes igt more like the rest of piglit which uses the __future__ version of print, division, and import Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com

Re: [Piglit] [PATCH 4/6] tests/igt.py: fix invalid name errors

2015-01-23 Thread Dylan Baker
On Friday, January 23, 2015 15:02:44 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8, make functions all lowercase with underscores, and move some toplevel work into helper functions. This lowers the pylint

Re: [Piglit] [PATCH 4/6] tests/igt.py: fix invalid name errors

2015-01-23 Thread Thomas Wood
On 23 January 2015 at 17:10, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, January 23, 2015 15:02:44 Thomas Wood wrote: On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8, make functions all lowercase with underscores, and move

[Piglit] [Bug 88738] Request commit access to piglit

2015-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88738 Dylan baker.dyla...@gmail.com changed: What|Removed |Added CC||e...@anholt.net ---

[Piglit] [Bug 88738] Request commit access to piglit

2015-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88738 --- Comment #5 from Dylan baker.dyla...@gmail.com --- It's cool, you're a lot more likely to get an account from Eric than me :) -- You are receiving this mail because: You are the QA Contact for the bug.

[Piglit] [PATCH 1/2] opencv: Automatically run tests concurrently when render-nodes are present

2015-01-23 Thread Tom Stellard
--- framework/test/opencv.py | 11 ++- tests/cl.py | 9 - tests/quick_cl.py| 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/framework/test/opencv.py b/framework/test/opencv.py index 2c3d627..2eca948 100644 ---

[Piglit] [PATCH 13/15] arb_direct_state_access: Testing glGetNamedBufferParameteri[64]v.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../getnamedbufferparameter.c | 215 + 3 files changed, 217 insertions(+) create mode 100644

[Piglit] [PATCH 15/15] arb_direct_state_access: Testing glGetNamedBufferSubData.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../getnamedbuffersubdata.c| 112 + 3 files changed, 114 insertions(+) create mode 100644

[Piglit] [PATCH 04/15] arb_direct_state_access: Testing NamedBufferData.

2015-01-23 Thread Laura Ekstrand
--- tests/spec/arb_direct_state_access/namedbufferstorage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_direct_state_access/namedbufferstorage.c b/tests/spec/arb_direct_state_access/namedbufferstorage.c index 2ddfab6..6630467 100644 ---

[Piglit] [PATCH 03/15] arb_sync: Test to demonstrate ClientWaitSync bug.

2015-01-23 Thread Laura Ekstrand
glClientWaitSync(fence, GL_SYNC_FLUSH_COMMANDS_BIT, GL_TIMEOUT_IGNORED) often returns GL_TIMEOUT_EXPIRED, even though GL_TIMEOUT_IGNORED is a huge integer (18446744073709551615 on Intel Sandybridge with Mesa). The third argument to glClientWaitSync should represent the number of nanoseconds the

[Piglit] [PATCH 02/15] arb_direct_state_access: Testing NamedBufferStorage.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../arb_direct_state_access/namedbufferstorage.c | 283 + 3 files changed, 285 insertions(+) create mode 100644

[Piglit] [PATCH 10/15] arb_direct_state_access: Testing MapNamedBuffer.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../mapnamedbuffer-pbo-readpixels.c| 120 + 3 files changed, 122 insertions(+) create mode 100644

[Piglit] [PATCH 05/15] arb_direct_state_access: Testing NamedBufferSubData.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../namedbuffersubdata-vbo-sync.c | 119 + 3 files changed, 121 insertions(+) create mode 100644

[Piglit] [PATCH 12/15] arb_direct_state_access: Testing FlushMappedNamedBufferRange.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../flushmappednamedbufferrange.c | 112 + 3 files changed, 114 insertions(+) create mode 100644

[Piglit] [PATCH 08/15] arb_direct_state_access: Testing glClearNamedBufferSubData.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../clearnamedbuffersubdata-invalid-size.c | 100 + 3 files changed, 102 insertions(+) create mode 100644

[Piglit] [PATCH 07/15] arb_direct_state_access: Testing glClearNamedBufferData.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../clearnamedbufferdata-invalid-internal-format.c | 165 + 3 files changed, 167 insertions(+) create mode 100644

[Piglit] [PATCH 2/2] Add quick_glcl test profile

2015-01-23 Thread Tom Stellard
The combines the gpu and quick_cl test profiles. --- tests/quick_glcl.py | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 tests/quick_glcl.py diff --git a/tests/quick_glcl.py b/tests/quick_glcl.py new file mode 100644 index 000..1ee2733 --- /dev/null +++ b/tests/quick_glcl.py

Re: [Piglit] [PATCH 2/2] Add quick_glcl test profile

2015-01-23 Thread Dylan Baker
I'm against this, you can already pass multiple profiles to piglit to run at the same time: ./piglit run gpu quick_cl output On Friday, January 23, 2015 12:54:59 Tom Stellard wrote: The combines the gpu and quick_cl test profiles. --- tests/quick_glcl.py | 6 ++ 1 file changed, 6

[Piglit] [PATCH 1/2] update documentation to be clear about using multiple profiles

2015-01-23 Thread Dylan Baker
Updates README and the help message to be clear about using multiple test profiles. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- README| 6 +- framework/programs/run.py | 6 -- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/README b/README

[Piglit] [PATCH 2/2] README: update the list of test profiles

2015-01-23 Thread Dylan Baker
Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- README | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/README b/README index 9ba0a97..c5b6330 100644 --- a/README +++ b/README @@ -294,11 +294,13 @@ gpu.py A further reduced set of tests from

[Piglit] [PATCH 11/15] arb_direct_state_access: Testing UnmapNamedBuffer.

2015-01-23 Thread Laura Ekstrand
--- tests/all.py | 1 + .../spec/arb_direct_state_access/CMakeLists.gl.txt | 1 + .../mapnamedbuffer-pbo-readpixels.c| 6 +- .../arb_direct_state_access/unmapnamedbuffer-vbo.c | 128 + 4 files changed, 133

[Piglit] [PATCH 01/15] arb_direct_state_access: Testing glCreateBuffers.

2015-01-23 Thread Laura Ekstrand
--- tests/spec/arb_direct_state_access/getcompressedtextureimage.c | 2 +- tests/spec/arb_direct_state_access/texture-buffer-range.c | 2 +- tests/spec/arb_direct_state_access/texture-buffer.c| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Piglit] [PATCH 2/2] Add quick_glcl test profile

2015-01-23 Thread Tom Stellard
On Fri, Jan 23, 2015 at 11:20:16AM -0800, Dylan Baker wrote: I'm against this, you can already pass multiple profiles to piglit to run at the same time: ./piglit run gpu quick_cl output I do not know that. Thanks for the tip. -Tom On Friday, January 23, 2015 12:54:59 Tom Stellard wrote:

Re: [Piglit] [PATCH 1/2] opencv: Automatically run tests concurrently when render-nodes are present

2015-01-23 Thread Dylan Baker
Oddly patch 2 showed up well before patch 1 did, I have a few comments, but generally this patch seems fine. On Friday, January 23, 2015 12:54:58 Tom Stellard wrote: --- framework/test/opencv.py | 11 ++- tests/cl.py | 9 - tests/quick_cl.py| 4 ++-- 3

Re: [Piglit] [PATCH 1/2] update documentation to be clear about using multiple profiles

2015-01-23 Thread Tom Stellard
On Fri, Jan 23, 2015 at 12:10:09PM -0800, Dylan Baker wrote: Updates README and the help message to be clear about using multiple test profiles. Thanks. Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- README|

Re: [Piglit] Porting Glean Tests to the Piglit Framework

2015-01-23 Thread Juliet Fru
Hello, Thanks very much for the email. Will continue working on them as soon as I'm free. +Ian, Thanks very much for the information, will do more research on this. Thanks, Juliet ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH] Do we really need python 2.7?

2015-01-23 Thread Matěj Cepl
On 2015-01-07, 19:25 GMT, Dylan Baker wrote: We rely on a couple of 2.7 features, one of them is oredered dictionaries, the other is dict comprehensions. We also use a lot of unnamed format strings ( '{}{}'.format(a, b) ). That can be patched around (and collections used

Re: [Piglit] [PATCH 2/2] README: update the list of test profiles

2015-01-23 Thread Emil Velikov
On 23/01/15 20:10, Dylan Baker wrote: +cpu.py + A subset of quick.py that runs all of the tests from quick.py that are + not run by quick.py Something is iffy here. Did you mean subset of quick.py that runs all the tests from quick.py that are not run by gpu.py ? -Emil

Re: [Piglit] [PATCH 1/2] update documentation to be clear about using multiple profiles

2015-01-23 Thread Emil Velikov
On 23/01/15 20:10, Dylan Baker wrote: Updates README and the help message to be clear about using multiple test profiles. Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- README| 6 +- framework/programs/run.py | 6 -- 2 files changed, 9 insertions(+),

[Piglit] [PATCH v2 1/1] cl: add log10 test

2015-01-23 Thread Jan Vesely
v2: Fix tolerance Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index

[Piglit] [PATCH 1/1] cl: Fix tolerance for SP division

2015-01-23 Thread Jan Vesely
The specs say 2.5 ulp, but we only take integer values Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- R600: Fail - Pass tests/cl/program/execute/vector-arithmetic-float4.program_test | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [Piglit] [PATCH] Do we really need python 2.7?

2015-01-23 Thread Matt Turner
On Fri, Jan 23, 2015 at 2:49 PM, Matěj Cepl mc...@cepl.eu wrote: What kind of functionality is backed by Mako? Could it be switched off? (or we can build new Mako 1.0.0 in EPEL-6 http://koji.fedoraproject.org/koji/taskinfo?taskID=8711312). A bunch of tests are generated at build-time using

Re: [Piglit] [PATCH] Do we really need python 2.7?

2015-01-23 Thread Emil Velikov
On 24 January 2015 at 01:53, Matt Turner matts...@gmail.com wrote: On Fri, Jan 23, 2015 at 2:49 PM, Matěj Cepl mc...@cepl.eu wrote: What kind of functionality is backed by Mako? Could it be switched off? (or we can build new Mako 1.0.0 in EPEL-6

[Piglit] [Bug 88738] Request commit access to piglit

2015-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88738 --- Comment #1 from Serge Martin edb+freedesk...@sigluy.net --- Created attachment 112707 -- https://bugs.freedesktop.org/attachment.cgi?id=112707action=edit ssh pub key -- You are receiving this mail because: You are the QA Contact for the

[Piglit] [Bug 88738] Request commit access to piglit

2015-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88738 --- Comment #2 from Serge Martin edb+freedesk...@sigluy.net --- Created attachment 112708 -- https://bugs.freedesktop.org/attachment.cgi?id=112708action=edit pgp pub key -- You are receiving this mail because: You are the QA Contact for the

Re: [Piglit] [PATCH 3/6] tests/igt.py: simplify setting the root

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: This uses dict.get() to simplify and streamline the logic. --- tests/igt.py | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index 55b0f4a..f0064fc

Re: [Piglit] [PATCH 1/6] test/igt.py: Fix whitepace warnings for pylint

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: --- tests/igt.py | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index e65b8a9..4d76636 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -129,22

Re: [Piglit] [PATCH 4/6] tests/igt.py: fix invalid name errors

2015-01-23 Thread Thomas Wood
On 19 January 2015 at 17:38, Dylan Baker baker.dyla...@gmail.com wrote: Make constants all caps, per PEP8, make functions all lowercase with underscores, and move some toplevel work into helper functions. This lowers the pylint warnings to just missing docstrings. --- tests/igt.py | 28