Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-26 Thread Tapani Pälli
Hi; starting with the shortest .. :) I have one addition to the test, after linking try out giving NULL for the name field: glGetProgramResourceName(prog, GL_UNIFORM, pos, 0, length, NULL); With this addition; Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 03/25/2015 06:01 PM,

Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-26 Thread Tapani Pälli
On 03/26/2015 10:58 AM, Martin Peres wrote: On 26/03/15 10:45, Tapani Pälli wrote: Hi; starting with the shortest .. :) I have one addition to the test, after linking try out giving NULL for the name field: glGetProgramResourceName(prog, GL_UNIFORM, pos, 0, length, NULL); This is not

Re: [Piglit] [PATCH 3/4] program_interface_query: add tests for getprogramresourceindex

2015-03-26 Thread Tapani Pälli
On 03/25/2015 06:01 PM, Martin Peres wrote: Tests tricky cases of resource naming along with some error cases of getprogramresourceindex. It also replaces the resource-index test that was incomplete and did not consistently report the same number of subtests depending on errors.

Re: [Piglit] [PATCH 4/4] program_interface_query: add tests for getprogramresourcename

2015-03-26 Thread Martin Peres
On 26/03/15 10:45, Tapani Pälli wrote: Hi; starting with the shortest .. :) I have one addition to the test, after linking try out giving NULL for the name field: glGetProgramResourceName(prog, GL_UNIFORM, pos, 0, length, NULL); This is not really in the spec, hence why I did not add

Re: [Piglit] [PATCH 2/4] program_interface_query: add tests for getprograminterfaceiv

2015-03-26 Thread Tapani Pälli
Also with this test we could have the NULL input test, to trigger bad things I think it needs to have non-empty shaders though, something like: glGetProgramInterfaceiv(prog, GL_PROGRAM_OUTPUT, GL_MAX_NAME_LENGTH, NULL); (some legal query that triggers driver to iterate resources and try to

Re: [Piglit] [PATCH 3/4] program_interface_query: add tests for getprogramresourceindex

2015-03-26 Thread Martin Peres
On 25/03/15 18:01, Martin Peres wrote: Tests tricky cases of resource naming along with some error cases of getprogramresourceindex. It also replaces the resource-index test that was incomplete and did not consistently report the same number of subtests depending on errors. Signed-off-by:

Re: [Piglit] [PATCH 3/4] program_interface_query: add tests for getprogramresourceindex

2015-03-26 Thread Tapani Pälli
On 03/26/2015 12:35 PM, Tapani Pälli wrote: On 03/25/2015 06:01 PM, Martin Peres wrote: Tests tricky cases of resource naming along with some error cases of getprogramresourceindex. It also replaces the resource-index test that was incomplete and did not consistently report the same number

Re: [Piglit] [PATCH 2/4] program_interface_query: add tests for getprograminterfaceiv

2015-03-26 Thread Martin Peres
On 26/03/15 11:01, Tapani Pälli wrote: Also with this test we could have the NULL input test, to trigger bad things I think it needs to have non-empty shaders though, something like: glGetProgramInterfaceiv(prog, GL_PROGRAM_OUTPUT, GL_MAX_NAME_LENGTH, NULL); (some legal query that triggers

Re: [Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-03-26 Thread Ilia Mirkin
Can we just make shader_runner do a clear automatically? This has happened to me a number of times. On Thu, Mar 26, 2015 at 9:58 PM, Dave Airlie airl...@gmail.com wrote: From: Dave Airlie airl...@redhat.com Otherwise there is a chance you'll get the contents from the last test which are

Re: [Piglit] [PATCH 2/2] igt.py: don't check the environment when in dry-run mode

2015-03-26 Thread Dylan Baker
for the series: Reviewed-by: Dylan Baker baker.dyla...@gmail.com On Thu, Mar 26, 2015 at 03:43:17PM +, Thomas Wood wrote: Don't exit during the post run hook if the environment check fails and dry-run mode is enabled. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py |

[Piglit] [PATCH] gl-2.0: port const vertex attrib webgl test to piglit

2015-03-26 Thread Ilia Mirkin
This is a rip off of: https://www.khronos.org/registry/webgl/conformance-suites/1.0.2/conformance/attribs/gl-vertex-attrib-render.html Which presently fails with gallium drivers. The logic is identical, just ported to GL and piglit infra. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu ---

Re: [Piglit] [PATCH] gl-2.0: port const vertex attrib webgl test to piglit

2015-03-26 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Mar 26, 2015 at 6:10 PM, Ilia Mirkin imir...@alum.mit.edu wrote: This is a rip off of: https://www.khronos.org/registry/webgl/conformance-suites/1.0.2/conformance/attribs/gl-vertex-attrib-render.html Which presently fails with

Re: [Piglit] [PATCH 1/3] cl: add acospi test

2015-03-26 Thread Tom Stellard
On Wed, Mar 25, 2015 at 01:33:49PM -0400, Jan Vesely wrote: copied from acos. tested on clover and intel ocl Signed-off-by: Jan Vesely jan.ves...@rutgers.edu For the series: Reviewed-by: Tom Stellard thomas.stell...@amd.com --- generated_tests/gen_cl_math_builtins.py | 10 ++ 1

Re: [Piglit] [PATCH 1/4] glsl-1.20: Use [vertex shader passthrough] in notEqual tests

2015-03-26 Thread Anuj Phogat
On Mon, Mar 23, 2015 at 12:02 PM, Ian Romanick i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/shaders/glsl-const-builtin-notEqual-bool.shader_test | 6 +-

[Piglit] [PATCH] generator: clear before rendering with the builtin tests

2015-03-26 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com Otherwise there is a chance you'll get the contents from the last test which are green, and if this test fails to renderer you'll pass. Signed-off-by: Dave Airlie airl...@redhat.com --- generated_tests/gen_builtin_uniform_tests.py | 2 ++

Re: [Piglit] [PATCH 1/4] program_interface_query: add tests for querying the resources

2015-03-26 Thread Martin Peres
On 25/03/15 18:01, Martin Peres wrote: This tests primarily glGetProgramInterfaceiv in various (potentially tricky) program pipelines. All the calls are supposed to succeed as this test is purely functional. This test requires a OpenGL 3.2 core context but also has optional subtests that depend

[Piglit] [PATCH 2/2] igt.py: don't check the environment when in dry-run mode

2015-03-26 Thread Thomas Wood
Don't exit during the post run hook if the environment check fails and dry-run mode is enabled. Signed-off-by: Thomas Wood thomas.w...@intel.com --- tests/igt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/igt.py b/tests/igt.py index 8c7963b..8ffac8d 100644 ---

[Piglit] [PATCH 1/2] profile.py: pass options to the pre and post run hooks

2015-03-26 Thread Thomas Wood
Signed-off-by: Thomas Wood thomas.w...@intel.com --- framework/profile.py | 12 tests/igt.py | 2 +- tests/xts.py | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 603e872..1384bbd 100644 ---