Re: [Piglit] [PATCH] arb_texture_multisample: add error check for samples == 0

2015-08-17 Thread Dylan Baker
Thanks Timothy. For future reference (Since I think you're testing on i965), if you notice that a test fails on i965 when committed if you could add that to the commit message that helps our QA efforts tremendously. Obviously if you're not testing against i915 or i965, or the failure doesn't

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: add readonly and writeonly tests

2015-08-17 Thread Tapani Pälli
On 08/15/2015 03:47 AM, Timothy Arceri wrote: On Sat, 2015-08-15 at 10:40 +1000, Timothy Arceri wrote: On Thu, 2015-08-13 at 11:41 +0300, Tapani Pälli wrote: These test usage of readonly and writeonly memory qualifiers for ssbo block members. Looks ok to me. Reviewed-by: Timothy Arceri

Re: [Piglit] [PATCH] arb_texture_multisample: add error check for samples == 0

2015-08-17 Thread Tapani Pälli
Please add comment to commit message that this currently fails with Mesa (otherwise QA may file a bug about it). Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 08/17/2015 02:05 PM, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass Cc: Tapani Pälli

Re: [Piglit] [PATCH] arb_texture_multisample: add error check for samples == 0

2015-08-17 Thread Timothy Arceri
On Mon, 2015-08-17 at 14:14 +0300, Tapani Pälli wrote: Please add comment to commit message that this currently fails with Mesa (otherwise QA may file a bug about it). Thanks. In that case I'll just hold onto it until the mesa patch lands. Reviewed-by: Tapani Pälli tapani.pa...@intel.com

Re: [Piglit] [PATCH] arb_shader_storage_buffer_object: add memory qualifers test

2015-08-17 Thread Timothy Arceri
On Mon, 2015-08-17 at 08:06 +0300, Tapani Pälli wrote: On 08/15/2015 03:43 AM, Timothy Arceri wrote: On Thu, 2015-08-13 at 10:57 +0300, Tapani Pälli wrote: Test checks that parser is able to deal with memory qualifiers given to shader storage block. Signed-off-by: Tapani Pälli

[Piglit] [PATCH] arb_texture_multisample: add error check for samples == 0

2015-08-17 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass Cc: Tapani Pälli tapani.pa...@intel.com --- tests/spec/arb_texture_multisample/errors.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/spec/arb_texture_multisample/errors.c

Re: [Piglit] [PATCH] cl: fix invalid platform test in create-context

2015-08-17 Thread Tom Stellard
On Fri, Aug 14, 2015 at 09:05:48PM +0200, Serge Martin (EdB) wrote: OpenCL objects are just pointers in the end, using random pointer value is likely to make an application crash. Also, all others tests use NULL as an invalid object. Reviewed-by: Tom Stellard thomas.stell...@amd.com See

[Piglit] [PATCH] cl-api-get-kernel-work-group-info: Fix memory leak.

2015-08-17 Thread Vinson Lee
Fix resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/cl/api/get-kernel-work-group-info.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cl/api/get-kernel-work-group-info.c b/tests/cl/api/get-kernel-work-group-info.c index

Re: [Piglit] [PATCH] gl-3.2: fix layered-rendering test

2015-08-17 Thread Tapani Pälli
Maybe also mention in commit message that we are updating test here according to how OpenGL =4.2 defines things. I've checked that 4.2 spec looks to be the first to mention: if samples is zero, an INVALID_VALUE error is generated. I see that the format change is done because

[Piglit] [PATCH] gl-3.2: fix layered-rendering test

2015-08-17 Thread Timothy Arceri
Samples must be greater than 0 and color formats must match. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91670 --- tests/spec/gl-3.2/layered-rendering/framebuffertexture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [PATCH] cmake: Enable __USE_MINGW_ANSI_STDIO for MinGW builds.

2015-08-17 Thread Vinson Lee
MSVC is currently already building getprogramresourceiv.c without any format-related warnings. Also, this proposed patch would only apply to the MinGW build and have no effect the MSVC build. On Mon, Jul 20, 2015 at 11:51 PM, Jose Fonseca jfons...@vmware.com wrote: Interesting, I didn't know

[Piglit] [PATCH] ext_image_dma_buf: Fix memory leak.

2015-08-17 Thread Vinson Lee
Fix resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/spec/ext_image_dma_buf_import/transcode-nv12-as-r8-gr88.c

Re: [Piglit] [PATCH] winsys-framework Default to showing window

2015-08-17 Thread James Jones
For those who don't want to click-through, I'll just paste the very brief portion of the spec on Pixel Ownership that Alex linked to here: [1] The first test is to determine if the pixel at location in the framebuffer is currently owned by the GL (more precisely, by this GL context). If it is