[Piglit] [PATCH 4/4] arb_sample_shading: don't use gl_FragColor/Data in fragment shaders

2017-11-10 Thread Brian Paul
NVIDIA's driver fails to compile the fragment shaders with "Failed to compile fragment shader: 0(4) : error C7533: global variable gl_FragData is deprecated after version 120". Use 'out fragdata' or 'out fragcolor' instead. Tested with Mesa too. --- .../execution/ignore-centroid-qualifier.cpp

[Piglit] [PATCH 2/4] util: const-qualify data parameter to piglit_multisample_texture()

2017-11-10 Thread Brian Paul
--- tests/util/piglit-util-gl.c | 2 +- tests/util/piglit-util-gl.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 041427d..43b38e5 100644 --- a/tests/util/piglit-util-gl.c +++ b/tests/util/piglit-util-gl.c @@

[Piglit] [PATCH 3/4] arb_indirect_parameters: add cast to silence compiler warnings

2017-11-10 Thread Brian Paul
--- tests/spec/arb_indirect_parameters/tf-count-arrays.c | 2 +- tests/spec/arb_indirect_parameters/tf-count-elements.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_indirect_parameters/tf-count-arrays.c

[Piglit] [PATCH 1/4] util: fix piglit_multisample_texture() parameter type

2017-11-10 Thread Brian Paul
Texture IDs are GLuint, not GLenum. --- tests/util/piglit-util-gl.c | 3 ++- tests/util/piglit-util-gl.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index d8b8f85..041427d 100644 --- a/tests/util/piglit-util-gl.c

Re: [Piglit] [PATCH] framework: specify GL_NEAREST filter for FBO textures

2017-11-10 Thread Eric Anholt
Brian Paul writes: > By setting the min/mag filters, we give a hint to the OpenGL driver > that we probaby don't want mipmapped textures. This results in the > Mesa state tracker allocating single-level textures here instead of > full mipmaps. Reviewed-by: Eric Anholt

Re: [Piglit] [PATCH] gl-1.0-logicop: allow testing single mode on the command line

2017-11-10 Thread Charmaine Lee
>From: Brian Paul >Sent: Thursday, November 9, 2017 12:52 PM >To: piglit@lists.freedesktop.org >Cc: Charmaine Lee; Brian Paul >Subject: [PATCH] gl-1.0-logicop: allow testing single mode on the command line >And require GL 1.1 since that's when color logicops were introduced.

Re: [Piglit] [PATCH] framework: specify GL_NEAREST filter for FBO textures

2017-11-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, November 9, 2017 12:52:42 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] framework: specify GL_NEAREST filter for

Re: [Piglit] [PATCH] gl-1.0-logicop: allow testing single mode on the command line

2017-11-10 Thread Brian Paul
On 11/10/2017 12:16 PM, Charmaine Lee wrote: From: Brian Paul Sent: Thursday, November 9, 2017 12:52 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] gl-1.0-logicop: allow testing single mode on the command line And require GL 1.1 since

Re: [Piglit] [PATCH] framework: decrement argc in delete_arg()

2017-11-10 Thread Charmaine Lee
Reviewed-by: Charmaine Lee From: Brian Paul Sent: Thursday, November 9, 2017 8:18:31 PM To: piglit@lists.freedesktop.org Cc: Charmaine Lee; Brian Paul Subject: [PATCH] framework: decrement argc in delete_arg()

[Piglit] [PATCH 2/2] shader_draw_parameters: Also test using an indirect draw

2017-11-10 Thread Neil Roberts
The test can now take an extra argument ‘indirect’ which will cause it to emit the draw calls via an indirect buffer. This is useful to test at least on i965 because emitting the gl_BaseVertex takes a different path in that case. --- tests/all.py | 10 +-

[Piglit] [PATCH 1/2] shader_draw_parameters: Also test using glDrawArrays with first > 0

2017-11-10 Thread Neil Roberts
The ‘first’ parameter should not affect the value of gl_BaseVertex put it should be added to gl_VertexID. This patch adds an extra rectangle to the drawn area to test a non-zero ‘first’ parameter. This is worth testing because Mesa is currently getting this wrong. ---

Re: [Piglit] [PATCH] all.py: filter directories traversed to find shader tests

2017-11-10 Thread Dylan Baker
Thanks! Reviewed-by: Dylan Baker Quoting Brian Paul (2017-11-09 20:18:10) > The script searches all files under tests/ and generated_tests/ for > files ending in ".shader_test". For each match, a ShaderTest() object > is created and added to the test list. > > For GL