Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Dylan Baker writes: > Quoting Marek Olšák (2018-04-10 14:22:10) >> On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker wrote: >> >> Quoting Eric Anholt (2018-04-09 17:10:35) >> > Marek Olšák writes: >> > >> > > Is this use

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Quoting Marek Olšák (2018-04-10 14:22:10) > On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker wrote: > > Quoting Eric Anholt (2018-04-09 17:10:35) > > Marek Olšák writes: > > > > > Is this use case affected? > > > > > > piglit run

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker wrote: > Quoting Eric Anholt (2018-04-09 17:10:35) > > Marek Olšák writes: > > > > > Is this use case affected? > > > > > > piglit run --deqp-mustpass-list --process-isolation 0 -p gbm -c quick > > > cts_gl45

Re: [Piglit] [PATCH 3/3] arb_bindless_texture: rename vertex uniform test and add vertex attrib test

Same comment as the previous one. Images need to be tested. On 04/08/2018 10:56 PM, Karol Herbst wrote: Signed-off-by: Karol Herbst --- .../sampler-vertex-attrib-input-output.shader_test | 41 ++ ...ampler-vertex-uniform-input-output.shader_test} | 0

Re: [Piglit] [PATCH 2/3] arb_bindless_texture: add some uvec2 arithmetic test

Can you please write a similar test with bindless images? We usually have both tests. Reviewed-by: Samuel Pitoiset On 04/08/2018 10:56 PM, Karol Herbst wrote: Signed-off-by: Karol Herbst --- .../basic-arithmetic-uvec2-texture2D.shader_test

Re: [Piglit] [PATCH 1/3] shader_runner: add vertex attrib command for setting bindless texture handles

On 04/08/2018 10:56 PM, Karol Herbst wrote: Signed-off-by: Karol Herbst --- tests/shaders/shader_runner.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index

Re: [Piglit] [PATCH] arb_bindless_texture: add test where we pass a handle through a function

Can you please reference the spec as much as possible? See other ARB_bindless_texture if you need an example. More comments below. On 04/10/2018 12:32 PM, Karol Herbst wrote: currently fails in mesa with: ir_dereference_variable @ 0x1446830 specifies undeclared variable `wrongHandle' @

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Quoting Eric Anholt (2018-04-09 17:10:35) > Marek Olšák writes: > > > Is this use case affected? > > > > piglit run --deqp-mustpass-list --process-isolation 0 -p gbm -c quick > > cts_gl45 deqp_gles2 deqp_gles3 deqp_gles31 > > > > Yes, that is just 1 command to run all those

Re: [Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map tests to complete the cube map

On Tue, 2018-04-10 at 15:56 +, Anthony Pesch wrote: > Thanks for taking the time to review. > > I forgot to mention this in my original message, but this is my first patch > series so I don't have commit access. What should I do to get these pushed? > I can push on your behalf. Do you

Re: [Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map tests to complete the cube map

Thanks for taking the time to review. I forgot to mention this in my original message, but this is my first patch series so I don't have commit access. What should I do to get these pushed? - Anthony From: Juan A. Suarez Romero

[Piglit] [PATCH] arb_bindless_texture: add test for conversion of bounded sampler2D to uvec2

conversion of bounded sampler2D to uvec2 is legal with ARB_bindless_texture. Currently Mesa fails with an assert: ../src/compiler/glsl/opt_function_inlining.cpp:248: void ir_call::generate_inline(ir_instruction*): Assertion `deref' failed. --- ...rithmetic-bounded-sampler-texture2D.shader_test |

[Piglit] [PATCH] arb_bindless_texture: add test where we pass a handle through a function

currently fails in mesa with: ir_dereference_variable @ 0x1446830 specifies undeclared variable `wrongHandle' @ 0xffd1b0 Signed-off-by: Karol Herbst --- ...rithmetic-func-call-uvec2-texture2D.shader_test | 37 ++ 1 file changed, 37 insertions(+) create