Re: [Piglit] [PATCH] khr_debug: fix invalid enum usage on gles3

2018-11-08 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 11/8/18 12:09 PM, Erik Faye-Lund wrote: GL_SAMPLES_PASSED isn't allowed on gles3, so doing a quiery with it isn't going to work. But GL_ANY_SAMPLES_PASSED is allowed, so so let's use that one instead on gles. Signed-off-by: Erik Faye-Lund --- This bug came up

Re: [Piglit] [PATCH] python: add explicit utf-8 encoding

2018-11-08 Thread Dylan Baker
yeah, python's pretty liberal in what it accepts. Quoting Eric Engestrom (2018-11-08 11:05:33) > I went with `# coding=utf-8` as it was the most common format in the > existing code: > 24 # coding=utf-8 > 21 ## coding=utf-8 > 19 # encoding=utf-8 > 9 ## encoding=utf-8 >

[Piglit] [PATCH] EGL_EXT_image_dma_buf_import: add AYUV format support

2018-11-08 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- .../ext_image_dma_buf_import/sample_yuv.c | 33 ++- .../piglit-framework-gl/piglit_drm_dma_buf.c | 1 + 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/tests/spec/ext_image_dma_buf_import/sample_yuv.c

Re: [Piglit] [PATCH] framework: fix python2

2018-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2018-11-08 09:37:22) > On Thursday, 2018-11-08 17:34:33 +, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-11-08 09:23:51) > > > The non-ascii char broke the python2 CI: > > > https://travis-ci.org/mesa3d/piglit/jobs/452170869 > > > > > > Fixes:

Re: [Piglit] [PATCH] framework: fix python2

2018-11-08 Thread Dylan Baker
Quoting Eric Engestrom (2018-11-08 09:23:51) > The non-ascii char broke the python2 CI: > https://travis-ci.org/mesa3d/piglit/jobs/452170869 > > Fixes: 221d924689e3bb2796ce "framework: Add a vulkan tests profile" > Cc: Neil Roberts > Cc: Samuel Iglesias Gonsálvez > Cc: Dylan Baker >

Re: [Piglit] [PATCH 0/4] Support serialization of VkRunner tests

2018-11-08 Thread Dylan Baker
Quoting Neil Roberts (2018-11-07 16:52:00) > As requested by Dylan in the review for the patch series to add > VkRunner as an external dependency¹, this series adds the missing > serialization support. > > 1. https://lists.freedesktop.org/archives/piglit/2018-November/025336.html > > Neil

[Piglit] [Bug 108537] The fs-frexp-dvec4-only-exponent.shader_test test fails

2018-11-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108537 asimiklit changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Piglit] [PATCH] vulkan: Add tests for block layout location calculations

2018-11-08 Thread Alejandro Piñeiro
On 08/11/18 13:24, Neil Roberts wrote: > All but one of these are currently broken on anv. > > See: https://patchwork.freedesktop.org/series/40797/ FWIW, the first patch of that series is outdated, due all the changes on master since then. A updated version was included on the ubo/ssbo support

[Piglit] [PATCH] vulkan/shader_draw_parameters: Add a test for gl_BaseVertex

2018-11-08 Thread Neil Roberts
gl_BaseVertex has slightly different semantics under Vulkan and GL so this is worth testing. --- .../base-vertex.vk_shader_test| 66 +++ 1 file changed, 66 insertions(+) create mode 100644 tests/vulkan/shader_draw_parameters/base-vertex.vk_shader_test diff --git

[Piglit] [PATCH] vulkan: Add tests for block layout location calculations

2018-11-08 Thread Neil Roberts
All but one of these are currently broken on anv. See: https://patchwork.freedesktop.org/series/40797/ --- .../block-layout-location.vk_shader_test | 117 + ...lock-member-layout-location.vk_shader_test | 68 ++ ...block-mixed-layout-location.vk_shader_test | 120

[Piglit] [PATCH] vulkan: Add a test for the OpFUnord* comparisons

2018-11-08 Thread Neil Roberts
These are unique to SPIR-V so they are interesting to test. --- .../unordered-comparison.vk_shader_test | 780 ++ 1 file changed, 780 insertions(+) create mode 100644 tests/vulkan/shaders/unordered-comparison.vk_shader_test diff --git

[Piglit] [PATCH] vulkan: Add tests for interpolateAt*

2018-11-08 Thread Neil Roberts
For a while there was a bug in anv which meant that the interpolate functions wouldn’t work if the thing being interpolated contained a vertex component selector. Adding these tests will help make sure we don’t regress that. See: https://patchwork.freedesktop.org/patch/237095/ ---

Re: [Piglit] [PATCH] vulkan: test cases for large local arrays

2018-11-08 Thread Neil Roberts
Looks good to me  Reviewed-by: Neil Roberts - Neil Alejandro Piñeiro writes: > Equivalent to the GLSL tests added with the series "Test cases for > large GLSL local arrays". Quoting from the cover-letter of that > series: > >"Drivers typically need special handling for local array

[Piglit] [PATCH] vulkan: test cases for large local arrays

2018-11-08 Thread Alejandro Piñeiro
Equivalent to the GLSL tests added with the series "Test cases for large GLSL local arrays". Quoting from the cover-letter of that series: "Drivers typically need special handling for local array storage when arrays exceed a certain size, this adds a few test cases for exercising some

[Piglit] [PATCH] khr_debug: fix invalid enum usage on gles3

2018-11-08 Thread Erik Faye-Lund
GL_SAMPLES_PASSED isn't allowed on gles3, so doing a quiery with it isn't going to work. But GL_ANY_SAMPLES_PASSED is allowed, so so let's use that one instead on gles. Signed-off-by: Erik Faye-Lund --- This bug came up while testing this mesa patch-series: