To test the blit with FRAMEBUFFER_SRGB disabled, if the option
'disabled' was passed to the command line, was not being done.
---
tests/spec/arb_framebuffer_srgb/blit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_framebuffer_srgb/blit.c
The new tests look good to me. Thanks.
Reviewed-by: Antia Puentes <apuen...@igalia.com>
On 24/02/17 16:05, Andres Gomez wrote:
This adds tests to check that no link error occurs when two
differently named but equally instanced interface blocks differ in
some way.
From page 35 (p
Reviewed-by: Antia Puentes <apuen...@igalia.com>
On 30/10/17 12:19, Alejandro Piñeiro wrote:
On those cases, the resource is not supported, so we should expect the
unsupported outcome.
---
In the end it was easier to fix this test. Sorry for the noise. I
thought that fixing it would nee
On 06/05/18 11:42, Alejandro Piñeiro wrote:
ARB_es3_compatibility add several compressed (and specific)
Use the official name of the extension: ARB_ES3_compatibility. Same for
the subject.
internalformats. Those become part of 4.3.
We try to be smart and only try them if the extension is
ondition (is_specific_compressed)
and put the remaining code inside an "if (is_specific_compressed)" block.
Anyway, if you prefer to leave it as it is and avoid another level of
nesting, that is also fine by me:
Reviewed-by: Antia Puentes <apuen...@igalia.com>
glGe
Reviewed-by: Antia Puentes <apuen...@igalia.com>
On 06/05/18 11:42, Alejandro Piñeiro wrote:
Values based on mesa format_info.h values.
---
tests/util/piglit-util-gl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-uti
Forgot to add the:
Reviewed-by: Antia Puentes <apuen...@igalia.com>
On 08/05/18 14:43, Antia Puentes wrote:
On 06/05/18 11:42, Alejandro Piñeiro wrote:
ARB_es3_compatibility add several compressed (and specific)
Use the official name of the extension: ARB_ES3_compatibility
This series is:
Reviewed-by: Antia Puentes <apuen...@igalia.com>
It would be good to know if these patches plus the one you have just
sent to Mesa:
"formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE"
fix the issues Marek was having with these test
Reviewed-by: Antia Puentes <apuen...@igalia.com>
On 10/11/17 19:05, Neil Roberts wrote:
The ‘first’ parameter should not affect the value of gl_BaseVertex put
it should be added to gl_VertexID. This patch adds an extra rectangle
to the drawn area to test a non-zero ‘first’ par
Reviewed-by: Antia Puentes <apuen...@igalia.com>
On 10/11/17 19:05, Neil Roberts wrote:
The test can now take an extra argument ‘indirect’ which will cause
it to emit the draw calls via an indirect buffer. This is useful to
test at least on i965 because emitting the gl_BaseVertex
Command syntax is:
probe atomic counter buffer
---
tests/shaders/shader_runner.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 700b11327..c7243571d 100644
---
SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
as non color-renderable in OpenGL 4.6, however if the
EXT_texture_shared_exponent extension is exposed it must be considered
as such. The later was discussed
and query2 (samples-pnames.c).
On 20/02/18 17:14, Alejandro Piñeiro wrote:
On 20/02/18 14:54, Antia Puentes wrote:
SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
as non color-renderable in
On 20/02/18 17:14, Alejandro Piñeiro wrote:
On 20/02/18 14:54, Antia Puentes wrote:
SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
as non color-renderable in OpenGL 4.6, however
On 21/02/18 08:08, Alejandro Piñeiro wrote:
On 20/02/18 17:28, Antia Puentes wrote:
On 20/02/18 17:18, Alejandro Piñeiro wrote:
I also noted that the commit message says "internalformat_query(2)". Not
sure why it uses parenthesis, shouldn't be just "internalformat_query2
SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
as non color-renderable in OpenGL 4.6, however if the
EXT_texture_shared_exponent extension is exposed it must be considered
as such. The later was discussed
Hi Alejandro,
On 20/07/18 17:16, Alejandro Piñeiro wrote:
+
+bool
+piglit_load_source_from_shader_test(const char *filename,
+ GLenum shader_type,
+ bool spirv,
+ char **output_source,
+
---
.../arb_enhanced_layouts/transform-feedback-layout-query-api.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/tests/spec/arb_enhanced_layouts/transform-feedback-layout-query-api.c
b/tests/spec/arb_enhanced_layouts/transform-feedback-layout-query-api.c
index
From: Alejandro Piñeiro
GLSL codepath uses piglit_build_simple_program_multiple_shaders, that
already calls glLinkProgram.
Minor thing, but makes debug the test more easy.
---
.../transform-feedback-layout-qualifiers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Alejandro Piñeiro (2):
arb_enhanced_layouts: use consistent test names
arb_enhanced_layouts: don't call glLinkProgram twice
Antia Puentes (1):
arb_enhanced_layouts: Fix error in subtest result reporting
tests/opengl.py| 2 +-
.../transform
From: Alejandro Piñeiro
Before this commit a piglit run like this:
./piglit run tests/all.py -t arb_enhanced_layouts-transform-feedback
../piglit_results/foo
Would include the layout-qualifiers tests, but not the layout-query
one.
---
tests/opengl.py | 2 +-
1 file changed, 1 insertion(+),
21 matches
Mail list logo
