Re: [Piglit] [PATCH 13/14] dispatch: Use dlsym to lookup core symbols for EGL

2015-04-28 Thread Marek Olšák
Hi Chad, The patch breaks GetProcAddress for libGL, because libGL doesn't export a lot of GL functions and glXGetProcAddress is the only way to get them. Any idea for a fix? Marek On Fri, Apr 24, 2015 at 9:36 PM, Chad Versace chad.vers...@intel.com wrote: On Mon 13 Apr 2015, Marek Olšák wrote

[Piglit] [PATCH 1/2] EGL_KHR_wait_sync: test that eglWaitSyncKHR exists and its error case

2015-04-26 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com I probably can't test more at this point, because it's a no-op in Mesa just like glWaitSync. --- tests/all.py | 6 +++ .../spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 59 -- 2 files changed, 62

Re: [Piglit] [PATCH 14/14] khr_debug/debug-push-pop-group: fix test

2015-04-25 Thread Marek Olšák
If the spec and the example in the spec don't agree, it's a spec bug, isn't it? Marek On Sat, Apr 25, 2015 at 6:59 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: On Mon, 2015-04-13 at 20:28 +0200, Marek Olšák wrote: From: Daniel Kurtz djku...@chromium.org AFAICT from [0], only PopDebugGroup

Re: [Piglit] [PATCH 00/13] Tests for indirect addressing of inputs and outputs

2015-04-22 Thread Marek Olšák
Sorry I forgot about your email. You can find these and other patches in the tessellation branch here: http://cgit.freedesktop.org/~mareko/piglit/ Marek On Tue, Apr 7, 2015 at 3:53 AM, Ian Romanick i...@freedesktop.org wrote: On 04/06/2015 04:39 PM, Marek Olšák wrote: Most of the tessellation

[Piglit] [PATCH 11/14] ext_unpack_subimage: fix for GLES 3.0

2015-04-13 Thread Marek Olšák
-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/spec/ext_unpack_subimage/ext_unpack_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/spec/ext_unpack_subimage/ext_unpack_subimage.c b/tests/spec/ext_unpack_subimage

[Piglit] [PATCH 07/14] egl_khr_fence_sync: add missing piglit_loge parameter

2015-04-13 Thread Marek Olšák
From: Daniel Kurtz djku...@chromium.org Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/egl/spec/egl_khr_fence_sync

[Piglit] [PATCH 02/14] piglit-util-egl: check if EGL_EXT_client_extensions is supported

2015-04-13 Thread Marek Olšák
that the requested client extension is also not supported. This keeps piglit_is_extension_in_string() from crashing when it tries to find a needle in a NULL haystack. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/util/piglit-util-egl.c | 10

[Piglit] [PATCH 06/14] egl_khr_fence_sync: fix eglCreateSyncKHR() parameter

2015-04-13 Thread Marek Olšák
Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c b/tests/egl/spec

[Piglit] [PATCH 00/14] Fixes for EGL and EGL tests

2015-04-13 Thread Marek Olšák
dispatch can ACK them. If not, I will drop them. Please review. Marek Olšák (1): piglit-util-egl: fix a typo in piglit_egl_get_default_display Daniel Kurtz (13): piglit-util-egl: check if EGL_EXT_client_extensions is supported egl_khr_fence_sync: fix eglGetSyncAttribKHR

[Piglit] [PATCH 03/14] egl_khr_fence_sync: fix eglGetSyncAttribKHR(EGL_SYNC_TYPE_KHR) test

2015-04-13 Thread Marek Olšák
From: Daniel Kurtz djku...@chromium.org eglGetSyncAttribKHR() returns EGL_TRUE on success, thus ok will be true on success. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 2 +- 1 file

[Piglit] [PATCH 08/14] egl_khr_fence_sync: allow skipping display_bound_in_other_thread subtest

2015-04-13 Thread Marek Olšák
PASS. For this test, we really want to return SKIP if either thread returns SKIP. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 12 ++-- 1 file changed, 10 insertions(+), 2

[Piglit] [PATCH 04/14] egl_khr_fence_sync: remove initial expected STATUS check

2015-04-13 Thread Marek Olšák
/egl/extensions/KHR/EGL_KHR_fence_sync.txt Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/tests/egl/spec/egl_khr_fence_sync

[Piglit] [PATCH 10/14] egl_khr_create_context: use ES1 dispatch

2015-04-13 Thread Marek Olšák
From: Daniel Kurtz djku...@chromium.org Using ES1 dispatch works now, so let's use it for gles tests. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- tests/egl/spec/egl_khr_create_context/default-major-version-gles.c | 3 +-- tests/egl/spec

[Piglit] [PATCH 09/14] egl_khr_fence_sync: remove invalid_flag test

2015-04-13 Thread Marek Olšák
-by: Marek Olšák marek.ol...@amd.com --- .../spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 51 -- 1 file changed, 51 deletions(-) diff --git a/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c b/tests/egl/spec/egl_khr_fence_sync/egl_khr_fence_sync.c index e6447bc..e7b4b31

[Piglit] [PATCH 01/14] piglit-util-egl: fix a typo in piglit_egl_get_default_display

2015-04-13 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/util/piglit-util-egl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-util-egl.c b/tests/util/piglit-util-egl.c index 8d48f30..1754602 100644 --- a/tests/util/piglit-util-egl.c +++ b/tests/util/piglit-util

[Piglit] [PATCH 05/14] egl_khr_fence_sync: Make EGL_NO_SYNC_KHR check explicit

2015-04-13 Thread Marek Olšák
From: Daniel Kurtz djku...@chromium.org This is purely eye candy. It makes eglCreateSyncKHR failures match their spec description. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 28

[Piglit] [PATCH] glsl-1.10: new test for a special case in glsl-to-tgsi

2015-04-13 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../glsl-1.10/execution/uniform-update.shader_test | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/uniform-update.shader_test diff --git a/tests/spec/glsl-1.10/execution/uniform

[Piglit] [PATCH 14/14] khr_debug/debug-push-pop-group: fix test

2015-04-13 Thread Marek Olšák
From: Daniel Kurtz djku...@chromium.org AFAICT from [0], only PopDebugGroup() adds a message to the log, not PushDebugGroup(). [0] https://www.opengl.org/registry/specs/KHR/debug.txt Thus, there should only be three messages in test_push_pop_debug_group: (1) DebugMessageInsert() -

[Piglit] [PATCH 13/14] dispatch: Use dlsym to lookup core symbols for EGL

2015-04-13 Thread Marek Olšák
From: Daniel Kurtz djku...@chromium.org eglGetProcAddress() only supports extension functions. Therefore, we must use dlsym() directly on the GL client library to look up core functions. The implementation here is a much simplified version of the one in libepoxy. Most of the simplification is

[Piglit] [PATCH 12/14] oes_compressed_paletted_texture: relax glTexImage2D error value expectation

2015-04-13 Thread Marek Olšák
/OES_compressed_paletted_texture.txt It is totally reasonable that some implementations may return that error. So, allow the test to pass in that case. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Marek Olšák marek.ol...@amd.com --- .../oes_compressed_paletted_texture-api.c | 14

Re: [Piglit] [PATCH 00/14] Fixes for EGL and EGL tests

2015-04-13 Thread Marek Olšák
Cc Daniel and Chad. On Mon, Apr 13, 2015 at 8:28 PM, Marek Olšák mar...@gmail.com wrote: Hi everyone, These are mostly fixes that I took from Daniel Kurtz's github repository because I think they are good and he said he had no time to upstream them. I've been working on the fence

[Piglit] [PATCH 12/13] arb_tessellation_shader: add tests for indirect addressing of TES patch inputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...es-patch-input-array-float-index-rd.shader_test | 233 + ...tes-patch-input-array-vec2-index-rd.shader_test | 233 + ...tes-patch-input-array-vec3-index-rd.shader_test | 233 + ...tes-patch

[Piglit] [PATCH 13/13] arb_tessellation_shader: add tests for indirect addressing of all TES inputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com i.e. both patch and non-patch types. This tests 64 inputs and outputs - more than any other shader can have. --- ...tes-both-input-array-float-index-rd.shader_test | 252 + .../tes-both-input-array-vec2-index-rd.shader_test | 252

[Piglit] [PATCH 06/13] shader_runner: add draw rect patch to draw rectangles as patches

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com The only allowed primitive type with tessellation is GL_PATCHES, so this is the only way to draw rectangles. --- tests/shaders/shader_runner.c | 4 tests/util/piglit-util-gl.c | 22 -- tests/util/piglit-util-gl.h | 5 - 3

[Piglit] [PATCH 10/13] arb_tessellation_shader: add tests for indirect addressing of TCS inputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../tcs-input-array-float-index-rd.shader_test | 238 + .../tcs-input-array-vec2-index-rd.shader_test | 238 + .../tcs-input-array-vec3-index-rd.shader_test | 238 + .../tcs-input

[Piglit] [PATCH 09/13] arb_tessellation_shader: add tests for indirect addressing of TCS patch outputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...s-patch-output-array-float-index-wr.shader_test | 218 + ...cs-patch-output-array-vec2-index-wr.shader_test | 218 + ...cs-patch-output-array-vec3-index-wr.shader_test | 218 + ...cs-patch

[Piglit] [PATCH 11/13] arb_tessellation_shader: add tests for indirect addressing of TES inputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../tes-input-array-float-index-rd.shader_test | 237 + .../tes-input-array-vec2-index-rd.shader_test | 237 + .../tes-input-array-vec3-index-rd.shader_test | 237 + .../tes-input

[Piglit] [PATCH 07/13] arb_tessellation_shader: add tests for indirect addressing of VS outputs w/ TCS

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...put-array-float-index-wr-before-tcs.shader_test | 224 + ...tput-array-vec2-index-wr-before-tcs.shader_test | 224 + ...tput-array-vec3-index-wr-before-tcs.shader_test | 224 + ...tput-array

[Piglit] [PATCH 01/13] glsl-1.10: add tests for indirect addressing of FS inputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Each test has 2 arrays and one of them uses a negative relative index. --- .../fs-input-array-float-index-rd.shader_test | 77 ++ .../fs-input-array-vec2-index-rd.shader_test | 77 ++ .../fs-input-array-vec3

[Piglit] [PATCH 05/13] glsl-1.50: add tests for indirect addressing of GS outputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../gs-output-array-float-index-wr.shader_test | 198 + .../gs-output-array-vec2-index-wr.shader_test | 198 + .../gs-output-array-vec3-index-wr.shader_test | 198 + .../gs-output

[Piglit] [PATCH 04/13] glsl-1.50: add tests for indirect addressing of GS inputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../gs-input-array-float-index-rd.shader_test | 217 + .../gs-input-array-vec2-index-rd.shader_test | 217 + .../gs-input-array-vec3-index-rd.shader_test | 217 + .../gs-input

[Piglit] [PATCH 03/13] glsl-1.50: add tests for indirect addressing of VS outputs before GS

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- ...tput-array-float-index-wr-before-gs.shader_test | 201 + ...utput-array-vec2-index-wr-before-gs.shader_test | 201 + ...utput-array-vec3-index-wr-before-gs.shader_test | 201 + ...utput-array

[Piglit] [PATCH 00/13] Tests for indirect addressing of inputs and outputs

2015-04-06 Thread Marek Olšák
Most of the tessellation tests haven't been fully tested because of bugs in the GLSL compiler or incomplete drivers. Sometimes I could only check if the produced TGSI looks good, but in other cases even the GLSL compiler can't produce an IR which makes sense. The tests that can't be run with

[Piglit] [PATCH 02/13] glsl-1.10: add tests for indirect addressing of VS outputs

2015-04-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../vs-output-array-float-index-wr.shader_test | 81 + .../vs-output-array-vec2-index-wr.shader_test | 81 + .../vs-output-array-vec3-index-wr.shader_test | 81 + .../vs-output

Re: [Piglit] [PATCH] gl-2.0: port const vertex attrib webgl test to piglit

2015-03-26 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Mar 26, 2015 at 6:10 PM, Ilia Mirkin imir...@alum.mit.edu wrote: This is a rip off of: https://www.khronos.org/registry/webgl/conformance-suites/1.0.2/conformance/attribs/gl-vertex-attrib-render.html Which presently fails

Re: [Piglit] [PATCH] Add test for accessing a varying array with a large negative offset

2015-03-20 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Mar 20, 2015 at 2:41 AM, Tom Stellard thomas.stell...@amd.com wrote: From: Marek Olšák marek.ol...@amd.com This tests for a bug causing either a crash or a mis-compile in the radeonsi compiler. Tom Stellard: - Decrease

Re: [Piglit] [PATCH] Add test for accessing a varying array with a large negative offset

2015-03-20 Thread Marek Olšák
Well, technically speaking, this should be in spec/glsl-1.10/execution/variable-indexing. Marek On Fri, Mar 20, 2015 at 10:34 AM, Marek Olšák mar...@gmail.com wrote: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Mar 20, 2015 at 2:41 AM, Tom Stellard thomas.stell...@amd.com

Re: [Piglit] [PATCH 1/2] arb_color_buffer_float: Actually use the enum names.

2015-03-17 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Sun, Feb 1, 2015 at 11:22 PM, Eric Anholt e...@anholt.net wrote: --- tests/spec/arb_color_buffer_float/common.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/spec

Re: [Piglit] [PATCH] amd_pinned_memory: Port to Windows.

2015-02-20 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Feb 20, 2015 at 11:01 PM, Jose Fonseca jfons...@vmware.com wrote: We might want to have some OS abstractions for aligned memory if more tests need it, but go for a simple solution for now, as it seems a special case. --- tests/spec

[Piglit] [PATCH] Add a test for GL_AMD_pinned_memory

2015-02-10 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 9 ++ tests/spec/CMakeLists.txt | 1 + tests/spec/amd_pinned_memory/CMakeLists.gl.txt | 14 ++ tests/spec/amd_pinned_memory/CMakeLists.txt| 1 + tests/spec/amd_pinned_memory

[Piglit] [PATCH 2/3] arb_es3_compatibility: add basic test for GL_PRIMITIVE_RESTART_FIXED_INDEX

2015-01-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 1 + tests/spec/arb_es3_compatibility/CMakeLists.gl.txt | 1 + .../es3-primrestart-fixedindex.c | 110 + 3 files changed, 112 insertions(+) create mode 100644

[Piglit] [PATCH 3/3] arb_draw_indirect: test glDrawArraysIndirect with GL_PRIMITIVE_RESTART

2015-01-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 1 + tests/spec/arb_draw_indirect/CMakeLists.gl.txt | 1 + .../arb_draw_indirect/draw-arrays-prim-restart.c | 115 + 3 files changed, 117 insertions(+) create mode 100644

[Piglit] [PATCH 1/3] arb_es3_compatibility: add a test for PRIMITIVE_RESTART_FIXED_INDEX corner case

2015-01-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 1 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_es3_compatibility/CMakeLists.gl.txt | 12 +++ tests/spec/arb_es3_compatibility/CMakeLists.txt| 1 + .../es3

Re: [Piglit] [PATCH] r300.py r500.py: Fix regression in a840dea29a033b8d21

2015-01-02 Thread Marek Olšák
Actually, if you want, you can remove these profiles. I don't use them anymore and I don't know of anyone who does. Marek On Fri, Jan 2, 2015 at 3:15 AM, Dylan Baker baker.dyla...@gmail.com wrote: You're right. Copy and paste error On Dec 31, 2014 6:15 PM, Ilia Mirkin imir...@alum.mit.edu

[Piglit] [PATCH 1/3] ext_transform_feedback: test immediate index buffer reuse

2015-01-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 1 + .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 + .../immediate-reuse-index-buffer.c | 141 + 3 files changed, 143 insertions(+) create mode 100644

[Piglit] [PATCH 3/3] arb_uniform_buffer_objects: add a test for a GLSL bug

2015-01-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../2-buffers-bug.shader_test | 58 ++ 1 file changed, 58 insertions(+) create mode 100644 tests/spec/arb_uniform_buffer_object/2-buffers-bug.shader_test diff --git a/tests/spec/arb_uniform_buffer_object/2

[Piglit] [PATCH 2/3] ext_transform_feedback: test immediate uniform buffer reuse

2015-01-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 1 + .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 + .../immediate-reuse-uniform-buffer.c | 144 + 3 files changed, 146 insertions(+) create mode 100644

Re: [Piglit] [PATCH] r300.py r500.py: Fix regression in a840dea29a033b8d21

2015-01-01 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Jan 1, 2015 at 2:46 AM, Dylan Baker baker.dyla...@gmail.com wrote: The above commit changed r300.py and r500.py to no longer import quick.profile and modify that, but instead made them create a new profile with a single test

[Piglit] [PATCH 2/3] arb_tessellation_shader/execution: clear before testing

2014-10-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com The back buffer may already be green after allocation. --- tests/spec/arb_tessellation_shader/execution/nop.shader_test| 2 ++ tests/spec/arb_tessellation_shader/execution/sanity.shader_test | 2 ++ .../arb_tessellation_shader/execution

[Piglit] [PATCH] glsl-1.20: new tests for indirect access into a constant array

2014-10-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com 4, 8, 16, 32 pass on radeonsi. 48 fails in a weird way. 64, 128, 256 crash on an assertion failure. softpipe passes all of them. --- ...-array-indirect-access-004-elements.shader_test | 35 +++ ...-array-indirect-access-008-elements.shader_test | 39

[Piglit] [PATCH 1/3] arb_tessellation_shader/execution/tcs-tes-patch-array: new test for patch array

2014-10-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This verifies that assigned locations are correct for arrays. --- BTW, the second patch depends on chrisf's patches. .../execution/tcs-tes-patch-array.shader_test | 59 ++ 1 file changed, 59 insertions(+) create mode 100644 tests

[Piglit] [PATCH 3/3] arb_tessellation_shader/quads: new more complex test

2014-10-16 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- .../execution/quads.shader_test| 125 + 1 file changed, 125 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/quads.shader_test diff --git a/tests/spec/arb_tessellation_shader

[Piglit] [PATCH] glsl-1.20: new test for a GLSL scoping bug in Mesa

2014-09-09 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Mesa things Name is a type in gl_Position = Name. --- .../compiler/scoping-struct-vs-variable.vert | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 tests/spec/glsl-1.20/compiler/scoping-struct-vs-variable.vert diff

[Piglit] [PATCH 1/3] util: add ALIGN macro

2014-08-23 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/bugs/fdo10370.c| 1 + tests/util/piglit-util.h | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/bugs/fdo10370.c b/tests/bugs/fdo10370.c index 95e3d56..7826543 100644 --- a/tests/bugs/fdo10370.c +++ b/tests/bugs/fdo10370.c @@ -15,6

[Piglit] [PATCH 3/3] fbo-depth-array: rewrite the test to make it really comprehensive

2014-08-23 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com It tests: - clearing - layered clearing - drawing - drawing with a depth or stencil shader output - various sizes of TEXTURE_2D_ARRAY - texturing with both depth and stencil. --- tests/all.py| 8 +- tests/fbo/fbo-depth-array.c | 513

[Piglit] [PATCH 2/3] util: add piglit_probe_rect_r_ubyte

2014-08-23 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This is a lot faster than RGBA FLOAT. There is a potential to speed up piglit by switching tests to ubyte r, rg, or rgba probing. --- tests/util/piglit-util-gl.c | 32 tests/util/piglit-util-gl.h | 1 + 2 files changed, 33

Re: [Piglit] [PATCH] Allow one 'non-concurrent' test to run in parallel with concurrent tests again

2014-08-21 Thread Marek Olšák
Hi Michel, I recommend using the -c option. It will force concurrency for all tests. With that, I don't care which tests aren't concurrent by default. Marek On Wed, Aug 20, 2014 at 5:13 AM, Michel Dänzer mic...@daenzer.net wrote: From: Michel Dänzer michel.daen...@amd.com This reverts commit

Re: [Piglit] [PATCH] Allow one 'non-concurrent' test to run in parallel with concurrent tests again

2014-08-21 Thread Marek Olšák
I actually agree with the patch. I was just making a suggestion. It seems nobody has NAK'd this patch yet. :) Marek On Thu, Aug 21, 2014 at 11:24 AM, Michel Dänzer mic...@daenzer.net wrote: On 21.08.2014 17:57, Marek Olšák wrote: I recommend using the -c option. It will force concurrency

[Piglit] [PATCH] tex-miplevel-selection: test textureGrad with cubemaps

2014-08-14 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com llvmpipe passes, which is probably the only driver which implements it correctly. --- tests/all.py | 8 tests/texturing/tex-miplevel-selection.c | 20 +++- 2 files changed, 23 insertions(+), 5 deletions

Re: [Piglit] [PATCH 3/3] arb_texture_barrier: copy existing NV_texture_barrier test

2014-08-12 Thread Marek Olšák
/nv_texture_barrier/blending-in-shader-arb.c new file mode 100644 index 000..c0c3db8 --- /dev/null +++ b/tests/spec/nv_texture_barrier/blending-in-shader-arb.c @@ -0,0 +1,118 @@ +/* + * Copyright © 2011 Marek Olšák + * + * Permission is hereby granted, free of charge, to any person obtaining

Re: [Piglit] [PATCH] tex-miplevel-selection: use GL_CLAMP_TO_EDGE instead of GL_REPEAT

2014-08-07 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Aug 7, 2014 at 4:51 AM, srol...@vmware.com wrote: From: Roland Scheidegger srol...@vmware.com GL_REPEAT is not legal for the rectangle targets, and because the test uses sampler objects the default GL_REPEAT value will be used even

Re: [Piglit] [PATCH 3/3] ext_texture_array: add simple 1D/2D array rendering tests

2014-08-07 Thread Marek Olšák
I have the same failure on radeonsi. Marek On Thu, Aug 7, 2014 at 7:43 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Can I assume that you tested this on llvmpipe and it worked? I'm getting failures on render-1darray with nvc0, whereby layers 1+ are random data, but we pass all the regular

Re: [Piglit] [PATCH] Add test to verify glTexSubImage2D() with depth formats

2014-08-07 Thread Marek Olšák
FYI, you forgot to add the test to all.py. Marek On Wed, Aug 6, 2014 at 4:07 AM, Anuj Phogat anuj.pho...@gmail.com wrote: This test verifies the bug fix in i965 drivers in mesa commit 984a02b. Reproduces another bug in the driver with GL_DEPTH_COMPONENT16 internal format. Signed-off-by:

[Piglit] [PATCH 1/3] attribs: add support for the SNORM equation 2.3

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/general/attribs.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/tests/general/attribs.c b/tests/general/attribs.c index 3f02142..f48d8b9 100644 --- a/tests/general/attribs.c +++ b/tests/general

[Piglit] [PATCH 2/3] draw-vertices-2101010: add support for the SNORM equation 2.3

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/arb_vertex_type_2_10_10_10_rev/draw-vertices-2101010.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/spec/arb_vertex_type_2_10_10_10_rev/draw-vertices-2101010.c b/tests/spec/arb_vertex_type_2_10_10_10_rev/draw-vertices

[Piglit] [PATCH 3/3] oes_compressed_etc2_texture-miptree: fix the R11 test

2014-08-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Clearing a buffer with masked channels results in not clearing anything in those channels, so there is always random garbage. No wonder that the test was always failing. Apparently, i965 ignores the colormask, otherwise it wouldn't have been unnoticed

Re: [Piglit] [PATCH 00/23] Tests for all GLSL texture functions (almost)

2014-08-01 Thread Marek Olšák
. Marek On Mon, Jul 7, 2014 at 11:09 PM, Matt Turner matts...@gmail.com wrote: On Fri, Jul 4, 2014 at 7:09 AM, Marek Olšák mar...@gmail.com wrote: This adds tests for all GLSL texture function. The tex-miplevel-selection test is used, since it's a good foundation for testing texturing

Re: [Piglit] [PATCH piglit 4/6] bptc: Add tests using fbo-generatemipmap-formats

2014-07-29 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Jul 29, 2014 at 5:27 PM, Neil Roberts n...@linux.intel.com wrote: The unsigned half float format needs special handling because the texture that the test uploads tries to use negative values. --- tests/all.py

Re: [Piglit] [PATCH piglit 5/6] texwrap: Add the BPTC formats

2014-07-29 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Jul 29, 2014 at 5:27 PM, Neil Roberts n...@linux.intel.com wrote: --- tests/all.py | 1 + tests/texturing/texwrap.c | 13 + 2 files changed, 14 insertions(+) diff --git a/tests/all.py b/tests/all.py

Re: [Piglit] [PATCH piglit 6/6] compressedteximage: Add tests for the four BPTC formats

2014-07-29 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Jul 29, 2014 at 5:27 PM, Neil Roberts n...@linux.intel.com wrote: --- tests/all.py | 4 tests/texturing/compressedteximage.c | 10 ++ 2 files changed, 14 insertions(+) diff --git a/tests

Re: [Piglit] [PATCH piglit] Add a test case for all of the modes of BPTC texture compression

2014-07-24 Thread Marek Olšák
Well, the meta code is pretty much an Intel-specific thing, because other drivers which are being actively worked on do not use it. One way to test compression and decompression is to add support to the fbo-generatemipmap-formats test, because mipmap generation is done entirely in software for

Re: [Piglit] [PATCH piglit] Add a test case for all of the modes of BPTC texture compression

2014-07-23 Thread Marek Olšák
Adding a new test for BPTC might be useful if want to test a feature that isn't covered by other tests, because there already is a test infrastructure for testing all OpenGL formats and it's just a matter of adding BPTC support to existing tests. Mostly, just adding the new formats to appropriate

Re: [Piglit] [PATCH] texwrap: minor assorted changes

2014-07-14 Thread Marek Olšák
By removing offset++, you left some empty if statements in there. Other than that: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Mon, Jul 14, 2014 at 4:37 PM, Brian Paul bri...@vmware.com wrote: Always draw a (mode, filter) test pattern at the same window position, regardless

Re: [Piglit] [PATCH 00/23] Tests for all GLSL texture functions (almost)

2014-07-07 Thread Marek Olšák
SNB turned up a bunch of failures, followed by a few GPU hangs it recovered from, followed by a GPU hang that killed the system (not even SysRq could reboot it, had to use the dreaded power button). On Fri, Jul 4, 2014 at 2:26 PM, Marek Olšák mar...@gmail.com wrote: Well, I think piglit should

[Piglit] [PATCH 16/23] tex-miplevel-selection: test all variants of textureGradOffset

2014-07-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 10 ++ tests/texturing/tex-miplevel-selection.c | 54 +--- 2 files changed, 46 insertions(+), 18 deletions(-) diff --git a/tests/all.py b/tests/all.py index bb13c05..228bd25

[Piglit] [PATCH 13/23] tex-miplevel-selection: test all variants of textureProjLod

2014-07-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 8 tests/texturing/tex-miplevel-selection.c | 17 ++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/tests/all.py b/tests/all.py index 154891a..bc8f31c 100644 --- a/tests

[Piglit] [PATCH 08/23] tex-miplevel-selection: test all variants of textureProj with bias

2014-07-04 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 8 +++ tests/texturing/tex-miplevel-selection.c | 37 ++-- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/tests/all.py b/tests/all.py index 3a18ebf..a1969e8

Re: [Piglit] [PATCH] arb_texture_query_lod: allow some tolerance for comparisons

2014-06-18 Thread Marek Olšák
Olšák mar...@gmail.com wrote: From: Marek Olšák marek.ol...@amd.com This is required for radeonsi to pass. --- .../execution/fs-textureQueryLOD-linear.shader_test | 9 +++-- .../execution/fs-textureQueryLOD-nearest.shader_test | 6 +- .../execution/fs

Re: [Piglit] [PATCH] arb_sample_shading: make sure gl_SampleMask has no effect when no ms

2014-06-11 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jun 11, 2014 at 2:11 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- .../arb_sample_shading/execution/builtin-gl-sample-mask-simple.cpp | 5 - tests/spec/arb_sample_shading

[Piglit] [PATCH] builtin-gl-sample-mask-simple: another test for gl_SampleMask[0] FS output

2014-06-02 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This one is simpler and easier to debug. It passes on my hardware, while the other one fails (due to a shader bug probably). I don't like tests that return the pass or fail status from the shader, because they are impossible to debug. Therefore, this one

Re: [Piglit] [PATCH] summary: fix support for old results file with duplicated subtests

2014-05-29 Thread Marek Olšák
First, I'm sorry for complaining and not reviewing patches, because I don't know Python very well and I'm also quite busy. I'm grateful for all the work on piglit that's happening. I always keep old piglit results from old Mesa around, that includes R580, RV670, RV730, EG/Redwood, NI/Cayman,

Re: [Piglit] Seperate NOTRUN and SKIP from fixes and regressions

2014-05-28 Thread Marek Olšák
workflow. - Dylan On Tuesday, March 18, 2014 02:34:57 Marek Olšák wrote: I cannot review this, because I'm not familiar with the code, but the last patch looks good to me and I like the overall idea. Marek On Mon, Mar 17, 2014 at 8:06 PM, Dylan Baker baker.dyla...@gmail.com wrote: This series

Re: [Piglit] Seperate NOTRUN and SKIP from fixes and regressions

2014-05-28 Thread Marek Olšák
Also, the changes page doesn't contain disabled tests. It only contains enabled tests and changed results. Marek On Wed, May 28, 2014 at 3:55 PM, Marek Olšák mar...@gmail.com wrote: I think there is a bug. It looks like subtest results of one of the tests are also added to all the following

Re: [Piglit] Seperate NOTRUN and SKIP from fixes and regressions

2014-05-28 Thread Marek Olšák
Yeah, it looks like it's the same bug. Marek On Wed, May 28, 2014 at 4:18 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, May 28, 2014 at 9:55 AM, Marek Olšák mar...@gmail.com wrote: I think there is a bug. It looks like subtest results of one of the tests are also added to all

Re: [Piglit] [PATCH 1/5] fbo-drawbuffers-none: Add the instructions for running subtests

2014-05-20 Thread Marek Olšák
If you fix the typo that Ilia pointed out, the series is: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Mon, May 19, 2014 at 10:51 PM, Anuj Phogat anuj.pho...@gmail.com wrote: Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../arb_framebuffer_object/fbo-drawbuffers-none.c

Re: [Piglit] [PATCH] profile: Fix mixed concurrency runs

2014-04-24 Thread Marek Olšák
I'm not sure I undertand this. I think the limitation for non-concurrent tests is that they cannot be concurrently, because they do front buffer rendering and other things. That doesn't mean all the off-screen tests cannot be run with the non-concurrent tests simultaneously. Marek On Thu, Apr

Re: [Piglit] [PATCH] profile: Fix mixed concurrency runs

2014-04-24 Thread Marek Olšák
:47 Marek Olšák wrote: I'm not sure I undertand this. I think the limitation for non-concurrent tests is that they cannot be concurrently, because they do front buffer rendering and other things. That doesn't mean all the off-screen tests cannot be run with the non-concurrent tests

[Piglit] What happened to concurrency?

2014-04-11 Thread Marek Olšák
Hi, I have updated piglit today (c5060a8..3456230) and found out that concurrency is broken. When I run piglit, about 5000 tests run concurrently with all 4 CPU cores utilized and then it drops to 1 CPU core for the rest of the run (there are 16000 tests or so) and takes a very long time to

Re: [Piglit] [PATCH] framework: Fix concurrency regression introduced by Test refactor

2014-04-11 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, Apr 11, 2014 at 9:33 PM, Dylan Baker baker.dyla...@gmail.com wrote: For whatever reason the concurrency flag was not passed to GLSLParserTest and ShaderTest after the refactor. This patch fixes that by always passing that keyword

[Piglit] Crashing tests are not shown in the HTML summary

2014-04-07 Thread Marek Olšák
Hi, There is a serious issue with piglit that crashing tests just disappear from the HTML summary. Let's say I apply this: diff --git a/tests/fbo/fbo-generatemipmap-formats.c b/tests/fbo/fbo-generatemipmap-formats.c index 666030f..0d4a06b 100644 --- a/tests/fbo/fbo-generatemipmap-formats.c +++

[Piglit] [PATCH] primitive-restart-draw-mode: fix failures caused by precision issues

2014-03-22 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Instead of offsetting the vertex position for the second half of the screen, setup both halves as separate viewports. --- tests/general/primitive-restart-draw-mode.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/general

Re: [Piglit] [PATCH 08/10] fbo-generatemipmap-3d: new test for 3D mipmap generation

2014-03-20 Thread Marek Olšák
Paul bri...@vmware.com wrote: Two very minor nits (applies to other tests too). On 03/15/2014 10:53 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 2 + tests/fbo/CMakeLists.gl.txt | 1 + tests/fbo/fbo-generatemipmap

Re: [Piglit] welcome

2014-03-17 Thread Marek Olšák
Hi Johney, The development takes place in this repository: http://cgit.freedesktop.org/piglit/ If you have patches for piglit, you can send them to this mailing list. Marek On Mon, Mar 17, 2014 at 7:29 AM, Guo, Johney weijun@amd.com wrote: Hi, I found piglit is a so amazing software.

Re: [Piglit] Seperate NOTRUN and SKIP from fixes and regressions

2014-03-17 Thread Marek Olšák
I cannot review this, because I'm not familiar with the code, but the last patch looks good to me and I like the overall idea. Marek On Mon, Mar 17, 2014 at 8:06 PM, Dylan Baker baker.dyla...@gmail.com wrote: This series separates the SKIP and NOTRUN status changes from fixes and regressions

Re: [Piglit] [PATCH 1/4] fbo-blit-d24s8: avoid using textures

2014-03-16 Thread Marek Olšák
This patch looks good to me. Marek On Thu, Mar 13, 2014 at 5:07 PM, Ilia Mirkin imir...@alum.mit.edu wrote: There's no reason to attach the teximages to the framebuffer. Instead use renderbuffers so that we don't need to depend on ARB_depth_texture. Signed-off-by: Ilia Mirkin

Re: [Piglit] [PATCH 2/4] copyteximage: add ARB_depth_texture dependencies

2014-03-16 Thread Marek Olšák
Did you forget GL_DEPTH_COMPONENT32 or is it not tested by this test? Marek On Thu, Mar 13, 2014 at 5:07 PM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- tests/texturing/copyteximage.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [Piglit] [PATCH 4/4] readpixels-24_8: replace teximage use with renderbuffer

2014-03-16 Thread Marek Olšák
This series is: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Thu, Mar 13, 2014 at 5:07 PM, Ilia Mirkin imir...@alum.mit.edu wrote: This removes an implicit dependency on ARB_depth_texture (and is more efficient). Signed-off-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Piglit] [PATCH 2/4] copyteximage: add ARB_depth_texture dependencies

2014-03-16 Thread Marek Olšák
] }, { GL_DEPTH_COMPONENT32F, fcolor[7] }, { GL_DEPTH24_STENCIL8, fcolor[7] }, { GL_DEPTH32F_STENCIL8, fcolor[7] }, On Sun, Mar 16, 2014 at 10:03 AM, Marek Olšák mar...@gmail.com wrote: Did you forget GL_DEPTH_COMPONENT32 or is it not tested by this test? Marek On Thu, Mar 13, 2014 at 5:07 PM, Ilia

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2014-03-15 Thread Marek Olšák
at 1:36 PM, Daniel Vetter dan...@ffwll.ch wrote: On Fri, Nov 22, 2013 at 12:10:43AM +0100, Marek Olšák wrote: It looks like people have different expectations from notrun and skip, so I have a proposal: - add a notrun page similar to the skipped page - don't include the notrun and skip statuses

[Piglit] [PATCH 02/10] gl-3.2/3.3-minmax: fix GL_NUM_COMPRESSED_TEXTURE_FORMATS limit checking

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.2/minmax.c | 4 +++- tests/spec/gl-3.3/minmax.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/spec/gl-3.2/minmax.c b/tests/spec/gl-3.2/minmax.c index e4d135d..448b02e 100644 --- a/tests/spec/gl-3.2

<    1   2   3   4   5   6   >