Re: [Piglit] [PATCH 4/4] Add test to draw multisample polygons with GL_POLYGON_SMOOTH enabled

2012-05-22 Thread Paul Berry
On 18 May 2012 16:57, Anuj Phogat anuj.pho...@gmail.com wrote: This test varifies that GL_POLYGON_SMOOTH is ignored in case of multisample polygons. Note: Multisample polygons renders fine but I couldn't draw smooth polygons using AMD's catalyst drivers. This test passes on AMD's catalyst

Re: [Piglit] [PATCH 15/29] tests: Include glu.h where glu is used

2012-05-25 Thread Paul Berry
On 21 May 2012 11:08, Pauli Nieminen pauli.niemi...@linux.intel.com wrote: There is a few places where glu is used without including the header. That produces warnings about missing functions. To silence compiler warnings glu header needs to be included. If I'm not mistaken, glu is *usually*

[Piglit] Waffle and piglit-dispatch plans

2012-05-25 Thread Paul Berry
In the last few months Chad Versace and I have put a lot of effort into reworking the core of Piglit with an eye towards being able to effectively test GLES, Wayland, Android, and core profiles. A lot of that work is still in progress, and since others are starting to join in this effort, it

Re: [Piglit] [PATCH v2 1/4] Add new classes to draw points and lines in to multisample FBO

2012-05-29 Thread Paul Berry
. Also made changes to draw points and lines with floating point sizes and sizes 1.0. Looks reasonable. We should probably trim down the commit message so that it only mentions Points and Lines. With that changed, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com Signed-off

Re: [Piglit] [PATCH 2/4] Add test to draw multisample lines with GL_LINE_SMOOTH enabled

2012-05-29 Thread Paul Berry
On 22 May 2012 14:42, Anuj Phogat anuj.pho...@gmail.com wrote: On Tue, May 22, 2012 at 8:37 AM, Paul Berry stereotype...@gmail.com wrote: On 18 May 2012 16:56, Anuj Phogat anuj.pho...@gmail.com wrote: + + /* Draw test pattern in mulisample test_fbo with GL_LINE_SMOOTH

[Piglit] [PATCH 01/20] util: Generalize piglit_probe_image_{rgb, rgba}

2012-06-05 Thread Paul Berry
This patch eliminates code duplication between piglit_probe_image_rgb() and piglit_probe_image_rgba() by implementing them both in terms of a common function, piglit_probe_image_color(). In addition to being able to test GL_RGB and GL_RGBA, piglit_probe_image_color() should be able to test any

[Piglit] [PATCH 08/20] fbo: Split out a function for selecting an fbo test set by name.

2012-06-05 Thread Paul Berry
This patch extracts code from fbo_formats_init() into a separate function, fbo_lookup_test_set(), whose only purpose is to find an FBO test set given its name. This will make it easier for future tests to make use of fbo-formats.h even if they have to use different command-line parsing than what

[Piglit] [PATCH 09/20] fbo: Make an alternate function for initializing fbo-formats.h.

2012-06-05 Thread Paul Berry
This patch extracts code from fbo_formats_init() into a separate function, fbo_formats_init_test_set(), which skips command line parsing and simply initializes fbo-formats.h to use a particular test set. This will allow future tests to make use of fbo-formats.h even if they have to use different

[Piglit] [PATCH 12/20] msaa: Reuse FboConfig data structure in Fbo.

2012-06-05 Thread Paul Berry
This patch modifies Fbo so that instead of storing its copy of the configuration parameters passed to init() as primitive values, it stores them using an FboConfig data structure. --- tests/spec/ext_framebuffer_multisample/common.cpp | 80 -

[Piglit] [PATCH 16/20] msaa: Allow format of the color buffer used in the MSAA fbos to be configured.

2012-06-05 Thread Paul Berry
This will make it possible to test proper operation of MSAA with various color buffer formats. For tests that don't need to vary the color buffer format, a default format of GL_RGBA is used. --- tests/spec/ext_framebuffer_multisample/common.cpp |8 +---

[Piglit] [PATCH 18/20] msaa: Fix const correctness of TestPattern::draw() function.

2012-06-05 Thread Paul Berry
--- tests/spec/ext_framebuffer_multisample/common.cpp | 10 +- tests/spec/ext_framebuffer_multisample/common.h | 12 ++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/common.cpp

[Piglit] [PATCH 19/20] msaa: Make a static identity matrix for convenience.

2012-06-05 Thread Paul Berry
This patch adds a constant matrix TestPattern::no_projection (which is the identity matrix), for use by tests that don't need to pass a projection matrix when calling TestPattern::draw(). --- tests/spec/ext_framebuffer_multisample/common.cpp |9 +

[Piglit] [PATCH 20/20] msaa: Test that MSAA works properly for all core FBO color formats.

2012-06-05 Thread Paul Berry
This test builds on the existing FBO and MSAA testing infrastructure to verify proper functioning of MSAA for various formats. All core formats which are framebufferbuffer complete are tested. All formats which are not framebuffer complete are skipped. Tests for non-core and depth/stencil

Re: [Piglit] [PATCH 20/20] msaa: Test that MSAA works properly for all core FBO color formats.

2012-06-06 Thread Paul Berry
On 6 June 2012 17:52, Anuj Phogat anuj.pho...@gmail.com wrote: On Tue, Jun 5, 2012 at 5:03 PM, Paul Berry stereotype...@gmail.com wrote: This test builds on the existing FBO and MSAA testing infrastructure to verify proper functioning of MSAA for various formats. All core formats which

Re: [Piglit] [PATCH 1/6] glsl-1.20 / glsl-1.30: Add tests for uniforms with initializers

2012-06-12 Thread Paul Berry
On 21 May 2012 14:10, Ian Romanick i...@freedesktop.org wrote: On 05/21/2012 10:34 AM, Paul Berry wrote: On 16 May 2012 14:23, Ian Romanick i...@freedesktop.org mailto:i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com mailto:ian.d.romanick@intel.**com

[Piglit] [PATCH 1/2] msaa: Refactor all.tests so that sample counts to test are specified once.

2012-06-12 Thread Paul Berry
--- tests/all.tests | 21 - 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index a004323..6d9e0ce 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -64,6 +64,9 @@ try: except SystemExit: pass +# List of all of

[Piglit] [PATCH 2/2] msaa: Test that msaa blits are clipped and scissored correctly.

2012-06-12 Thread Paul Berry
There are three reasons why the set of rectangles passed to glBlitFramebuffer() might need to be clipped before performing the blit: 1. If the destination rectangle falls (partly or completely) outside the bounds of the draw framebuffer. 2. If the destination rectangle falls (partly or

[Piglit] [PATCH] glsl-1.30: Verify proper conversion of large floats to uints.

2012-06-13 Thread Paul Berry
This patch adds two new tests that exercise a bug in Mesa/i965: conversion from float to uint was being done in a two step process: convert first to int and then to uint. Since i965 uses saturating arithmetic in float-int conversion, this caused conversion to give the wrong result for values

[Piglit] [PATCH 00/16] msaa: thoroughly test different formats.

2012-06-15 Thread Paul Berry
This patch series tests that MSAA works properly across a variety of framebuffer formats, in particular: integer formats, floating point formats, RED and RG formats, and sRGB formats. Patches 01-03 lay the necessary infrastructure groundwork, by refactoring piglit-util-gl.c and

[Piglit] [PATCH 01/16] util: Make a separate function to compare in-memory images.

2012-06-15 Thread Paul Berry
This patch splits off a new piglit-util function, piglit_compare_images_color(), from the existing piglit_probe_image_color() function. The new function compares two images in memory, so that the caller can take responsibility for calling glReadPixels(). In addition, this patch creates a

[Piglit] [PATCH 03/16] msaa: Make it possible to scale and offset ColorGradientSunburst.

2012-06-15 Thread Paul Berry
In order to test that MSAA works properly for integer framebuffers, we will need to be able to adjust the outputs of the ColorGradientSunburst program to cover the range of signed or unsigned integers, rather than the range [0, 1] that is appropriate for testing normalized color framebuffers.

[Piglit] [PATCH 04/16] msaa/formats: Adapt test pattern drawing to handle integer formats.

2012-06-15 Thread Paul Berry
This patch adapts the MSAA formats test so that it can draw to integer framebuffers, by creating 3 instantiations of the ColorGradientSunburst class, one for testing vec4's (for floating point and normalized formats), one for testing ivec4's (for signed integer formats), and one for testing

[Piglit] [PATCH 07/16] msaa/formats: Use a scale and offset for testing integer formats.

2012-06-15 Thread Paul Berry
This patch adapts the MSAA formats test so that when drawing into integer framebuffers, it applies the necessary scale and offset to cover the entire range of possible integer values. When reading pixels back from the framebuffer, the test applies the inverse scale and offset, so that the result

[Piglit] [PATCH 09/16] msaa/formats: Add EXT_texture_integer tests.

2012-06-15 Thread Paul Berry
The MSAA formats test now properly tests integer framebuffer formats. This patch updates all.tests to cause integer framebuffer formats to be tested. --- tests/all.tests |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index

[Piglit] [PATCH 08/16] msaa/formats: Make it possible to specify a test set on the command line.

2012-06-15 Thread Paul Berry
--- tests/spec/ext_framebuffer_multisample/formats.cpp | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp b/tests/spec/ext_framebuffer_multisample/formats.cpp index d2386ad..a55f053 100644 ---

[Piglit] [PATCH 12/16] msaa/formats: Fix visualization of RED and RG formats

2012-06-15 Thread Paul Berry
The switch statement in visualize_image() wasn't properly handling formats whose base internal format is GL_RED or GL_RG. As a result, tests of these formats showed up as a black screen. This patch addes switch cases to handle the formats properly. ---

[Piglit] [PATCH 10/16] msaa/formats: Adjust tolerance appropriately for floating-point formats.

2012-06-15 Thread Paul Berry
When setting up a floating-point format, the GL implementation responds to queries GL_ATTACHMENT_{RED,GREEN,BLUE,ALPHA}_SIZE with the total number of bits in the floating-point value, regardless of whether those bits are used for sign, exponent, or mantissa. However, for the purpose of setting a

[Piglit] [PATCH 13/16] msaa/formats: Add ARB_texture_rg tests.

2012-06-15 Thread Paul Berry
The MSAA formats test now properly tests RED and RG format framebuffers. This patch updates all.tests to cause those formats to be tested. --- tests/all.tests |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index a01ba4a..2a636f3

[Piglit] [PATCH 11/16] msaa/formats: Add floating point format tests.

2012-06-15 Thread Paul Berry
The MSAA formats test now properly tests floating point formats. This patch updates all.tests to cause those formats to be tested. --- tests/all.tests |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 3f4ab26..a01ba4a 100644 ---

[Piglit] [PATCH 14/16] msaa: Verify accuracy of sRGB MSAA resolves.

2012-06-15 Thread Paul Berry
From the GL spec, version 4.2, section 4.1.11 (Additional Multisample Fragment Operations): If a framebuffer object is not bound, after all operations have been completed on the multisample buffer, the sample values for each color in the multisample buffer are combined to produce a

[Piglit] [PATCH 16/16] msaa/formats: Add EXT_texture_sRGB tests.

2012-06-15 Thread Paul Berry
The MSAA formats test now properly tests sRGB format framebuffers. This patch updates all.tests to cause those formats to be tested. --- tests/all.tests |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 755eace..2102faa 100644 ---

[Piglit] [PATCH 15/16] msaa/formats: Fix testing of sRGB formats.

2012-06-15 Thread Paul Berry
sRGB buffers use a different blending operation to do multisample resolves from non-sRGB buffers. Accordingly, when testing sRGB formats, we need to use an sRGB reference image. This patch modifies the MSAA formats test so that when testing an sRGB format, it renders the reference image using

[Piglit] [PATCH 05/16] msaa/formats: Adapt glReadPixels() call to handle integer formats.

2012-06-15 Thread Paul Berry
This patch adapts the MSAA formats test to pass the proper parameters to glReadPixels() when checking that the proper image has been rendered. Since glReadPixels() requires an integral type when reading pixels from an integer framebuffer, we read the pixels into a temporary integer buffer and

[Piglit] [PATCH 02/16] msaa: Make it possible to change output type when drawing sunbursts.

2012-06-15 Thread Paul Berry
In order to test that MSAA works properly for integer framebuffers, we will need to be able to output ivec4 and uvec4 types when rendering the test image. This patch makes that possible by adapting the Sunburst GLSL program so that it can be compiled to output ivec4's, uvec4's, or vec4's. ---

Re: [Piglit] [PATCH 2/4] Add test to verify glSampleCoverage with multisample fbo

2012-06-16 Thread Paul Berry
On 8 June 2012 14:43, Anuj Phogat anuj.pho...@gmail.com wrote: This test varifies that the coverage value set by glSampleCoverage() decides the number of samples in multisample buffer covered by an incoming fragment, which will receive the fragment data. This test seems to assume that the

Re: [Piglit] [PATCH 3/4] Add test to verify sample alpha to coverage with multisample fbo

2012-06-16 Thread Paul Berry
On 8 June 2012 14:45, anuj.pho...@gmail.com wrote: From: Anuj Phogat anuj.pho...@gmail.com This test varifies that with GL_SAMPLE_ALPHA_TO_COVERAGE enabled, the coverage value is set by fragment alpha value. Coverage value decides the number of samples in multisample buffer covered by an

Re: [Piglit] [PATCH 2/2] Add test to verify the functionality of polygon stipple with multisample FBO

2012-06-16 Thread Paul Berry
On 12 June 2012 12:42, Anuj Phogat anuj.pho...@gmail.com wrote: Test assumes that MSAA accuracy test already passes. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com My comments on the previous patch apply to this one as well. Assuming they are addressed, Reviewed-by: Paul Berry stereotype

Re: [Piglit] [PATCH 1/3] Add test to verify glBlitFramebuffer with non-matching sample count

2012-06-18 Thread Paul Berry
minor fixes, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 3/3] Add test to verify glBlitFramebuffer with non-matching buffer formats

2012-06-18 Thread Paul Berry
recommend also calling piglit_check_gl_error() here, just to make sure that an error didn't occur while setting up the formats. With these two minor changes, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com + glBlitFramebuffer(0, 0, pattern_width, pattern_height

[Piglit] [PATCH] Test that dFdx/dFdy work properly on fbos

2012-06-20 Thread Paul Berry
This test exposes a bug in Mesa on i965 hardware (as of commit f2f05e5): the GLSL function dFdy() produces incorrect results when rendering to an FBO. This is a consequence of the fact that FBOs place the origin at the upper left, whereas windowsystem framebuffers place the origin at the lower

Re: [Piglit] [PATCH] Test that dFdx/dFdy work properly on fbos

2012-06-21 Thread Paul Berry
On 20 June 2012 17:44, Chad Versace chad.vers...@linux.intel.com wrote: On 06/20/2012 03:16 PM, Paul Berry wrote: This test exposes a bug in Mesa on i965 hardware (as of commit f2f05e5): the GLSL function dFdy() produces incorrect results when rendering to an FBO. This is a consequence

[Piglit] [PATCH] msaa: Test that the centroid interpolation qualifier works correctly.

2012-06-21 Thread Paul Berry
This patch adds tests to verify that: - When GL_MULTISAMPLE is disabled, the centroid keyword is ignored, and interpolation is performed at pixel centers (consistent with the GL rules for non-antialiased rendering). - When GL_MULTISAMPLE is enabled and the centroid keyword is used,

Re: [Piglit] tests failing on freeglut

2012-06-22 Thread Paul Berry
On 22 June 2012 03:15, Dave Airlie airl...@gmail.com wrote: Hi guys, I haven't ran piglit in ages, went to give it a spin this morning and getting a lot of fails due to ./bin/fbo-fragcoord -auto -fbo freeglut ERROR: Function glutSwapBuffers called without first calling 'glutInit'.

Re: [Piglit] [PATCH 1/2] Add test to verify glSampleCoverage with multisample fbo

2012-06-22 Thread Paul Berry
: PIGLIT_FAIL; +} -- 1.7.7.6 My suggestions are pretty nit-picky, so regardless of whether you take my suggestions, you can consider this patch Reviewed-by: Paul Berry stereotype...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH 2/2] Add test to verify sample alpha to coverage with multisample fbo

2012-06-22 Thread Paul Berry
-by: Paul Berry stereotype...@gmail.com Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- This test fails on AMD's catalyst drivers with GL_SAMPLE_ALPHA_TO_ONE enabled. But as I remember it passed on NVIDIA last time. I will confirm it before pushing the test case. tests/all.tests

Re: [Piglit] [PATCH] ext_framebuffer_multisample: fix turn-on-off test

2012-06-22 Thread Paul Berry
proprietary drivers. Good catch. Reviewed-by: Paul Berry stereotype...@gmail.com Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- .../ext_framebuffer_multisample/turn-on-off.cpp|3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/tests/spec

Re: [Piglit] [PATCH 14/16] msaa: Verify accuracy of sRGB MSAA resolves.

2012-06-22 Thread Paul Berry
On 22 June 2012 13:28, Anuj Phogat anuj.pho...@gmail.com wrote: On Fri, Jun 15, 2012 at 8:32 AM, Paul Berry stereotype...@gmail.com wrote: From the GL spec, version 4.2, section 4.1.11 (Additional Multisample Fragment Operations): If a framebuffer object is not bound, after all

[Piglit] [PATCH 1/3] Transform feedback: Stop using wrapper functions.

2012-07-02 Thread Paul Berry
The wrapper functions in tests/util/piglit-transform-feedback.{c,h} (e.g. piglit_BeginTransformFeedback()) are no longer needed, since the piglit-dispatch mechanism automatically redirects to the EXT variants when GL 3.0 is not supported. This patch stops using the wrapper functions; the next

[Piglit] [PATCH 2/3] Transform feedback: Eliminate wrapper functions.

2012-07-02 Thread Paul Berry
The wrapper functions in tests/util/piglit-transform-feedback.{c,h} (e.g. piglit_BeginTransformFeedback()), are no longer needed, since the piglit-dispatch mechanism automatically redirects to the EXT variants when GL 3.0 is not supported. This patch removes the unnecessary wrapper functions. ---

[Piglit] [PATCH 3/3] Transform feedback: Move piglit_require_transform_feedback().

2012-07-02 Thread Paul Berry
With the transform feedback wrapper functions removed, piglit_require_transform_feedback() was the only function left in piglit-transform-feedback.{c.h}. This patch moves it to piglit-util.c so that it won't get lonely. --- tests/util/CMakeLists.gl.txt |2 -

Re: [Piglit] [PATCH 3/3] Transform feedback: Move piglit_require_transform_feedback().

2012-07-03 Thread Paul Berry
: [PATCH v2 1/2] util: add primitive restart util routines) I don't have a strong feeling either way. I'll try to review your patches this morning. Thanks, -Jordan On Mon, Jul 2, 2012 at 2:57 PM, Paul Berry stereotype...@gmail.com wrote: With the transform feedback wrapper functions removed

[Piglit] [PATCH 2/2] msaa: Check for proper error for operations prohibited on MSAA buffers.

2012-07-16 Thread Paul Berry
From the GL 3.0 spec, section 4.3.3, in the documentation for CopyPixels(): An INVALID_OPERATION error will be generated if the object bound to READ_FRAMEBUFFER_BINDING is framebuffer complete and the value of SAMPLE_BUFFERS is greater than zero. The same applies to CopyTexImage...()

Re: [Piglit] [PATCH 01/12] msaa: Share visualize_image function by moving it to common.cpp

2012-07-17 Thread Paul Berry
) pass; -- 1.7.7.6 Regardless, this is: Reviewed-by: Paul Berry stereotype...@gmail.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 08/12] msaa: Add test to verify sample-alpha-to-one with single sample FBO

2012-07-17 Thread Paul Berry
); + + if (samples max_samples) + piglit_report_result(PIGLIT_SKIP); This check isn't necessary since samples == 0. With that fixed, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com + + ms_fbo_and_draw_buffers_setup(samples

Re: [Piglit] [PATCH 12/12] msaa: Add depth buffer testing to sample-alpha-to-coverage test case

2012-07-17 Thread Paul Berry
in both cases for this test? Other than that this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com int pattern_width = piglit_width / 2; int pattern_height = piglit_height / num_attachments; @@ -89,7 +103,7 @@ piglit_init(int argc, char **argv

Re: [Piglit] [PATCH V2 00/12] msaa: Add tests to verify sample-alpha-to-{one, coverage} with multiple draw-buffers

2012-07-17 Thread Paul Berry
in draw-buffer-common.cpp msaa: Add depth buffer testing to sample-alpha-to-coverage test case I made comments on patches 1, 8, and 12. The rest are Reviewed-by: Paul Berry stereotype...@gmail.com tests/all.tests| 41

Re: [Piglit] [PATCH] util: Warn and report SKIP when we get a window resize during an auto run.

2012-07-19 Thread Paul Berry
On 18 July 2012 17:20, Eric Anholt e...@anholt.net wrote: We've got a bunch of instances of this happening intermittently during runs with gnome-shell. Because our tests are not generally able to handle resizes, they would show up as spurious failures that are hard to reproduce. Instead,

Re: [Piglit] [PATCH] Test that fragment shader writes to render targets are properly ordered.

2012-07-30 Thread Paul Berry
On 30 July 2012 10:40, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: + for (uint i = 2u; i number_to_classify; ++i) {\n + if (number_to_classify % i == 0u)\n + factor_found = true;\n + }\n not breaking out of the loop

Re: [Piglit] [PATCH 2/2] msaa: Add test to verify alpha-to-coverage when nothing is bound to draw buffer zero

2012-08-15 Thread Paul Berry
On 23 July 2012 15:28, Anuj Phogat anuj.pho...@gmail.com wrote: When nothing is bound to draw buffer zero, GL_SAMPLE_ALPHA_TO_COVERAGE still needs to work properly. Note: Test case passes using NVIDIA's proprietary linux drivers but fails on Mesa i965 drivers. Reviewed-by: Paul Berry

Re: [Piglit] [PATCH 3/3] msaa: Add test to verify sample-alpha-to-one with dual source blending

2012-08-15 Thread Paul Berry
is disabled. With my suggested changes to patch 1/3, this test passes on my nVidia system, so this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests|6

Re: [Piglit] [PATCH 1/3] msaa: Make changes in shared code to accomodate dual-src-blending test cases

2012-08-16 Thread Paul Berry
: Make few changes to shared code to accomodate no-draw-buffer-zero test. In any case, this patch is: Reviewed-by: Paul Berry stereotype...@gmail.com } else if (buffer_to_test == GL_DEPTH_BUFFER_BIT) compute_expected_depth(); @@ -645,15 +746,16

[Piglit] [PATCH] msaa: Skip tests when samples GL_MAX_SAMPLES.

2012-08-20 Thread Paul Berry
A few of the recently-added MSAA tests were missing this check, causing bogus failures on i965/gen6 and i965/gen7 (which only support up to 4x MSAA and 8x MSAA, respectively). --- .../alpha-to-coverage-dual-src-blend.cpp |7 +++ .../alpha-to-one-dual-src-blend.cpp

Re: [Piglit] [PATCH] msaa: Avoid undefined behavior in visualize_image function

2012-08-22 Thread Paul Berry
(SRC1_COLOR, ONE_MINUS_SRC1_COLOR, SRC1_ALPHA or ONE_MINUS_SRC1_ALPHA) using fixed function will produce undefined results. Fix this by disabling the blending temporarily in visualize_image function. Looks good to me. Reviewed-by: Paul Berry stereotype...@gmail.com Reported-by: Vadim Girlin

Re: [Piglit] Plan for enabling more tests in concurrent mode

2012-08-24 Thread Paul Berry
On 23 August 2012 17:27, Chris Forbes chr...@ijw.co.nz wrote: Hello I sent in a pile of random patches some time ago working toward having more of the tests support -fbo. This is important on WMs which don't give you the size you ask for [pretty much any tiling WM]. Sorry I didn't notice

Re: [Piglit] Plan for enabling more tests in concurrent mode

2012-08-24 Thread Paul Berry
On 24 August 2012 17:28, Chris Forbes chr...@ijw.co.nz wrote: BTW, we are hoping to reduce the use of glutKeyboardFunc as much as possible because it gets in the use of Waffle, so if you happen to notice some opportunities to get rid of glutKeyboardFunc entirely (or at least take some

Re: [Piglit] Support for more tests to run with -fbo

2012-08-25 Thread Paul Berry
On 25 August 2012 01:12, Chris Forbes chr...@ijw.co.nz wrote: This is the first batch of patches which get rid of some stumbling-blocks for running tests with -fbo. Highlights: - gSwapBuffers - piglit_present_results - glutKeyboardFunc never in -auto - glutReshapeFunc - piglit_*_projection

Re: [Piglit] [PATCH 3/6] Tidy glsl-arb-fragment-coord-conventions

2012-08-26 Thread Paul Berry
On 25 August 2012 01:12, Chris Forbes chr...@ijw.co.nz wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz Functionally I'm fine with this patch. But it's hard to follow the diff because the patch contains both whitespace changes (fixing up indentation) and non-whitespace changes (changing

Re: [Piglit] [PATCH] Add shader_runner GLSL version specification via requirements section.

2012-08-27 Thread Paul Berry
On 24 August 2012 16:09, Stuart Abercrombie sabercrom...@chromium.orgwrote: The idea is to allow different GLSL versions for GL vs GL ES. There shouldn't be a functional change until shader scripts are altered too. Added ES GLSL version string parsing. I like where you're going with this.

Re: [Piglit] [PATCH] egl-util: Add call to piglit_dispatch_default_init()

2012-08-29 Thread Paul Berry
On 27 August 2012 18:35, Matt Turner matts...@gmail.com wrote: Fixes egl-nok-swap-region and makes egl-nok-texture-from-pixmap not crash (but still fails). Reviewed-by: Paul Berry stereotype...@gmail.com --- tests/egl/egl-util.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions

Re: [Piglit] [PATCH] Remove multiple shader files per section facility from shader_runner.

2012-08-30 Thread Paul Berry
On 29 August 2012 16:42, Stuart Abercrombie sabercrom...@chromium.orgwrote: This is part of the effort to make version handling more flexible for GLES. The patch has indentation errors that need to be fixed. Piglit uses tabs for indentation, and is intended to be viewed with a tab width of 8.

[Piglit] [PATCH 1/4] util: Add a piglit_probe_image_stencil() function.

2012-09-05 Thread Paul Berry
--- tests/util/piglit-util-gl-common.h |1 + tests/util/piglit-util-gl.c| 55 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/tests/util/piglit-util-gl-common.h b/tests/util/piglit-util-gl-common.h index d2e6b3e..c5e814c 100644

[Piglit] [PATCH 2/4] framebuffer-blit-levels: fix off-by-one error.

2012-09-05 Thread Paul Berry
Previously, the test made the erroneous assumption that if the size of a texture is 2^n, then that texture has n miplevels. This was wrong--the texture has n+1 miplevels, ranging in size from 2^n to 2^0. --- .../framebuffer-blit-levels.c |7 --- 1 files changed, 4

[Piglit] [PATCH 3/4] framebuffer-blit-levels: Make a function for uploading test data to texture.

2012-09-05 Thread Paul Berry
This will facilitate expanding the test to cover depthstencil textures, since the stencil data can't be uploaded into the texture using glTexImage2D--it will need to be drawn using stencil operations. --- .../framebuffer-blit-levels.c | 42 ++- 1 files

[Piglit] [PATCH 4/4] framebuffer-blit-levels: Test stencil buffers.

2012-09-05 Thread Paul Berry
This patch modifies framebuffer-blit-levels to test that blitting between miplevels of the stencil portion of a depth/stencil texture works properly. This is an important corner case for Mesa's i965 driver. Note that since stencil data can't be uploaded to a texture using glTexImage2D(), the

Re: [Piglit] [PATCH] Fix explicit attrib location tests layout-12|13.frag; add a new one.

2012-09-10 Thread Paul Berry
error. This patch also adds layout-14.frag, a test to check that index 0 is also a compile error. Reviewed-by: Paul Berry stereotype...@gmail.com --- .../1.20/compiler/layout-12.frag | 27 ++ .../1.20/compiler/layout-13.frag | 4

Re: [Piglit] [PATCH 2/2] Make shader_runner add a #version directive to shaders lacking one.

2012-09-11 Thread Paul Berry
, + glsl_req_version, glsl_version); piglit_report_result(PIGLIT_SKIP); } -- 1.7.7.3 Looks reasonable to me. Reviewed-by: Paul Berry stereotype...@gmail.com What was patch 1/2? I don't see it on the list

Re: [Piglit] [PATCH 2/2] Make shader_runner add a #version directive to shaders lacking one.

2012-09-14 Thread Paul Berry
On 12 September 2012 11:18, Stuart Abercrombie sabercrom...@chromium.orgwrote: This was a solitary patch. I think the git submit feature decided there were two on account of an old patch file in the same directory. Sorry for the confusion. Stuart On Mon, Sep 10, 2012 at 5:55 PM, Stuart

[Piglit] [PATCH v2 1/2] framebuffer-blit-levels: Make a function for uploading test data to texture.

2012-09-14 Thread Paul Berry
This will facilitate expanding the test to cover depthstencil textures, since the stencil data can't be uploaded into the texture directly using glTexImage2D--it will need to be converted into a combined depth/stencil format first. --- .../framebuffer-blit-levels.c | 42

[Piglit] [PATCH v2 2/2] framebuffer-blit-levels: Test stencil buffers.

2012-09-14 Thread Paul Berry
This patch modifies framebuffer-blit-levels to test that blitting between miplevels of the stencil portion of a depth/stencil texture works properly. This is an important corner case for Mesa's i965 driver. Note that stencil data can't be uploaded to a texture directly using glTexImage2D(). It

Re: [Piglit] [PATCH 2/2] Make shader_runner add a #version directive to shaders lacking one.

2012-09-17 Thread Paul Berry
On 14 September 2012 14:08, Stuart Abercrombie sabercrom...@chromium.orgwrote: I wondered about this case but it didn't come up with the subset I tested with -- glad you caught it. V2 looks good to me. It's hard to be rigorous about detecting #version directives without a real parser. This

[Piglit] [PATCH] shader_runner: Avoid lround(), which is unsupported on Windows.

2012-09-17 Thread Paul Berry
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55039 --- tests/shaders/shader_runner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 0aff387..650a228 100644 --- a/tests/shaders/shader_runner.c

[Piglit] [PATCH] Test that sRGB-related blits are allowed and do not do encoding/decoding.

2012-09-24 Thread Paul Berry
The behaviour specified by OpenGL for blits involving sRGB is self-contradictory--it is unclear whether blits should perform sRGB encoding/decoding, and if so, whether this encoding/decoding should be dependent upon the setting of the GL_FRAMEBUFFER_SRGB enable flag. Experiments with nVidia and

[Piglit] [PATCH v2] framebuffer-blit-levels: Test stencil buffers.

2012-10-03 Thread Paul Berry
This patch modifies framebuffer-blit-levels to test that blitting between miplevels of the stencil portion of a depth/stencil texture works properly. This is an important corner case for Mesa's i965 driver. Note that stencil data can't be uploaded to a texture directly using glTexImage2D(). It

Re: [Piglit] [PATCH] Test that sRGB-related blits are allowed and do not do encoding/decoding.

2012-10-10 Thread Paul Berry
On 10 October 2012 10:03, Ian Romanick i...@freedesktop.org wrote: On 09/24/2012 04:35 PM, Paul Berry wrote: The behaviour specified by OpenGL for blits involving sRGB is self-contradictory--it is unclear whether blits should perform sRGB encoding/decoding, and if so, whether this encoding

Re: [Piglit] [PATCH 1/2] glx: Replace extra mutexes with XInitThreads

2012-11-19 Thread Paul Berry
On 19 November 2012 13:26, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: From: Ian Romanick ian.d.roman...@intel.com To use multithreading with xlib, you're supposed to call XInitThreads before any other xlib call. Without this, xlib and GLX calls won't

[Piglit] [PATCH] time-elapsed: Spend time in the FS rather than do a lot of draws.

2012-11-19 Thread Paul Berry
The time-elapsed test needs to consume a lot of GPU time so that it can validate GPU time queries against elapsed wall-clock time. Previously we did this by painting the window thousands of times. That sometimes caused false failures due to the CPU time consumed in preparing the draw calls. This

Re: [Piglit] [PATCH] glsl-1.10: Verify that impossible GLSL versions are properly rejected

2012-11-30 Thread Paul Berry
(option, section) I think you need to add the line * glsl_version: 1.10 to the [config] section. With that fixed, this is: Reviewed-by: Paul Berry stereotype...@gmail.com --- I'm not sure this is the right place for this test script to live. It didn't seem to fit in any of the existing

[Piglit] [PATCH] Add a simple test of varying packing.

2012-12-11 Thread Paul Berry
--- tests/all.tests| 7 + tests/spec/glsl-1.10/execution/CMakeLists.txt | 1 + .../execution/varying-packing/CMakeLists.gl.txt| 14 + .../execution/varying-packing/CMakeLists.txt | 1 + .../glsl-1.10/execution/varying-packing/simple.c |

[Piglit] [PATCH] Transform feedback: test buffer size change after binding.

2012-12-17 Thread Paul Berry
--- tests/all.tests| 6 + .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 + tests/spec/ext_transform_feedback/change-size.c| 320 + 3 files changed, 327 insertions(+) create mode 100644

Re: [Piglit] [PATCH] piglit-dispatch: Update enumext.spec from the registry

2012-12-17 Thread Paul Berry
. Support is added to piglit_get_gl_enum_name for GL_SHADER_BINARY_FORMATS which was previously missing from our enumext.spec. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Paul Berry stereotype...@gmail.com This looks correct to me. Reviewed-by: Paul Berry stereotype...@gmail.com

Re: [Piglit] [PATCH] Transform feedback: test buffer size change after binding.

2012-12-18 Thread Paul Berry
On 17 December 2012 10:17, Paul Berry stereotype...@gmail.com wrote: --- tests/all.tests| 6 + .../spec/ext_transform_feedback/CMakeLists.gl.txt | 1 + tests/spec/ext_transform_feedback/change-size.c| 320 + 3 files changed

[Piglit] [PATCH 2/2] Test that varying packing can pack floats, ints, and uints together.

2012-12-19 Thread Paul Berry
--- .../varying-packing-mixed-types.shader_test| 60 ++ 1 file changed, 60 insertions(+) create mode 100644 tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test diff --git a/tests/spec/glsl-1.30/execution/varying-packing-mixed-types.shader_test

Re: [Piglit] [PATCH 2/3] util: Add compressed representations of grayscale images.

2013-01-02 Thread Paul Berry
On 2 January 2013 07:39, Brian Paul bri...@vmware.com wrote: I think the filename could be a little more descriptive. Maybe piglit-util-compressed-grays.h Sure, I can go along with that. ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] Deleting ~20% of glean/no more directory spam

2013-01-02 Thread Paul Berry
On 31 December 2012 18:40, Kenneth Graunke kenn...@whitecape.org wrote: Now that Piglit's import of Glean is beginning to diverge from Glean proper, my hope is that someday people will port over various tests to the native Piglit framework, then delete the equivalent Glean code. A bit more

Re: [Piglit] [PATCH 2/3] util: Add compressed representations of grayscale images.

2013-01-04 Thread Paul Berry
On 3 January 2013 15:11, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: This patch adds compressed representations of uniform grayscale images maybe This patch adds compressed representations of uniform grayscale blocks -- I was thinking of these as images

Re: [Piglit] [PATCH 3/3] Add tests for glCompressedTex{Image, SubImage}3D().

2013-01-04 Thread Paul Berry
On 3 January 2013 14:39, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: +static const char vs_text[] = + #version GLSL_VERSION \n Maybe fold GLSL_VERSION into the ifdefs instead of ifdeffing it above? Sure, I can go along

Re: [Piglit] [PATCH 2/8] arb_texture_multisample: new minmax test

2013-01-07 Thread Paul Berry
On 5 January 2013 01:07, Chris Forbes chr...@ijw.co.nz wrote: Verifies new minimum maximums in ARB_texture_multisample: GL_MAX_COLOR_TEXTURE_SAMPLES = 1 GL_MAX_DEPTH_TEXTURE_SAMPLES = 1 GL_MAX_INTEGER_SAMPLES = 1 GL_MAX_SAMPLE_MASK_WORDS = 1 Signed-off-by: Chris Forbes chr...@ijw.co.nz

Re: [Piglit] [PATCH 3/8] arb_texture_multisample: new test for fb configs

2013-01-07 Thread Paul Berry
On 5 January 2013 01:07, Chris Forbes chr...@ijw.co.nz wrote: This tests FBO setup with various combinations of multisample textures and `classic` multisample renderbuffers, and for each, checks: - That the renderbuffers or textures can be created - Completeness status If the configuration

Re: [Piglit] [PATCH 8/8] rude hack: use smaller formats in texturing tests.

2013-01-07 Thread Paul Berry
On 5 January 2013 01:07, Chris Forbes chr...@ijw.co.nz wrote: RGBA32I, RGBA32UI, and RGBA32F are huge and unsupported for multisample textures on at least Gen6 i965. This shouldn't be committed as-is, but it allowed for testing of multisample samplers with the generic textureSize() test.

Re: [Piglit] glsl-render-after-bad-attach.c not built

2013-01-09 Thread Paul Berry
On 9 January 2013 09:30, Brian Paul bri...@vmware.com wrote: I happened to notice that the program tests/spec/glsl-1.10/** execution/glsl-render-after-**bad-attach.c which Eric added last April (b859d0c) isn't getting built. Adding a piglit_add_executable() line in the directory's

  1   2   3   4   5   >