Re: [Piglit] [Mesa-dev] [RFC] Extract API-dependent code from utilities

2012-06-18 Thread Tom Stellard
cc piglit@lists.freedesktop.org Hi Blaž, I forgot to mention to that there is a dedicated piglit mailing list. I'm sure everyone subscribed to the piglit list is also subscribed to mesa-dev, but sending the patches to the piglit list will make it easier for people with mail filters. -Tom On

Re: [Piglit] [PATCH] Make piglitutil library API-independent

2012-06-22 Thread Tom Stellard
On Fri, Jun 22, 2012 at 02:25:57AM +0200, Blaž Tomažič wrote: Currently all utility libraries (piglitutil, piglitutil_gles1, piglitutil_gles2) have built-in the same API-independent code and the code from piglit-util.{c,h} contains OpenGL functionality. To share more code across different APIs

Re: [Piglit] Test to exercise a race with r600-llvm

2012-08-20 Thread Tom Stellard
file. Otherwise: Reviewed-by: Tom Stellard thomas.stell...@amd.com --- tests/glx/CMakeLists.gl.txt| 2 + tests/glx/glx-multithread-shader-compile.c | 117 + 2 files changed, 119 insertions(+) create mode 100644 tests/glx/glx-multithread

Re: [Piglit] [PATCH] Add OpenCL support

2012-09-04 Thread Tom Stellard
On Thu, Aug 30, 2012 at 02:02:55AM +0200, Blaž Tomažič wrote: I have implemented an OpenCL testing framework for Piglit which I would like to merge upstream. Here is a summary of its functionality: The framework implements OpenCL utilities which are used for quicker and

Re: [Piglit] [PATCH] Add OpenCL support

2012-09-12 Thread Tom Stellard
On Thu, Sep 06, 2012 at 10:44:18PM +0200, Blaž Tomažič wrote: On čet, 2012-09-06 at 09:16 -0700, Eric Anholt wrote: Blaž Tomažič blaz.toma...@gmail.com writes: On tor, 2012-09-04 at 07:14 -0700, Tom Stellard wrote: Some of the cl-util files contain some really long lines, especially

Re: [Piglit] [PATCH] Add OpenCL support

2012-09-12 Thread Tom Stellard
On Wed, Sep 12, 2012 at 09:01:43AM -0700, Kenneth Graunke wrote: On 09/12/2012 07:51 AM, Tom Stellard wrote: On Thu, Sep 06, 2012 at 10:44:18PM +0200, Blaž Tomažič wrote: On čet, 2012-09-06 at 09:16 -0700, Eric Anholt wrote: Blaž Tomažič blaz.toma...@gmail.com writes: On tor, 2012-09-04

[Piglit] [PATCH 1/6] cl: Add scalar-load-uchar test

2012-10-03 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests| 1 + tests/cl/program/execute/scalar-load-uchar.cl | 15 +++ 2 files changed, 16 insertions(+) create mode 100644 tests/cl/program/execute/scalar-load-uchar.cl diff --git a/tests

[Piglit] [PATCH 4/6] cl: Add gegl rgb-gamma-u8-to-ragabaf test

2012-10-03 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests | 1 + .../execute/gegl-rgb-gamma-u8-to-ragabaf.cl| 68 ++ 2 files changed, 69 insertions(+) create mode 100644 tests/cl/program/execute/gegl-rgb-gamma-u8-to-ragabaf.cl

[Piglit] [PATCH 5/6] cl: Add gegl fir-get-mean-component-1D-CL.cl

2012-10-03 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests | 1 + .../execute/gegl-fir-get-mean-component-1D-CL.cl | 58 ++ 2 files changed, 59 insertions(+) create mode 100644 tests/cl/program/execute/gegl-fir-get-mean-component-1D

[Piglit] [PATCH 6/6] cl: Add vectore-store-int4 test

2012-10-03 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests| 1 + tests/cl/program/execute/vector-store-int4.cl | 16 2 files changed, 17 insertions(+) create mode 100644 tests/cl/program/execute/vector-store-int4.cl diff --git a/tests

Re: [Piglit] [PATCH] Add OpenCL test for building program with build options.

2012-10-04 Thread Tom Stellard
On Thu, Oct 04, 2012 at 12:43:08PM +0200, Blaž Tomažič wrote: Ah, I already replied, didn't see this email. On sre, 2012-10-03 at 22:39 -0400, Tom Stellard wrote: Hi, Thanks for the patch. Sorry for the delay in responding. This looks pretty good to me, just one small comment

Re: [Piglit] Add OpenCL test for building program with build options v2

2012-10-11 Thread Tom Stellard
for -Werror [PATCH 10/11] Add CL build test for invalid CL version declarations [PATCH 11/11] Remove TODO item from build-program.c These look good to me. Reviewed-by: Tom Stellard thomas.stell...@amd.com ___ Piglit mailing list Piglit

Re: [Piglit] Add OpenCL test for building program with build options v2

2012-10-16 Thread Tom Stellard
On Fri, Oct 12, 2012 at 04:49:11PM -0500, Aaron Watry wrote: On Thu, Oct 11, 2012 at 9:53 PM, Tom Stellard t...@stellard.net wrote: On Wed, Oct 10, 2012 at 06:44:01PM -0500, Aaron Watry wrote: I've created a reasonable number of tests of clBuildProgram based on the OpenCL 1.1 spec

Re: [Piglit] [PATCH] Replace CL kernel names to not use C++ reserved words.

2012-11-26 Thread Tom Stellard
On Sun, Nov 25, 2012 at 09:36:42PM -0600, Aaron Watry wrote: These tests were failing to compile on Nvidia CL runtime on *NIX. I can't find anything in the OpenCL spec that says these function names are illegal. This looks like a bug in the NVIDIA implementation and should be fixed by them.

[Piglit] [PATCH] cl: Automatically run any tests in the program directory

2012-11-27 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com Just like what is done for the GL shader_runner tests --- tests/all_cl.tests | 75 +- 1 file changed, 17 insertions(+), 58 deletions(-) diff --git a/tests/all_cl.tests b/tests/all_cl.tests index

Re: [Piglit] [PATCH] Remove clc_version_min requirement on scalar-load-[float|uchar].cl tests

2012-11-27 Thread Tom Stellard
to the uchar file so that it's consistent with the float tests. Reviewed-by: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/scalar-load-float.cl |1 - tests/cl/program/execute/scalar-load-uchar.cl | 26 ++--- 2 files changed, 23 insertions(+), 4

Re: [Piglit] [PATCH] Remove clc_version_min from gegl-rgb-gamma-u8-to-ragabaf.cl

2012-11-27 Thread Tom Stellard
On Mon, Nov 26, 2012 at 08:38:56PM -0600, Aaron Watry wrote: This is another test that doesn't require CL C version 1.1, but runs fine on a CL C 1.0 capable device. Tested on Linux with Nvidia CL 1.1 run-time on a GF9400M (which supports CL C 1.0). Reviewed-by: Tom Stellard thomas.stell

Re: [Piglit] [PATCH 0/2] Replace CL kernel names to not use C++ reserved words v2

2012-11-28 Thread Tom Stellard
-by: Tom Stellard thomas.stell...@amd.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH] Don't attempt to execute vector-arithmetic-[floating|integer].cl include files.

2012-12-03 Thread Tom Stellard
previously only included in vector-arithmetic-*.program_test, never executed directly. They are missing a config section, and are guaranteed to fail on their own. Reviewed-by: Tom Stellard thomas.stell...@amd.com --- .../execute/vector-arithmetic-float4.program_test |2 +- .../program

Re: [Piglit] [PATCH] Fix warnings-as-errors CL test.

2012-12-03 Thread Tom Stellard
and causes the program to fail to build when the -Werror build option is present. Reviewed-by: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/build/fail/warnings-as-errors.cl |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cl/program/build/fail/warnings-as-errors.cl

Re: [Piglit] [PATCH] Replace scalar-load-[float|uchar] with more comprehensive tests.

2012-12-04 Thread Tom Stellard
I'm leaving out half/double data types. #pragmas usually go in the source file right? Could you do something like: #pragma PRAGMA_DEF and then add -DPRAGMA_DEF to the build flags. This patch looks good and should really help increase the coverage. Reviewed-by: Tom Stellard thomas.stell

[Piglit] [PATCH 2/4] util: Add piglit_result_to_string() helper

2012-12-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/util/piglit-util.c | 12 tests/util/piglit-util.h | 1 + 2 files changed, 13 insertions(+) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index c061def..72bba21 100644 --- a/tests/util/piglit-util.c +++ b/tests

[Piglit] [PATCH 1/4] piglt: Add support for subtests

2012-12-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com Subtests allow a test to produce more than one result. This is useful for tests where it may be convenient to combine several somewhat unrelated tests into a single program. For example, a cl test like: kernel void test(TYPE *out, TYPE

[Piglit] [PATCH 3/4] cl: Remove soon to be illegal characters from test names

2012-12-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/scalar-arithmetic-char.cl | 18 +++ .../cl/program/execute/scalar-arithmetic-float.cl | 26 +++--- tests/cl/program/execute/scalar-arithmetic-int.cl | 18 +++ tests/cl/program

[Piglit] [PATCH 4/4] cl: Have program-tester report subtest results

2012-12-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/program-tester.c | 38 -- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index 645691e..ec7fc91 100644

Re: [Piglit] [PATCH 1/4] piglt: Add support for subtests

2012-12-06 Thread Tom Stellard
On Wed, Dec 05, 2012 at 11:27:06AM -0800, Eric Anholt wrote: Tom Stellard t...@stellard.net writes: From: Tom Stellard thomas.stell...@amd.com Subtests allow a test to produce more than one result. This is useful for tests where it may be convenient to combine several somewhat

[Piglit] [PATCH 2/4] piglt: Add support for subtests v2

2012-12-06 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com Subtests allow a test to produce more than one result. This is useful for tests where it may be convenient to combine several somewhat unrelated tests into a single program. For example, a cl test like: kernel void test(TYPE *out, TYPE

[Piglit] [PATCH 1/4] util: Add piglit_result_to_string() helper

2012-12-06 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/util/piglit-util.c | 21 + tests/util/piglit-util.h | 1 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index c061def..98e0800 100644 --- a/tests/util

[Piglit] [PATCH 3/4] cl: Remove soon to be illegal characters from test names

2012-12-06 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/scalar-arithmetic-char.cl | 18 +++ .../cl/program/execute/scalar-arithmetic-float.cl | 26 +++--- tests/cl/program/execute/scalar-arithmetic-int.cl | 18 +++ tests/cl/program

[Piglit] [PATCH 4/4] cl: Have program-tester report subtest results v2

2012-12-06 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com v2: -Print each subtest result on its own line --- tests/cl/program/program-tester.c | 40 +++ 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program

[Piglit] [PATCH] util: Add piglit_result_to_string() helper v2

2012-12-14 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com v2: - Simplify piglit_report_result() --- tests/util/piglit-util.c | 36 ++-- tests/util/piglit-util.h | 1 + 2 files changed, 23 insertions(+), 14 deletions(-) diff --git a/tests/util/piglit-util.c b/tests/util

[Piglit] [PATCH] cl: Add tests for arrays declared on the stack (private memory)

2013-01-22 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/i32-stack-array.cl| 256 + tests/cl/program/execute/multiple-stack-objects.cl | 25 ++ tests/cl/program/execute/v3f32-stack-array.cl | 32 +++ tests/cl/program/execute/v3i32-stack-array.cl

Re: [Piglit] [PATCH] Add initial python built-in test generator

2013-02-05 Thread Tom Stellard
On Mon, Feb 04, 2013 at 01:35:16PM -0600, Aaron Watry wrote: Initial version only generates tests for the char data type. This looks like a good first step, I am impressed with how thorough the tests are. I think it is important to try to generate as much stuff as possible, so whenever there is

Re: [Piglit] [PATCH] Add initial python built-in test generator

2013-02-05 Thread Tom Stellard
On Tue, Feb 05, 2013 at 11:26:38AM -0600, Aaron Watry wrote: On Tue, Feb 5, 2013 at 9:32 AM, Tom Stellard t...@stellard.net wrote: On Mon, Feb 04, 2013 at 01:35:16PM -0600, Aaron Watry wrote: Initial version only generates tests for the char data type. This looks like a good first step

[Piglit] [PATCH] util-cl: Fix error output from piglit_cl_probe_floating()

2013-02-07 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com - Print 16 decimal places of floating point values - Fix the hex formatting --- tests/util/piglit-util-cl.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util-cl.c b/tests/util/piglit-util-cl.c index 8745b89

[Piglit] [PATCH] util-cl: Fix error output from piglit_cl_probe_floating()

2013-02-07 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com - Print 16 decimal places of floating point values - Fix the hex formatting --- I sent out the wrong patch out last time. tests/util/piglit-util-cl.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit

[Piglit] [PATCH] cl: Add % to the list of illegal characters in test names

2013-02-11 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com % was being interpreted as a format string in some cases --- tests/cl/program/execute/scalar-arithmetic-int.cl | 18 +- tests/cl/program/execute/scalar-arithmetic-long.cl| 18 +- tests/cl/program/execute/scalar

Re: [Piglit] [PATCH 2/2] Plug the built-in test generator to the CL test list.

2013-03-11 Thread Tom Stellard
On Fri, Mar 08, 2013 at 10:04:38PM -0600, Aaron Watry wrote: This isn't necessarily the prettiest way to do it, but it gets the job done. --- tests/all_cl.tests | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/tests/all_cl.tests b/tests/all_cl.tests

Re: [Piglit] [PATCH 1/2] Add a python generator for integer builtin function tests

2013-03-11 Thread Tom Stellard
Sizes tested: Scalar, Vector sizes 2/4/8/16 This looks great, nice job! Now we'll actually need to implement these so the tests can pass ;) Reviewed-by: Tom Stellard thomas.stell...@amd.com --- .../builtin_functions/generate-int-builtins.py | 869 1 files changed

Re: [Piglit] [PATCH] CL Builtins: Fix sign-extension bug in rotate

2013-04-01 Thread Tom Stellard
On Sat, Mar 23, 2013 at 12:06:53PM -0500, Aaron Watry wrote: When rotating a negative number right, sign extension was producing the wrong expected result. Reviewed-by: Tom Stellard thomas.stell...@amd.com --- generated_tests/generate-cl-int-builtins.py | 17 - 1 file

Re: [Piglit] [PATCH] CL Builtin: Remove an invalid mad24 test

2013-04-01 Thread Tom Stellard
-by: Tom Stellard thomas.stell...@amd.com generated_tests/generate-cl-int-builtins.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/generated_tests/generate-cl-int-builtins.py b/generated_tests/generate-cl-int-builtins.py index 2460594..1936454 100755

[Piglit] [PATCH 1/3] cl: Add test for sha256 Ch function

2013-04-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/sha256-Ch.cl | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 tests/cl/program/execute/sha256-Ch.cl diff --git a/tests/cl/program/execute/sha256-Ch.cl b/tests/cl/program

[Piglit] [PATCH 2/3] cl: Add test for get_group_id()

2013-04-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/get-group-id.cl | 71 1 file changed, 71 insertions(+) create mode 100644 tests/cl/program/execute/get-group-id.cl diff --git a/tests/cl/program/execute/get-group-id.cl b/tests/cl/program

[Piglit] [PATCH 3/3] cl: Add test for get_local_size()

2013-04-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/get-local-size.cl | 44 ++ 1 file changed, 44 insertions(+) create mode 100644 tests/cl/program/execute/get-local-size.cl diff --git a/tests/cl/program/execute/get-local-size.cl b/tests/cl

Re: [Piglit] [PATCH] cl: Fix char/short test names

2013-04-19 Thread Tom Stellard
On Thu, Apr 11, 2013 at 06:11:31PM -0500, Aaron Watry wrote: Several tests still had '%' in the test names, which Tom made an illegal character a ways back. Reviewed-by: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/scalar-arithmetic-char.cl | 18

Re: [Piglit] [PATCH] Add test for concurrent shader compiler use. v3

2013-04-24 Thread Tom Stellard
to test race conditions of the shader compiler. v3: (Tom Stellard) - Report pass at the end of the tests - Add as a concurrent test v4: (Mathias Froehlich) - Fix comment style Signed-off-by: Mathias Froehlich mathias.froehl...@web.de Reviewed-by: Tom Stellard thomas.stell

Re: [Piglit] [PATCH] Modify the FindOpenCL.make to add the CL lib name

2013-05-15 Thread Tom Stellard
On Wed, May 15, 2013 at 02:57:53PM +0800, junyan...@linux.intel.com wrote: From: Junyan He junyan...@linux.intel.com Some OpenCL lib's name is not libOpenCL.so. Some thing like libCL.so, libcl.so may exist, and in these cases the check failed. Add the names to fix this problem.

Re: [Piglit] [PATCH 2/2] Add one test case for OpenCL's switch cause

2013-05-29 Thread Tom Stellard
On Mon, May 27, 2013 at 03:12:51PM +0800, junyan...@linux.intel.com wrote: From: Junyan He junyan...@linux.intel.com Add a switch case test kernel for OpenCL Signed-off-by: Junyan He junyan...@linux.intel.com I've pushed this patch, thanks! Was there supposed to be a patch 1/2 as well?

[Piglit] [PATCH] cl: Add a test for the phatk kernel used for bitcoin mining

2013-06-05 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests | 3 +- tests/cl/program/CMakeLists.cl.txt | 1 + tests/cl/program/bitcoin-phatk.c | 542 + 3 files changed, 545 insertions(+), 1 deletion(-) create mode 100644 tests/cl

[Piglit] [PATCH] cl: Add local memory test

2013-06-12 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/local-memory.cl | 81 1 file changed, 81 insertions(+) create mode 100644 tests/cl/program/execute/local-memory.cl diff --git a/tests/cl/program/execute/local-memory.cl b/tests/cl/program

Re: [Piglit] [PATCH] cl: Add local memory test

2013-06-14 Thread Tom Stellard
max sizes added: Reviewed-by: Aaron Watry awa...@gmail.com On Wed, Jun 12, 2013 at 7:39 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/local-memory.cl | 81 1 file changed, 81

[Piglit] [PATCH 1/2] cl: Add build test for -D GENTYPE=int

2013-06-14 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/build/define-GENTYPE.cl | 39 1 file changed, 39 insertions(+) create mode 100644 tests/cl/program/build/define-GENTYPE.cl diff --git a/tests/cl/program/build/define-GENTYPE.cl b/tests/cl/program

Re: [Piglit] [PATCH] CL: Add v2i32 stack and constant load tests

2013-06-20 Thread Tom Stellard
On Thu, Jun 20, 2013 at 04:51:04PM -0500, Aaron Watry wrote: Based on the v3i32-stack.cl test but for the int2 data type. Also tests that v2i32 load from constant address space with a store to the global address space works correctly. Signed-off-by: Aaron Watry awa...@gmail.com ---

[Piglit] Piglit 'changes' page no longer showing all tests that are 'Not Run'

2013-07-30 Thread Tom Stellard
Hi, I recall this being discussed on the list a few weeks ago, but I can't find the email now. There was a recent change to piglit which caused tests that were 'Not Run' to be excluded from the 'changes' page. This is a problem for tests with subtests, because if the parent test crashes, the

Re: [Piglit] [PATCH 2/2] cl: Add generated tests for global and local stores

2013-08-01 Thread Tom Stellard
On Wed, Jul 31, 2013 at 11:37:16PM -0700, Dylan Baker wrote: Hi Dylan, Thanks for your comments. I have some python comments for you, they're mainly style type comments, but some of them should help your code readability a lot. On Wed, Jul 31, 2013 at 7:16 PM, Tom Stellard t

[Piglit] [PATCH] cl: Add tests for local memory atomic_inc and atomic_add builtins

2013-08-20 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests | 1 + .../execute/builtin/atomic/atomic_add-local.cl | 61 ++ .../execute/builtin/atomic/atomic_inc-local.cl | 58 3 files changed, 120 insertions

Re: [Piglit] [PATCH] cl: From API clRetain* tests, removed attempt to release already released and destroyed objects

2013-08-21 Thread Tom Stellard
On Wed, Aug 21, 2013 at 04:16:47PM +0300, Ville Korhonen wrote: All retain/release API tests try to test behaviour when trying to release already released and destroyed object. OpenCL 1.2 Spec says (considering clReleaseMemObject: After the memobj reference count becomes zero and commands

[Piglit] Regression with eeec306bc2197a2fc0eeb064462a1244d39c16fa framework: don't report failed cases as PASS

2013-08-26 Thread Tom Stellard
Hi Homer, This commit introduces a regression in piglit for reporting subtest results. Now if one subtests fails, all subtests report failure, which is incorrect. I've looked through the changes in this commit, and I don't understand which change introduced the regression, could you take a

Re: [Piglit] Regression with eeec306bc2197a2fc0eeb064462a1244d39c16fa framework: don't report failed cases as PASS

2013-08-26 Thread Tom Stellard
it should be reverted, because it completed defeats the purpose of having subtests. -Tom Dylan On Monday 26 August 2013 10:09:10 Tom Stellard wrote: Hi Homer, This commit introduces a regression in piglit for reporting subtest results. Now if one subtests fails, all subtests report

[Piglit] [PATCH] cl: Add cl-custom-flush-after-enqueue-kernel

2013-08-26 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This test checks that clEnqueueReadBuffer() does not begin copying before a kernel referencing its buffer has finished executing. --- tests/all_cl.tests | 1 + tests/cl/custom/CMakeLists.cl.txt| 1 + tests/cl

[Piglit] [PATCH] cl: Add cl-custom-flush-after-enqueue-kernel v2

2013-08-26 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com v2: - Add the license --- tests/all_cl.tests | 1 + tests/cl/custom/CMakeLists.cl.txt| 1 + tests/cl/custom/flush-after-enqueue-kernel.c | 118 +++ 3 files changed, 120 insertions

Re: [Piglit] [PATCH] cl: From API clRetain* tests, removed attempt to release already released and destroyed objects

2013-08-26 Thread Tom Stellard
. And lastly I make own patch for create-context. Was this patch sent in a different email? I don't see it. -Tom Quoting Tom Stellard t...@stellard.net: On Wed, Aug 21, 2013 at 04:16:47PM +0300, Ville Korhonen wrote: All retain/release API tests try to test behaviour when trying to release

Re: [Piglit] [PATCH] cl: From API clRetain* tests, removed attempt to release already released and destroyed objects

2013-08-29 Thread Tom Stellard
On Mon, Aug 26, 2013 at 06:35:48PM -0700, Tom Stellard wrote: On Thu, Aug 22, 2013 at 01:26:04PM +0300, Ville Korhonen wrote: Problem with releasing already released objects originates from ICD Loader, which requires that object is alive when calling OpenCL host functions. Khronos ICD

Re: [Piglit] [PATCH v2] core.py: fix subtest json reporting

2013-08-29 Thread Tom Stellard
On Wed, Aug 28, 2013 at 12:35:02PM -0700, Dylan Baker wrote: Previously every subtest wrote an entry in the file as a full test, this is a bug since the fake-fulltest (actually subtest) reported with the full test value, not it's own value. This patch changes the behvaior so that a test with

Re: [Piglit] [PATCH 1/2] CL: Add atomic_add/inc uint threaded tests

2013-09-05 Thread Tom Stellard
On Wed, Sep 04, 2013 at 05:23:25PM -0500, Aaron Watry wrote: --- For the series: Reviewed-by: Tom Stellard thomas.stell...@amd.com tests/cl/program/execute/builtin/atomic/atomic_add-local.cl | 9 + tests/cl/program/execute/builtin/atomic/atomic_inc-local.cl | 9 + 2 files

Re: [Piglit] [PATCH v2] core.py: fix subtest json reporting

2013-09-05 Thread Tom Stellard
reports all the subtests as 'fail'. I've attached an example results file in case that helps. -Tom On Thursday 29 August 2013 17:54:57 Eric Anholt wrote: Tom Stellard t...@stellard.net writes: On Wed, Aug 28, 2013 at 12:35:02PM -0700, Dylan Baker wrote: Previously every subtest wrote

Re: [Piglit] [PATCH] cl: fixed test create-context to test what it was supposed to test

2013-09-06 Thread Tom Stellard
On Fri, Aug 23, 2013 at 09:50:16AM +0300, Ville Korhonen wrote: fixed function parameters to match description. I've pushed this patch, but I'm having trouble applying your v2 retain/release patch: http://lists.freedesktop.org/archives/piglit/2013-September/007158.html I think it was mangled

Re: [Piglit] [PATCH v3] cl: From API clRetain* tests, removed attempt to release already released and destroyed objects

2013-09-11 Thread Tom Stellard
On Tue, Sep 10, 2013 at 01:27:15PM +0300, Ville Korhonen wrote: resending previous patch that got messed up. I have pushed this patch, thanks! -Tom --- tests/cl/api/create-context-from-type.c | 39 +- tests/cl/api/get-device-ids.c | 15

[Piglit] [PATCH 1/4] cl: Move common code from generate-cl-int-builtins.py into its own module

2013-09-12 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- generated_tests/genclbuiltins.py| 395 generated_tests/generate-cl-int-builtins.py | 383 +-- 2 files changed, 402 insertions(+), 376 deletions(-) create mode 100644 generated_tests

[Piglit] [PATCH 3/4] cl: Add a python script for generating tests for math builtins

2013-09-12 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This includes a test for the nextafter builtin. --- generated_tests/CMakeLists.txt | 4 ++ generated_tests/genclbuiltins.py | 2 +- generated_tests/generate-cl-math-builtins.py | 66 tests

[Piglit] [PATCH 2/4] cl-program-test: Add support for parsing float values in scientific notation

2013-09-12 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/program-tester.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index a153f50..be6bc20 100644 --- a/tests/cl/program/program-tester.c +++ b

[Piglit] [PATCH] cl: Add a test for the sign() builtin

2013-09-12 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- This patch depends on my earlier series which creates a new python script for gnerating math builtin tests. generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[Piglit] [PATCH 4/7] cl-program-tester: Rename test_arg::size to test_arg::size_in_mem

2013-09-30 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com The value being stored in this field is actually the size of the argument if it were to be stored in memory (for a type like int3, its size is 12 bytes, but its size in memory is 16 bytes per the OpenCL spec). --- tests/cl/program/program-tester.c | 30

[Piglit] [PATCH 5/7] cl-progam-tester: Pass correct size to piglit_cl_set_kernel_arg()

2013-09-30 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/program-tester.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index ea16c81..557dc4b 100644 --- a/tests/cl/program/program-tester.c +++ b

[Piglit] [PATCH 7/7] cl-program-tester: Add gentype option to config section

2013-09-30 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com The gentype option allows a test file to specify a list of types and vector sizes to be used for each test. cl-program-tester will run each test once for each comibnation of type and vector size. This makes it possible to write a generic test that can

[Piglit] [PATCH 6/7] cl-program-tester: Defer parsing of input/output values until test execution

2013-09-30 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This will make it possible to write tests using generic types. --- tests/cl/program/program-tester.c | 61 +-- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/tests/cl/program/program-tester.c b/tests

[Piglit] [PATCH] cl: Add test opencv-merge-hist

2013-10-11 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/opencv-merge-hist.cl | 97 +++ 1 file changed, 97 insertions(+) create mode 100644 tests/cl/program/execute/opencv-merge-hist.cl diff --git a/tests/cl/program/execute/opencv-merge-hist.cl b/tests

Re: [Piglit] [PATCH 1/7] cl-program-tester: Use more appropriate member names for struct test_arg

2013-10-16 Thread Tom Stellard
On Mon, Oct 14, 2013 at 05:06:18PM -0500, Aaron Watry wrote: On Mon, Sep 30, 2013 at 9:47 AM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com cl_size has been renamed to vec_elements and cl_mem_size has been renamed to vec_mem_elements. This use of size

[Piglit] [PATCH] cl: Add opencv-calLUT test

2013-10-16 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/execute/opencv-calLUT.cl | 88 +++ 1 file changed, 88 insertions(+) create mode 100644 tests/cl/program/execute/opencv-calLUT.cl diff --git a/tests/cl/program/execute/opencv-calLUT.cl b/tests/cl

Re: [Piglit] [PATCH] cl: Add sqrt tests

2013-10-25 Thread Tom Stellard
satisfy the ulp requirements for the spec. With these changes, the patch is: Reviewed-by: Tom Stellard thomas.stell...@amd.com +] } } -- 1.8.3.2 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org

Re: [Piglit] [PATCH] cl: Add complex real world test: Pyrit

2013-10-29 Thread Tom Stellard
On Fri, Oct 18, 2013 at 12:48:16AM +0200, Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: - Computation of the second round of a HMAC (using SHA-1). - A calculation of the PMK key. Both tests use test vectors from IEEE

Re: [Piglit] [PATCH] cl: Add complex real world test: Pyrit

2013-10-29 Thread Tom Stellard
On Tue, Oct 29, 2013 at 08:02:51PM +0100, Peter Wu wrote: On Tuesday 29 October 2013 11:08:58 Tom Stellard wrote: On Fri, Oct 18, 2013 at 12:48:16AM +0200, Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects

Re: [Piglit] [PATCHv2] cl: Add complex real world test: Pyrit

2013-10-29 Thread Tom Stellard
On Tue, Oct 29, 2013 at 04:42:19PM -0700, Dylan Baker wrote: On Tuesday, October 29, 2013 10:35:42 PM Peter Wu wrote: Pyrit computes pairwise master keys (PMKs) to attack WPA/WPA2-PSK. This test verifies two aspects: - Computation of the second round of a HMAC (using SHA-1). - A

[Piglit] [PATCH] cl: Fix build on systems where clock_gettime is only avaiable in librt

2013-10-30 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com clock_gettime is available in glibc 2.17 and newer, but anyone using an older version of glibc must link against librt. --- tests/cl/CMakeLists.txt | 4 1 file changed, 4 insertions(+) diff --git a/tests/cl/CMakeLists.txt b/tests/cl/CMakeLists.txt

Re: [Piglit] [PATCH 2/2] The return code of the fucntion isnan is -1 for vector types.

2013-10-30 Thread Tom Stellard
On Wed, Oct 30, 2013 at 04:01:10PM +0800, Yi Sun wrote: According to the OpenCL spec version 1.2/1.1 chacpter 6.12.6: The functions isequal, isnotequal, isgreater, isgreaterequal, isless, islessequal, islessgreater, isfinite, isinf, isnan, isnormal, isordered, isunordered and signbit

Re: [Piglit] [PATCH 2/2 v2] The return code of the function isnan is -1 for vector types.

2013-10-31 Thread Tom Stellard
On Fri, Nov 01, 2013 at 12:20:47AM +0800, Yi Sun wrote: According to the OpenCL spec version 1.2/1.1 chacpter 6.12.6: The functions isequal, isnotequal, isgreater, isgreaterequal, isless, islessequal, islessgreater, isfinite, isinf, isnan, isnormal, isordered, isunordered and signbit described

Re: [Piglit] Fix subtests

2013-11-12 Thread Tom Stellard
Hi Dylan, Overall these look pretty good, just a few issues: 'Not Run' - pass changes are not showing up in the 'changes' page. You can reproduce this with the attached result files by passing them to piglit-summary-html.py in this order: get-num-groups-exit-early get-num-groups-good

[Piglit] Integrating external test suites with piglit

2013-11-13 Thread Tom Stellard
Hi, I've been doing a lot of testing lately with the OpenCV library (http://opencv.org). It has its own gtest based regression test suite, and so far I've been trying to port some of these tests over to piglit. Unfortunately, this has been very difficult and time consuming. Mostly, because it

Re: [Piglit] [PATCH v2 1/2] summary.py: Treat subtests as groups

2013-11-13 Thread Tom Stellard
this they will not appear in changes, fixes, etc - Render the background color of Not Run tests correctly in HTML - Apply subtest fractions down the stack Signed-off-by: Dylan Baker baker.dyla...@gmail.com Both patches are: Tested-by: Tom Stellard thomas.stell...@amd.com This is a nice

[Piglit] [PATCH] cl: Add a test for clEnqueueCopyBuffer

2013-11-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests | 1 + tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api/enqueue-copy-buffer.c | 87 ++ 3 files changed, 89 insertions(+) create mode 100644 tests/cl/api/enqueue-copy

Re: [Piglit] [PATCH] cl: Add a test for clEnqueueCopyBuffer

2013-11-15 Thread Tom Stellard
On Fri, Nov 15, 2013 at 04:38:33PM -0600, Aaron Watry wrote: On Fri, Nov 15, 2013 at 1:46 PM, Tom Stellard t...@stellard.net wrote: From: Tom Stellard thomas.stell...@amd.com --- tests/all_cl.tests | 1 + tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api

Re: [Piglit] [Beignet][PATCH] Add test cases generator.

2013-11-27 Thread Tom Stellard
On Tue, Nov 26, 2013 at 02:38:56PM +0800, Yi Sun wrote: File utest_generator.py contain the base class and function for generating test cases. File utest_math_gen.py can generate most math function for all the gentype (floatX, intX). utest_math_gen.py can be run during cmake. Are you

Re: [Piglit] [PATCH V2 1/1] cl: Add buffer-flags test

2013-12-02 Thread Tom Stellard
On Fri, Nov 29, 2013 at 08:58:03PM -0500, Jan Vesely wrote: v2: Rework into subtests Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- tests/all_cl.tests| 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/buffer-flags.c| 224

Re: [Piglit] [PATCH 0/2] Storing doubles

2013-12-09 Thread Tom Stellard
I've pushed these patches, thanks! -Tom On Fri, Nov 29, 2013 at 09:57:53PM -0500, Jan Vesely wrote: Hi, these two patches attempt to improve the situation with store-double* generated tests. The first patch adds cl_khr_fp64 requirement to all generated tests, the second one adds

[Piglit] [PATCH 1/3] framework: Add a helper class for interpreting gtest results

2014-01-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com --- framework/gtest.py | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 framework/gtest.py diff --git a/framework/gtest.py b/framework/gtest.py new file mode 100644 index 000..7b474f3 --- /dev

[Piglit] [PATCH 2/3] cl: Add support for OpenCV unit tests

2014-01-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com This enables piglit to run and interpret the results from OpenCV's gtest based opencv_test_ocl program. This patch adds two new CMake configuration variables: OPENCL_OpenCVTestOCL_BINDIR: You can use this variable to enable the OpenCV tests by setting

[Piglit] [PATCH 3/3] cl: Add quick_cl.py test profile

2014-01-15 Thread Tom Stellard
From: Tom Stellard thomas.stell...@amd.com all_cl.py will now run each OpenCV sub-test individually, and quick_cl.py will run only the OpenCV parent tests. Both profiles run the exact same tests, but all_cl.py gives finer-grained results and also takes longer due to the overhead of running each

Re: [Piglit] [PATCH RESEND 1/1] cl: Add test program-scope-arrays.

2014-01-15 Thread Tom Stellard
On Wed, Jan 15, 2014 at 01:31:03PM -0500, Jan Vesely wrote: On Mon, 2014-01-13 at 08:55 -0800, Tom Stellard wrote: On Tue, Jan 07, 2014 at 06:21:36PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com Thank you

Re: [Piglit] [PATCH] cl: Add support for OpenCV unit tests v2

2014-01-20 Thread Tom Stellard
On Fri, Jan 17, 2014 at 03:04:46PM -0800, Dylan Baker wrote: I think you meant to ping the piglit list not mesa dev :) In general this looks a lot better, I've got a few little things for you On Friday, January 17, 2014 02:30:13 PM Tom Stellard wrote: From: Tom Stellard thomas.stell

Re: [Piglit] [PATCH] cl: Add support for OpenCV unit tests v2

2014-01-21 Thread Tom Stellard
On Tue, Jan 21, 2014 at 11:17:43AM -0800, Dylan Baker wrote: On Monday, January 20, 2014 09:16:54 AM Tom Stellard wrote: On Fri, Jan 17, 2014 at 03:04:46PM -0800, Dylan Baker wrote: I think you meant to ping the piglit list not mesa dev :) In general this looks a lot better, I've got

  1   2   3   >