request on gitlab if you prefer)
Thanks!
Pierre-Eric
From: Anthony Pesch
Sent: Friday, May 24, 2019 8:51 PM
To: Pelloux-prayer, Pierre-eric; Pierre-Eric Pelloux-Prayer; Anthony Pesch;
piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH
on behalf of Anthony Pesch
Sent: Friday, May 24, 2019 8:21 PM
To: Pierre-Eric Pelloux-Prayer; Anthony Pesch; piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH] arb_texture_buffer_range: Fix buffer alignment in
ranges-2 test
[CAUTION: External Email]
Hi Pierre,
Thanks!
I've modifed
770effba655f97be229e13f894884f0e4c3e604a
Author: Anthony Pesch
Date: Thu Apr 11 12:37:07 2019 -0400
arb_texture_buffer_range: Fix buffer alignment in ranges-2 test
The ranges-2 test was failing due to glTexBufferRange returning
GL_INVALID_VALUE
when the offset parameter wasn't
Pinging to see if anyone has the time to review.
- Anthony
On 4/15/19 4:24 PM, Anthony Pesch wrote:
From: Anthony Pesch
The ranges-2 test was failing due to glTexBufferRange returning GL_INVALID_VALUE
when the offset parameter wasn't GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT byte
aligned.
From
From: Anthony Pesch
The ranges-2 test was failing due to glTexBufferRange returning GL_INVALID_VALUE
when the offset parameter wasn't GL_TEXTURE_BUFFER_OFFSET_ALIGNMENT byte
aligned.
From the OpenGL 4.6 Core spec:
An INVALID_VALUE error is generated if offset is not an integer multiple
From: Anthony Pesch <ape...@nvidia.com>
Change zero-sized texture queries to pass a valid depth parameter, otherwise
they should error as per the OpenGL 4.6 Core spec:
"An INVALID_VALUE error is generated if the effective target is TEXTURE_1D,
TEXTURE_1D_ARRAY, TEXTURE_2D or TEXTUR
From: Anthony Pesch <ape...@nvidia.com>
Update cube map tests to ensure cube map textures are cube complete before
querying
them. Querying a cube map which is not cube complete should set
INVALID_OPERATION
as per the OpenGL 4.6 Core spec:
"An INVALID_OPERATION error i
com>
Sent: Monday, April 9, 2018 3:41 AM
To: Anthony Pesch; Anthony Pesch; piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH 3/3] arb_get_texture_sub_image: update cube map
tests to complete the cube map
For the series,
Reviewed-by: Juan A. Suarez <jasua...@igalia.com>
On Sun, 2018
Hey Juan,
Good catch - I'd only been focusing on the errors test.
I've updated the patch to also fix the errors in arb_get_texture_sub_image-get:
Author: Anthony Pesch <ape...@nvidia.com>
Date: Thu Mar 22 13:11:22 2018 -0400
arb_get_texture_sub_image: update cube map tests t
Hey Juan,
I've updated the patch to include the OpenGL spec references:
Author: Anthony Pesch <ape...@nvidia.com>
Date: Thu Mar 22 11:06:13 2018 -0400
arb_get_texture_sub_image: fix expected error when querying a level which
hasn't
been explicitly defined
Change ex
h."
- Anthony
From: Piglit <piglit-boun...@lists.freedesktop.org> on behalf of Juan A. Suarez
Romero <jasua...@igalia.com>
Sent: Wednesday, April 4, 2018 7:12 AM
To: Anthony Pesch; piglit@lists.freedesktop.org
Subject: Re: [Piglit] [PATCH 1/3] arb_get
s correct to me.
>
> Reviewed-by: Arthur Huillet <ahuil...@nvidia.com>
>
>
> On 28.03.2018 17:15, Anthony Pesch wrote:
>
>> From: Anthony Pesch <ape...@nvidia.com>
>>
>> Change expected error from INVALID_OPERATION to INVALID_VALUE when
>> querying
>&
From: Anthony Pesch <ape...@nvidia.com>
Change zero-sized texture queries to pass a valid depth parameter, otherwise
they should error as per the OpenGL 4.6 Core spec:
"An INVALID_VALUE error is generated if the effective target is TEXTURE_1D,
TEXTURE_1D_ARRAY, TEXTURE_2D or TEXTUR
From: Anthony Pesch <ape...@nvidia.com>
Change expected error from INVALID_OPERATION to INVALID_VALUE when querying
a level which hasn't been explicitly defined. This is a valid operation, the
error set should be due to the requested width and height being greater than
the default
From: Anthony Pesch <ape...@nvidia.com>
Update cube map tests to complete the cube map before performing the final
query. This final query is expected to succeed, however, querying a cube map
which is not cube complete should set INVALID_OPERATION as per the OpenGL 4.6
Cor
15 matches
Mail list logo
