Re: [Piglit] [PATCH] framework: fix running with mixed concurrency (neither -c or -1)

2018-05-09 Thread Arkadiusz Hiler
On Tue, May 08, 2018 at 10:32:26AM -0700, Dylan Baker wrote: > test_list is an iterator, you can't walk an iterator more than once. To > solve this we use itertools.tee, which creates a shared buffer for the > iterators to draw from. This fixes errors like: > > [000/480] > Traceback (most recent

[Piglit] [PATCH] profile: Don't exhaust generator when concurrency == "some"

2018-05-09 Thread Arkadiusz Hiler
s the call chain so that we call .itertests() in the place we actually consume the generator, not earlier. Reported-by: Stanislav Lisovskiy <stanislav.lisovs...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- framework/profile.py | 28 +-

[Piglit] [PATCH] framework: Do not run with an empty test list

2017-09-26 Thread Arkadiusz Hiler
and will help making the execution less prone to automated list generation errors (which has already bitten us) as well as human errors. Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- framework/programs/run.py | 4 1 file changed, 4 insertions(+) diff --git a/framework/programs/ru

Re: [Piglit] [PATCH v3] framework: Add --ignore-missing option

2017-08-15 Thread Arkadiusz Hiler
On Mon, Aug 14, 2017 at 10:21:13AM -0700, Dylan Baker wrote: > Quoting Arkadiusz Hiler (2017-08-14 05:09:01) > > Currently, if a test from provided testlist fails to be discovered by > > the framework, piglit blows up with an exception. > > > > This is both good - f

[Piglit] [PATCH v3] framework: Add --ignore-missing option

2017-08-14 Thread Arkadiusz Hiler
: Dylan Baker <dy...@pnwbakers.com> Cc: Tomi Sarvela <tomi.p.sarv...@intel.com> Cc: Martin Peres <martin.pe...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- framework/profile.py | 10 +++--- framework/programs/run.py | 12

[Piglit] [PATCH v2] framework: Add --ignore-missing option

2017-08-01 Thread Arkadiusz Hiler
;dy...@pnwbakers.com> Cc: Tomi Sarvela <tomi.p.sarv...@intel.com> Cc: Martin Peres <martin.pe...@intel.com> Tested-by: Petri Latvala <petri.latv...@intel.com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- framework/profile.py | 10 +++---

Re: [Piglit] [PATCH RFC] framework: Add --skip-missing option

2017-07-31 Thread Arkadiusz Hiler
On Thu, Jul 27, 2017 at 09:54:13AM -0700, Dylan Baker wrote: > Quoting Arkadiusz Hiler (2017-07-27 02:24:33) > > > > > > > > __all__ = [ > > > > 'RegexFilter', > > > > @@ -314,6 +316,9 @@ class TestProfile(object): > > > &g

Re: [Piglit] [PATCH RFC] framework: Add --skip-missing option

2017-07-27 Thread Arkadiusz Hiler
On Wed, Jul 26, 2017 at 11:56:47AM -0700, Dylan Baker wrote: > Quoting Arkadiusz Hiler (2017-07-26 00:46:21) > > Currently, if a test from provided testlist fails to be discovered by > > the framework, piglit blows up with an exception. > > Thank you for keeping the d

[Piglit] [PATCH RFC] framework: Add --skip-missing option

2017-07-26 Thread Arkadiusz Hiler
com> Signed-off-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com> --- framework/profile.py | 5 + framework/programs/run.py | 6 ++ 2 files changed, 11 insertions(+) diff --git a/framework/profile.py b/framework/profile.py index a625318..7a39e3c 100644 --- a/framework/profile.py ++

[Piglit] [PATCH RFC] Handling missing tests

2017-07-26 Thread Arkadiusz Hiler
tests as notrun, instead of ignoring them with a warning 2) add another possible result state - missing, so it would be more obvious But those would require much more work and code juggling, so I would like to know your opinions first. Any thoughts? Arkadiusz Hiler (1): framework: Add