Quoting Jan Vesely (2019-06-28 17:13:09)
> On Fri, Jun 28, 2019 at 7:46 PM Dylan Baker wrote:
> >
> > Quoting Jan Vesely (2019-06-28 13:01:36)
> > > From: Jan Vesely
> > >
> > > Signed-off-by: Jan Vesely
> > > ---
> > > framework/tes
Quoting Jan Vesely (2019-06-28 13:01:36)
> From: Jan Vesely
>
> Signed-off-by: Jan Vesely
> ---
> framework/test/piglit_test.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/framework/test/piglit_test.py b/framework/test/piglit_test.py
> index
Reviewed-by: Dylan Baker
Quoting Alejandro Piñeiro (2019-06-12 03:42:35)
> ---
> tests/shaders/shader_runner.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
> index 44
Reviewed-by: Dylan Baker
Quoting Jan Vesely (2019-06-22 16:48:56)
> On Wed, Jun 5, 2019 at 11:47 PM Jan Vesely wrote:
> >
> > From: Jan Vesely
> >
> > Signed-off-by: Jan Vesely
> > ---
> > framework/test/piglit_test.py | 1 +
> > 1 file changed,
Quoting Alejandro Piñeiro (2019-06-03 05:41:53)
> Since commit "tests: use meta profiles"
> (400dcd5cf18ac51ab8e9681d8ecab4132986efbd) some test sets are not
> represented anymore as python scripts. So first, it would be good to
> mention it, and second it would be good to mention that it would be
Quoting Vinson Lee (2019-03-29 23:37:55)
> Designated initializers are not supported in older versions of GCC.
>
> tes-gs-max-output.cpp:138: error: expected primary-expression before ‘.’ token
> tes-gs-max-output.cpp:139: error: expected primary-expression before ‘.’ token
>
Quoting Jordan Justen (2019-03-01 12:22:18)
> I guess piglit makes very light usage of bugzilla. Would it be simpler
> to just use gitlab issues in the piglit gitlab project?
>
> -Jordan
I think we should, anecdotally it seems like there are more spam bugs against
piglit than real bugs anyway.
Quoting Jordan Justen (2019-03-01 12:16:57)
> On 2019-02-20 07:36:48, Den wrote:
> > > Given the discussion below, I think we'll make piglit a sub-project of
> > > mesa. Those who need commit access to piglit but not mesa can be
> > > added directly to the piglit project.
> >
> > Hi list.
> >
as you can see, it is 79:
> https://www.python.org/dev/peps/pep-0008/#maximum-line-length
PEP0008 suggests between 72 and 99, I think 78 is fine. And since most of the
python is my fault I'm happy to say 78 and be in line with the rest of piglit on
that.
Either way,
Acked-by: Dylan Bake
ffer_object: require
>
> uniform int v1;
> uniform float v2;
> --
> 2.20.1
>
> ___
> Piglit mailing list
> Piglit@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/piglit
Reviewed-by: Dylan Baker
si
arb_enhanced_layouts/transform-feedback-layout-query-api.c | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
> --
> 2.19.1
>
I don't feel qualified to review patch 1, but for 2 & 3:
Reviewed-by: Dylan Baker
signature.asc
Description: signature
Quoting Erik Faye-Lund (2019-01-28 13:32:37)
> On Mon, 2019-01-28 at 10:57 -0800, Dylan Baker wrote:
> > Quoting Erik Faye-Lund (2019-01-21 08:00:56)
> > > Otherwise, GNOME Web (Epiphany) refuse to render the result.
> > >
> > > Signed-off-by: Erik F
Quoting Erik Faye-Lund (2019-01-21 08:00:56)
> Otherwise, GNOME Web (Epiphany) refuse to render the result.
>
> Signed-off-by: Erik Faye-Lund
> ---
> templates/feature.mako | 3 ++-
> templates/index.mako | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git
Please do not put anything in tests/glslparsertest/, these tests belong in in
tests/spec/glsl-es-1.00 and tests/spec/glsl-es-3.00 respectively.
Quoting Danylo Piliaiev (2019-01-09 09:35:16)
> In all GLSL ES versions output variables in fragment shader are allowed
> to be invariant.
>
> From
Quoting Eleni Maria Stea (2019-01-08 05:23:07)
> The compressed-cubemap.c tests the rendering of compressed cubemaps.
> The compressed-cubemap-teximage.c tests that compressed cubemaps created
> using dumped compressed 2D faces have the same values with compressed
> cubemaps that have been
Quoting Jordan Justen (2019-01-07 11:50:43)
> On 2018-12-18 14:57:43, Dylan Baker wrote:
> > Quoting Eric Anholt (2018-12-18 11:21:08)
> > > Jordan Justen writes:
> > >
> > > > On 2018-12-17 22:07:21, Tapani Pälli wrote:
> > > >> Hi;
> &
Quoting Dylan Baker (2018-12-19 13:56:18)
> Hi list,
>
> I've been off and on working on a new test runner for piglit written in C++14.
> Its been sitting on my gitlab publicly for a bit, and I've shared it with some
> people at Intel, but I thought I'd send out an announcement and
Hi list,
I've been off and on working on a new test runner for piglit written in C++14.
Its been sitting on my gitlab publicly for a bit, and I've shared it with some
people at Intel, but I thought I'd send out an announcement and see if I could
get some more interest. It's called swineherd, and
; I guess my point is that by putting the website under the docs
> > directory of the main branch, maybe it will allow others to contribute
> > changes (like this) more easily. :)
> >
> > Another change that we might consider is whether to use merge requests
> > in pigl
ptions['process_isolation']
> options.OPTIONS.jobs = args.jobs
> options.OPTIONS.no_retry = args.no_retry
> -options.OPTIONS.force_glsl = results.options['glsl']
> +options.OPTIONS.force_glsl = results.options['force_glsl']
>
> core.get_config(args.config_file)
>
&g
This allows the framework to know what tests will be run, and doesn't
actually make the implementation much more complicated.
---
.../nv_image_formats/copy-image-formats.c | 66 +++
1 file changed, 37 insertions(+), 29 deletions(-)
diff --git
This is ground work for using proper subtest handling, it's a big enough
change it makes sense to me to split it into a separate commit.
---
tests/spec/gl-1.0/rendermode-feedback.c | 77 +
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git
---
tests/spec/ext_transform_feedback/max-varyings.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/spec/ext_transform_feedback/max-varyings.c
b/tests/spec/ext_transform_feedback/max-varyings.c
index 1f83b60aa..b8c98a5d5 100644
--- a/tests/spec/ext_transform_feedback/max-varyings.c
v2: - don't put config inside #ifdef opengl
- de-duplicate comment
---
tests/spec/ext_polygon_offset_clamp/draw.c | 124 +
1 file changed, 78 insertions(+), 46 deletions(-)
diff --git a/tests/spec/ext_polygon_offset_clamp/draw.c
---
tests/spec/ext_semaphore/api-errors.c | 110 +++---
1 file changed, 63 insertions(+), 47 deletions(-)
diff --git a/tests/spec/ext_semaphore/api-errors.c
b/tests/spec/ext_semaphore/api-errors.c
index a7fd93ade..be8a0c7cf 100644
--- a/tests/spec/ext_semaphore/api-errors.c
This doesn't add support for running specific subtests, but it does
enumerate the ones that exist.
---
tests/spec/gl-1.0/beginend-coverage.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/tests/spec/gl-1.0/beginend-coverage.c
---
tests/spec/ext_semaphore/api-errors.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/spec/ext_semaphore/api-errors.c
b/tests/spec/ext_semaphore/api-errors.c
index be8a0c7cf..b1c426cc5 100644
--- a/tests/spec/ext_semaphore/api-errors.c
+++
This has config.supports_gl_compat_version = 10, then calls
piglit_require_GL_version(20), so just set the value in the config to 20
and remove the other.
---
tests/spec/ext_transform_feedback/max-varyings.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Currently if the first subtest failed then the second subtest (AoA)
would always report fail, this is bad. Instead we want to report fail,
but leave status (which is set to warn in the implementation doesn't
meet certain assumptions by the test), so that the second test can
report accurately.
---
This allows each test to be selected at runtime.
---
.../ext_transform_feedback/max-varyings.c | 147 +++---
1 file changed, 94 insertions(+), 53 deletions(-)
diff --git a/tests/spec/ext_transform_feedback/max-varyings.c
b/tests/spec/ext_transform_feedback/max-varyings.c
index
---
tests/spec/ext_semaphore_fd/api-errors.c | 52 ++--
1 file changed, 31 insertions(+), 21 deletions(-)
diff --git a/tests/spec/ext_semaphore_fd/api-errors.c
b/tests/spec/ext_semaphore_fd/api-errors.c
index b0e14b636..2a1414e50 100644
---
It's not immediately obvious whether this test is suitable for
piglit_run_selected_subtests, so just enumerate the subtests it has so
that the framework can catch crashes.
---
tests/spec/mesa_pack_invert/readpixels.c | 9 +
1 file changed, 9 insertions(+)
diff --git
---
tests/spec/gl-1.0/rendermode-feedback.c | 57 +++--
1 file changed, 35 insertions(+), 22 deletions(-)
diff --git a/tests/spec/gl-1.0/rendermode-feedback.c
b/tests/spec/gl-1.0/rendermode-feedback.c
index 532c55914..2260370a3 100644
---
---
tests/spec/gl-1.0/dlist-beginend.c | 138 ++---
1 file changed, 85 insertions(+), 53 deletions(-)
diff --git a/tests/spec/gl-1.0/dlist-beginend.c
b/tests/spec/gl-1.0/dlist-beginend.c
index 644b84cce..eca32c1f3 100644
--- a/tests/spec/gl-1.0/dlist-beginend.c
+++
---
tests/spec/gl-3.0/render-integer.c | 100 -
1 file changed, 55 insertions(+), 45 deletions(-)
diff --git a/tests/spec/gl-3.0/render-integer.c
b/tests/spec/gl-3.0/render-integer.c
index 2937ec50c..ca2e1fe40 100644
--- a/tests/spec/gl-3.0/render-integer.c
+++
Which have never been run, though the array has been present since the
test was added.
---
tests/spec/gl-1.0/beginend-coverage.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/spec/gl-1.0/beginend-coverage.c
b/tests/spec/gl-1.0/beginend-coverage.c
index d36cc11c4..67792296a 100644
I can't really test that this works, so just enumerating will have to be
enough.
---
tests/spec/ext_window_rectangles/dlist.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/spec/ext_window_rectangles/dlist.c
b/tests/spec/ext_window_rectangles/dlist.c
index 59836544f..3f1eb9d73
It's just cosmetic.
---
tests/spec/gl-2.0/vertex-program-two-side.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c
b/tests/spec/gl-2.0/vertex-program-two-side.c
index 4623c70a6..65e6b7650 100644
---
This coverts the test to use the piglit_run_selected_subtests function,
which provides a nicer mechanism for running selected subtests, and
enumerates all subtests ahead of time.
---
tests/spec/gl-1.0/logicop.c | 97 -
1 file changed, 41 insertions(+), 56
sts (except for a very small number that
have been fixed already) have this problem. I just haven't gotten around to
fixing them all yet.
>
> On Mon, Nov 19, 2018 at 03:12:27PM -0800, Dylan Baker wrote:
> > cc: Rafael Antognolli
> > ---
> > .../arb_shader_image_load_
Quoting Ilia Mirkin (2018-11-20 18:28:52)
> On Mon, Nov 19, 2018 at 4:24 PM Dylan Baker wrote:
> >
> > ---
> > tests/spec/ext_polygon_offset_clamp/draw.c | 121 ++---
> > 1 file changed, 79 insertions(+), 42 deletions(-)
> >
> > diff --gi
cc: Rafael Antognolli
---
.../arb_shader_image_load_store/atomicity.c | 403 +++---
1 file changed, 239 insertions(+), 164 deletions(-)
diff --git a/tests/spec/arb_shader_image_load_store/atomicity.c
b/tests/spec/arb_shader_image_load_store/atomicity.c
index f53dddaa2..88d15d65d
---
tests/spec/ext_polygon_offset_clamp/draw.c | 121 ++---
1 file changed, 79 insertions(+), 42 deletions(-)
diff --git a/tests/spec/ext_polygon_offset_clamp/draw.c
b/tests/spec/ext_polygon_offset_clamp/draw.c
index 5c7382556..089b45425 100644
---
This has config.supports_gl_compat_version = 10, then calls
piglit_require_GL_version(20), so just set the value in the config to 20
and remove the other.
---
tests/spec/ext_transform_feedback/max-varyings.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
---
tests/spec/gl-3.0/render-integer.c | 100 -
1 file changed, 55 insertions(+), 45 deletions(-)
diff --git a/tests/spec/gl-3.0/render-integer.c
b/tests/spec/gl-3.0/render-integer.c
index 2937ec50c..ca2e1fe40 100644
--- a/tests/spec/gl-3.0/render-integer.c
+++
This allows each test to be selected at runtime.
---
.../ext_transform_feedback/max-varyings.c | 147 +++---
1 file changed, 94 insertions(+), 53 deletions(-)
diff --git a/tests/spec/ext_transform_feedback/max-varyings.c
b/tests/spec/ext_transform_feedback/max-varyings.c
index
---
tests/spec/gl-1.0/rendermode-feedback.c | 57 +++--
1 file changed, 35 insertions(+), 22 deletions(-)
diff --git a/tests/spec/gl-1.0/rendermode-feedback.c
b/tests/spec/gl-1.0/rendermode-feedback.c
index 532c55914..2260370a3 100644
---
---
tests/spec/ext_semaphore/api-errors.c | 110 +++---
1 file changed, 63 insertions(+), 47 deletions(-)
diff --git a/tests/spec/ext_semaphore/api-errors.c
b/tests/spec/ext_semaphore/api-errors.c
index a7fd93ade..be8a0c7cf 100644
--- a/tests/spec/ext_semaphore/api-errors.c
the list of subtests they'd run, and the order that they
would be run in. This allows the framework to properly assign crashes to the
correct subtest. This series converts several more tests to use this feature,
and fixes a few minor bugs in the proccesss.
Dylan Baker (19):
test/logicop: Use
This is ground work for using proper subtest handling, it's a big enough
change it makes sense to me to split it into a separate commit.
---
tests/spec/gl-1.0/rendermode-feedback.c | 77 +
1 file changed, 40 insertions(+), 37 deletions(-)
diff --git
Currently if the first subtest failed then the second subtest (AoA)
would always report fail, this is bad. Instead we want to report fail,
but leave status (which is set to warn in the implementation doesn't
meet certain assumptions by the test), so that the second test can
report accurately.
---
This doesn't add support for running specific subtests, but it does
enumerate the ones that exist.
---
tests/spec/gl-1.0/beginend-coverage.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/tests/spec/gl-1.0/beginend-coverage.c
---
tests/spec/gl-1.0/dlist-beginend.c | 138 ++---
1 file changed, 85 insertions(+), 53 deletions(-)
diff --git a/tests/spec/gl-1.0/dlist-beginend.c
b/tests/spec/gl-1.0/dlist-beginend.c
index 644b84cce..eca32c1f3 100644
--- a/tests/spec/gl-1.0/dlist-beginend.c
+++
Which have never been run, though the array has been present since the
test was added.
---
tests/spec/gl-1.0/beginend-coverage.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/spec/gl-1.0/beginend-coverage.c
b/tests/spec/gl-1.0/beginend-coverage.c
index d36cc11c4..67792296a 100644
---
tests/spec/ext_semaphore/api-errors.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/spec/ext_semaphore/api-errors.c
b/tests/spec/ext_semaphore/api-errors.c
index be8a0c7cf..b1c426cc5 100644
--- a/tests/spec/ext_semaphore/api-errors.c
+++
It's not immediately obvious whether this test is suitable for
piglit_run_selected_subtests, so just enumerate the subtests it has so
that the framework can catch crashes.
---
tests/spec/mesa_pack_invert/readpixels.c | 9 +
1 file changed, 9 insertions(+)
diff --git
This allows the framework to know what tests will be run, and doesn't
actually make the implementation much more complicated.
---
.../nv_image_formats/copy-image-formats.c | 66 +++
1 file changed, 37 insertions(+), 29 deletions(-)
diff --git
I can't really test that this works, so just enumerating will have to be
enough.
---
tests/spec/ext_window_rectangles/dlist.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/spec/ext_window_rectangles/dlist.c
b/tests/spec/ext_window_rectangles/dlist.c
index 59836544f..3f1eb9d73
It's just cosmetic.
---
tests/spec/gl-2.0/vertex-program-two-side.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c
b/tests/spec/gl-2.0/vertex-program-two-side.c
index 4623c70a6..65e6b7650 100644
---
This coverts the test to use the piglit_run_selected_subtests function,
which provides a nicer mechanism for running selected subtests, and
enumerates all subtests ahead of time.
---
tests/spec/gl-1.0/logicop.c | 97 -
1 file changed, 41 insertions(+), 56
---
tests/spec/ext_semaphore_fd/api-errors.c | 52 ++--
1 file changed, 31 insertions(+), 21 deletions(-)
diff --git a/tests/spec/ext_semaphore_fd/api-errors.c
b/tests/spec/ext_semaphore_fd/api-errors.c
index b0e14b636..2a1414e50 100644
---
-alpha-one is only recognized by the rgb variant of this test. This only
prints a warning, but it's a warning that would be nice to git rid of.
cc: Lionel Landwerlin
---
tests/opengl.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/opengl.py b/tests/opengl.py
lkan' + grouptools.SEPARATOR +
> + grouptools.from_path(os.path.relpath(dirpath,
> _basedir)))
There's a grouptools.join function for this:
groupname = grouptools.join('vulkan', grouptools.from_path(...))
With that change:
Reviewed-by: Dylan Baker
Thanks for followin
ainst lack of second color output in radeonsi.
> >
> > v2: by Ilia Mirkin
> > - Set supports_gl_compat_version = 30
> > - Moved drawing to piglit_display
> > - Change drawing sequence to: clear red -> draw -> clear green
> >
&g
## encoding=utf-8
> 6 # -*- coding: utf-8 -*-
>
> I added it as the first line after the shebang, if any.
perfect, that's the right thing to do.
Reviewed-by: Dylan Baker
>
> Suggested-by: Dylan Baker
> Signed-off-by: Eric Engestrom
> ---
> framework/__init_
Quoting Eric Engestrom (2018-11-08 09:37:22)
> On Thursday, 2018-11-08 17:34:33 +0000, Dylan Baker wrote:
> > Quoting Eric Engestrom (2018-11-08 09:23:51)
> > > The non-ascii char broke the python2 CI:
> > > https://travis-ci.org/mesa3d/piglit/jobs/4
Quoting Eric Engestrom (2018-11-08 09:23:51)
> The non-ascii char broke the python2 CI:
> https://travis-ci.org/mesa3d/piglit/jobs/452170869
>
> Fixes: 221d924689e3bb2796ce "framework: Add a vulkan tests profile"
> Cc: Neil Roberts
> Cc: Samuel Iglesias Gonsálvez
>
| 3 ++-
> 7 files changed, 34 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
>
Thanks!
for the series:
Reviewed-by: Dylan Baker
signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
t; +assert group not in profile.test_list, group
> +
> +profile.test_list[group] = test
> --
I'm find with keeping vkrunner separate from piglit, we can always merge it in
tree later if we decide that would be better.
The one thing I'm not seeing is xml generation,
Quoting Emil Velikov (2018-10-11 03:48:20)
> On Fri, 5 Oct 2018 at 17:06, Dylan Baker wrote:
> >
> > Because wflinfo returns GL legacy (non-profile) for gles on glx.
> >
> > v2: - If the platform is pure GLX then warn that things aren't going to
> > work.
Quoting Emil Velikov (2018-10-09 05:35:39)
> On Fri, 5 Oct 2018 at 19:13, Dylan Baker wrote:
> >
> > In other cases like this we return skip instead of warn.
> Can you be more specific about those "other cases like these"? It's
> the core part of your argumen
Quoting Rafael Antognolli (2018-10-05 12:44:02)
> On Fri, Oct 05, 2018 at 12:16:53PM -0700, Dylan Baker wrote:
> > Quoting Rafael Antognolli (2018-10-05 11:25:24)
> > > On Fri, Oct 05, 2018 at 11:11:19AM -0700, Dylan Baker wrote:
> > > > Does this change the set of
Quoting Rafael Antognolli (2018-10-05 11:25:24)
> On Fri, Oct 05, 2018 at 11:11:19AM -0700, Dylan Baker wrote:
> > Does this change the set of tests in the profile? I think it will since
> > we'll
> > end up calling self.random.random() a different number of times.
>
In other cases like this we return skip instead of warn. I think that it should
be skip because:
1) warn doesn't have any real meaning
2) we couldn't actually run the test so there isn't a result
Dylan
Quoting Emil Velikov (2018-10-03 05:21:56)
> From: Emil Velikov
>
> As pointed out by
Does this change the set of tests in the profile? I think it will since we'll
end up calling self.random.random() a different number of times.
Quoting Rafael Antognolli (2018-10-03 10:51:28)
> We randomly exclude 80% of the 'arb_vertex_attrib_64bit/execution/vs_in'
> tests, but we want to keep at
Quoting Eric Engestrom (2018-10-05 08:22:38)
> On Thursday, 2018-10-04 11:28:22 -0700, Dylan Baker wrote:
> > Because wflinfo returns GL legacy (non-profile) for gles on glx.
> > ---
> > framework/wflinfo.py | 8 +++-
> > 1 file changed, 7 insertions(+), 1 dele
Because wflinfo returns GL legacy (non-profile) for gles on glx.
v2: - If the platform is pure GLX then warn that things aren't going to
work.
---
framework/wflinfo.py | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/framework/wflinfo.py
For the series:
Reviewed-by: Dylan Baker
Quoting Jordan Justen (2018-09-28 14:28:10)
> I noticed that although the tests ran successfully, the output of
> 'piglit summary console' did not have proper names.
>
> For example, before:
> ../../build/debug/piglit/target_api/no_
Quoting Caio Marcelo de Oliveira Filho (2018-09-21 16:05:37)
> > > -add_shader_test('tests/shaders/glsl-algebraic-add-zero.shader_test')
> > > -add_shader_test('tests/spec/glsl-1.50/execution/geometry-basic.shader_test')
> > >
basic-ssbo.shader_test
> +tests/spec/arb_tessellation_shader/execution/sanity.shader_test
> +tests/spec/glsl-1.50/execution/geometry-basic.shader_test
> +'''
How about a list of strings?
for that you could have:
Reviewed-by: Dylan Baker
> +
> +for line in shader_tests.split(
Quoting Daniel Stone (2018-09-17 08:10:11)
> Hi,
>
> On Fri, 14 Sep 2018 at 23:16, Dylan Baker wrote:
> > Quoting Den (2018-09-14 05:36:51)
> > > Hi guys. There is really trivial thing, but I think, would be great to
> > > fix it.
> > >
> > &g
Quoting Ian Romanick (2018-09-12 16:29:55)
> From: Ian Romanick
>
> The optimizer recently added the ability to replace a compare with a
> subtraction under certain circumstances. This can fail for integers.
> For inputs a = 0x8000, b = 4, int(0x8000) < 4, but
> int(0x8000) - 4
Quoting Den (2018-09-14 05:36:51)
> Hi guys. There is really trivial thing, but I think, would be great to
> fix it.
>
> https://piglit.freedesktop.org/ on this web-site there is a link
> https://cgit.freedesktop.org/piglit/tree/README, which actually doesn't
> work (there is no file with a
Quoting Andres Gomez (2018-09-04 14:32:32)
> Cc: Mark Janes
> Cc: Dylan Baker
> Cc: Juan A. Suarez Romero
> Signed-off-by: Andres Gomez
> ---
> tests/gtf_gles.py | 82 +++
> 1 file changed, 82 insertions(+)
> create mode
Quoting Andres Gomez (2018-09-04 14:39:25)
> Cc: Mark Janes
> Cc: Dylan Baker
> Cc: Juan A. Suarez Romero
> Signed-off-by: Andres Gomez
> ---
> tests/gtf_gl.py | 95 +
> 1 file changed, 95 insertions(+)
> create mod
Quoting Mark Janes (2018-08-28 11:38:30)
> Reviewed-by: Mark Janes
> Tested-by: Mark Janes
>
> Dylan Baker writes:
>
> > Otherwise these tests fail in odd ways when running from an installed
> > instance.
> >
> > Cc: Alejandro Piñeiro
&g
Otherwise these tests fail in odd ways when running from an installed
instance.
Cc: Alejandro Piñeiro
Cc: Mark Janes
Cc: Clayton Craft
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8f19457fc..596870b9b 100644
---
Suggested-by: Rhys Kidd
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 433fa1aea..8f19457fc 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -227,7 +227,7 @@ IF(PIGLIT_BUILD_GLX_TESTS)
ENDIF()
Quoting Rhys Kidd (2018-08-10 10:48:49)
> On Fri, 10 Aug 2018 at 13:47, Dylan Baker wrote:
>
> ---
> CMakeLists.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 413
---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 413cd72e6..433fa1aea 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -227,7 +227,7 @@ IF(PIGLIT_BUILD_GLX_TESTS)
ENDIF()
set(Python_ADDITIONAL_VERSIONS
-3.6 3.5
t-in-array-size.shader_test
Or whatever you think is better (I'm just reading the bug and trying to come up
with something).
Otherwise this test looks good, so with the rename:
Reviewed-by: Dylan Baker
Quoting Tapani Pälli (2018-08-09 23:12:44)
> Signed-off-by: Tapani Pälli
>
Quoting Emil Velikov (2018-08-08 05:33:44)
> On 7 August 2018 at 02:53, Rhys Kidd wrote:
> > Signed-off-by: Rhys Kidd
> > ---
> > .travis.yml | 3 +++
> > tox.ini | 9 +
> > 2 files changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index
For the series (assuming the answer to my numpy question in patch 2 is "yes"),
Reviewed-by: Dylan Baker
Quoting Rhys Kidd (2018-08-06 18:53:44)
> Simple series to reflect that python 2.7 or >= 3.4 is supported.
> Python 3.3 drops out due to upstream deprecation, and ad
Quoting Rhys Kidd (2018-08-06 18:53:46)
> Signed-off-by: Rhys Kidd
> ---
> .travis.yml | 3 +++
> tox.ini | 9 +
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index b6e8136e8..45b23f009 100644
> --- a/.travis.yml
> +++ b/.travis.yml
Reviewed-by: Dylan Baker
Quoting Andres Gomez (2018-07-19 15:39:05)
> This avoids modifications in the original filters object.
>
> Detected through Travis CI.
>
> Fixed also a couple of typos.
>
> Fixes: 1f0f2ad25 ("framework: Add filters class")
> Cc
Reviewed-by: Dylan Baker
Quoting Andres Gomez (2018-07-19 09:08:12)
> pytest-warnings is not needed since it was integrated into pytest's
> core since 3.1
>
> pytest-timeout >= 1.3.0 requires pytest >= 3.6.0 and we want to keep
> using 3.2.5
>
> Cc: Juan A. Suare
This just adds a helpful message about what directory the conflicting
shaders are in.
---
framework/test/shader_test.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/framework/test/shader_test.py b/framework/test/shader_test.py
index 719b92f9d..de3e92f4b 100644
---
This is required to make the shader_runner multiple tests in one process
mode work, as it cannot mix gles and gl shaders together.
Cc: curroje...@riseup.net
---
.../gen_shader_framebuffer_fetch_tests.py | 81 +++
1 file changed, 46 insertions(+), 35 deletions(-)
diff --git
Python 2 assumes that files are encoded ascii unless they declare a
different encoding, python 3 assumes files are encoded utf-8 unless they
declare a different encoding.
Cc: v...@freedesktop.org
---
tests/sanity.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/sanity.py
> @@ -89,7 +99,9 @@ void piglit_init(int argc, char **argv)
> glEnableVertexAttribArray(0);
>
> glEnable(GL_CONSERVATIVE_RASTERIZATION_INTEL);
> +#ifdef PIGLIT_USE_OPENGL
> glPolygonMode(GL_FRONT_AND_BACK, GL_FILL);
> +#endif
This was the one thing I w
1 - 100 of 3305 matches
Mail list logo
