Re: [Piglit] [Bug] Fragment shader interlock sample shading test assumes wrong guarantees (plain text copy)

GL can set the sample mask as a bitmask since GL3.2. Marek On Sat, Jun 24, 2023, 07:54 Triang3l wrote: > Follow-up: In further testing, I did get some races with my test > condition, and it turns out that in OpenGL and Vulkan, unlike in > Direct3D, gl_SampleMaskIn contains only 1 sample when

Re: [Piglit] [PATCH] draw-prim-rate: Fix Clang build error.

Reviewed-by: Marek Olšák Marek On Mon, Jun 3, 2019 at 10:28 PM Vinson Lee wrote: > draw-prim-rate.c:415:3: error: initializer element is not a compile-time > constant > ceil(sqrt(0.5 * 1000)), > ^~ > > Fixes: 6e1bb1e

[Piglit] [PATCH] Add a test that measures primitive rate

From: Marek Olšák The output looks like this (from the initial version, the current version is slightly different): Measuring GPrims/second, , Number of primitives Draw Call , Cull Method ,2K,4K,8K, 16K, 32K, 64K, 256K

[Piglit] [PATCH] rendermode-feedback: fix a crash

From: Marek Olšák For some reason, the last element is uninitialized if I don't clear the structure like this. --- tests/spec/gl-1.0/rendermode-feedback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/spec/gl-1.0/rendermode-feedback.c b/tests/spec/gl-1.0

[Piglit] [PATCH] shader_runner: don't abort on atomic counter subtest failure

From: Marek Olšák --- tests/shaders/shader_runner.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 8404d548f..6729d82b7 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c

[Piglit] [PATCH] glx-multithread-buffer: Add a new test reproducing a radeonsi bug

From: Marek Olšák --- tests/glx/CMakeLists.gl.txt| 1 + tests/glx/glx-multithread-buffer.c | 199 + tests/opengl.py| 1 + 3 files changed, 201 insertions(+) create mode 100644 tests/glx/glx-multithread-buffer.c diff --git a/tests/glx

[Piglit] [PATCH] piglit_drm_dma_buf: fix NV12, YUV420, and YVU420 import tests for radeonsi

From: Marek Olšák - We have to use the linear layout, otherwise the offsets can't be modified. - The GBM image has only 1 plane, so the gbm functions can't be used for other planes. - Don't manipulate with the stride. It has to be the same. --- .../piglit-framework-gl/piglit_drm_dma_buf.c

Re: [Piglit] [PATCH] ext_gpu_shader4: test glBindFragDataLocationEXT

On Mon, Apr 15, 2019 at 8:18 PM Ian Romanick wrote: > On 4/15/19 5:16 PM, Marek Olšák wrote: > > It's also an execution test for "varying out". > > I don't know what that has to do with glBindFragDataLocationEXT vs > glBindFragDataLocation. Can you please expla

Re: [Piglit] [PATCH] egl: Fix tests for EGL_EXT_device_base extension list use.

Reviewed-by: Marek Olšák Marek On Tue, Apr 23, 2019 at 4:01 PM wrote: > From: Mathias Fröhlich > > The test uses different gl contexts thus the pointers into the extensions > string needs to be invalidated for each new context. > > Signed-off-by: Mathias Froehlich >

Re: [Piglit] [PATCH] ext_gpu_shader4: test glBindFragDataLocationEXT

It's also an execution test for "varying out". Marek On Mon, Apr 15, 2019 at 6:28 PM Ian Romanick wrote: > On 4/15/19 10:47 AM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > tests/opengl.py | 7 ++ > > te

[Piglit] [PATCH] ext_gpu_shader4: test glBindFragDataLocationEXT

From: Marek Olšák --- tests/opengl.py | 7 ++ tests/spec/gl-3.1/mixed-int-float-fbo.c | 100 +++- 2 files changed, 88 insertions(+), 19 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index 40c37a055..666b35200 100644 --- a/tests

[Piglit] [PATCH] ext_shader_image_load_formatted: add a test for the extension

From: Marek Olšák --- .../execution/image_checkerboard.shader_test | 71 +++ 1 file changed, 71 insertions(+) create mode 100644 tests/spec/ext_shader_image_load_formatted/execution/image_checkerboard.shader_test diff --git a/tests/spec/ext_shader_image_load_formatted

Re: [Piglit] [PATCH] egl: Add tests for EGL_EXT_device_base v2.

Reviewed-by: Marek Olšák Marek On Wed, Apr 10, 2019 at 5:10 AM wrote: > From: Mathias Fröhlich > > Hi all, > > Below is a new test that should test the about to be arriving egl device > extension. The test goes a bit further than just creating a context and > destr

[Piglit] [PATCH] ext_gpu_shader4: add compiler tests for everything

From: Marek Olšák --- generated_tests/CMakeLists.txt| 16 + generated_tests/gen_gpu_shader4_tests.py | 376 ++ .../gen_gpu_shader4_tests/binary.frag.mako| 16 + .../gen_gpu_shader4_tests/binary.vert.mako| 18 + .../gen_gpu_shader4_tests

Re: [Piglit] [PATCH] KHR_parallel_shader_compiler: new test

On Thu, Jan 3, 2019 at 2:38 PM Ian Romanick wrote: > On 11/28/18 6:55 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > --- > > tests/opengl.py | 6 + > > tests/spec/CMakeLists.txt |

[Piglit] [PATCH] KHR_parallel_shader_compiler: new test (v2)

From: Marek Olšák v2: test glGetIntegerv after every every change of the thread count spaces -> tabs --- tests/opengl.py | 6 + tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gl.txt | 7 ++ .../CMakeLists.gl

[Piglit] [PATCH] map_buffer_range_test: add tests to reproduce u_threaded & radeonsi bugs

From: Marek Olšák --- .../map_buffer_range_test.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/spec/arb_map_buffer_range/map_buffer_range_test.c b/tests/spec/arb_map_buffer_range/map_buffer_range_test.c index 2f5d2a39d..80d0afbdd 100644

Re: [Piglit] [PATCH 2/2] AMD_texture_texture4: new test

exture. > On Wed, Nov 28, 2018 at 10:05 PM Marek Olšák wrote: > > > > The test is the same as the textureGather shader test in shaders/. I > didn't make any changes to it besides the texture function name and > #extension. I didn't even bother figuring out how it works. :) > >

[Piglit] [PATCH] Add new API tests for BPTC and RGTC GLES extensions (v2)

From: Marek Olšák v2: add glCompressedTexImage2D tests --- tests/opengl.py | 6 ++ tests/spec/CMakeLists.txt | 2 + .../CMakeLists.gles2.txt | 7 ++ .../CMakeLists.txt| 1

Re: [Piglit] [PATCH 2/2] AMD_texture_texture4: new test

PM Marek Olšák wrote: > > > > From: Marek Olšák > > > > based on some ARB_texture_gather5 test. > > --- > > .../execution/texture4.shader_test| 84 +++ > > 1 file changed, 84 insertions(+) > > create mode 100644 &

Re: [Piglit] [PATCH 1/2] Add new API tests for BPTC and RGTC GLES extensions

tests and make them runnable in ES. > > At the very least, maybe add a test that glCompressedTexImage works > with these too? > On Wed, Nov 28, 2018 at 8:21 PM Marek Olšák wrote: > > > > From: Marek Olšák > > > > --- > > tests/opengl.py

[Piglit] [PATCH] KHR_parallel_shader_compiler: new test

From: Marek Olšák --- tests/opengl.py | 6 + tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gl.txt | 7 ++ .../CMakeLists.gles2.txt | 4 + .../CMakeLists.txt| 1

[Piglit] [PATCH 2/2] AMD_texture_texture4: new test

From: Marek Olšák based on some ARB_texture_gather5 test. --- .../execution/texture4.shader_test| 84 +++ 1 file changed, 84 insertions(+) create mode 100644 tests/spec/amd_texture_texture4/execution/texture4.shader_test diff --git a/tests/spec

[Piglit] [PATCH 1/2] Add new API tests for BPTC and RGTC GLES extensions

From: Marek Olšák --- tests/opengl.py | 6 ++ tests/spec/CMakeLists.txt | 2 + .../CMakeLists.gles2.txt | 7 ++ .../CMakeLists.txt| 1 + .../ext_texture_compression_bptc/bptc-api.c | 71

Re: [Piglit] [PATCH] glsl/frexp: fix the incorrect expected values

Pushed, thanks! Marek On Wed, Oct 31, 2018 at 7:35 AM andrey simiklit wrote: > Hello, > > Could you please help me with a push. > > Thanks, > Andrii. > > On Fri, Oct 26, 2018 at 5:50 PM andrey simiklit > wrote: > >> Hello, >> >> Thanks a lot for reviewing. >> >> Regards, >> Andrii. >> >> On

[Piglit] [PATCH 1/3] primitive-restart-draw-mode: draw front and back faces in different colors

From: Marek Olšák so that triangle strip winding reset is visible after primitive restart --- tests/general/primitive-restart-draw-mode.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/general/primitive-restart-draw-mode.c b/tests/general/primitive

[Piglit] [PATCH 3/3] drawoverhead: print results in the CSV format

From: Marek Olšák for easier data processing. --- tests/perf/common.c | 19 --- tests/perf/common.h | 3 --- tests/perf/drawoverhead.c | 8 3 files changed, 4 insertions(+), 26 deletions(-) diff --git a/tests/perf/common.c b/tests/perf/common.c index

[Piglit] [PATCH 2/3] ext_window_rectangles/render: make the test more thorough

From: Marek Olšák --- tests/spec/ext_window_rectangles/render.c | 93 +++ 1 file changed, 61 insertions(+), 32 deletions(-) diff --git a/tests/spec/ext_window_rectangles/render.c b/tests/spec/ext_window_rectangles/render.c index 87435b23c..0062399f0 100644 --- a/tests/spec

Re: [Piglit] [PATCH] glsl-1.50: Add test for geometry shader with unused outputs

Pushed, thanks! Marek On Wed, Sep 19, 2018 at 3:09 PM Józef Kucia wrote: > > Reproduces a GPU hang on radeonsi. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107857 > Signed-off-by: Józef Kucia > --- > .../geometry/gs-point-unused-outputs.shader_test | 40 >

Re: [Piglit] [PATCH 4/4] arb_tessellation_shader/tes-gs-max-output: new test for TES/GS amplification

For patches 3-4: Acked-by: Marek Olšák Marek On Thu, Sep 13, 2018 at 2:11 PM Nicolai Hähnle wrote: > > From: Nicolai Hähnle > > Test extremes of GS amplification under tessellation. > --- > tests/opengl.py | 1 + > .../arb_tessellation_sha

Re: [Piglit] [PATCH v2] Add tests for GL_AMD_depth_clamp_separate

H_CLAMP_FAR_AMD state check in >>single file (Ian Romanick) >> 4) Add missing piglit_require_extension method (Marek Olask) >> >> Signed-off-by: Sagar Ghuge >> Tested-by: Marek Olšák >> --- >> tests/opengl.py

Re: [Piglit] [PATCH] arb_vertex_array_object: Add test for deleting object zero

Reviewed-by: Marek Olšák Marek On Fri, Aug 31, 2018 at 3:21 AM, Ian Romanick wrote: > From: Ian Romanick > > As of commit 781a78914c7, this test fails with: > > arb_vertex_array-delete-object-0: src/mesa/main/hash.c:240: > _mesa_HashRemove_unlocked: Assertion `key' faile

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

The other two tests should also do: piglit_require_extension("GL_AMD_depth_clamp_separate"); Marek On Tue, Aug 21, 2018 at 8:05 PM Sagar Ghuge wrote: > > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt |

Re: [Piglit] [PATCH] Add tests for GL_AMD_depth_clamp_separate

Tested-by: Marek Olšák Thanks. The tests pass on radeonsi. Marek On Tue, Aug 21, 2018 at 8:05 PM Sagar Ghuge wrote: > > Signed-off-by: Sagar Ghuge > --- > tests/opengl.py | 8 + > tests/spec/CMakeLists.txt | 1 + > ...

Re: [Piglit] [PATCH 2/2] Add a test for GL_AMD_framebuffer_multisample_advanced

On Thu, Aug 2, 2018 at 3:44 PM, Brian Paul wrote: > One minor thing below. > > Otherwise, Reviewed-by: Brian Paul > > > On 08/01/2018 05:21 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> tests/opengl.py

[Piglit] [PATCH 1/2] Update gl.xml from opengl registry and fix gl.py

Too big for the mailing list: https://cgit.freedesktop.org/~mareko/piglit/commit/?h=deqp=54f453c92f72d53c09a7b42838ac8ee28f963c56 Please review, Thanks, Marek ___ Piglit mailing list Piglit@lists.freedesktop.org

[Piglit] [PATCH 2/2] Add a test for GL_AMD_framebuffer_multisample_advanced

From: Marek Olšák --- tests/opengl.py | 6 + tests/spec/CMakeLists.txt | 1 + .../CMakeLists.gl.txt | 13 + .../CMakeLists.gles3.txt | 4 + .../CMakeLists.txt| 1

[Piglit] [PATCH 2/2] Test glMultiDrawElementsIndirect with non-VBO attribs

From: Marek Olšák --- tests/opengl.py | 3 +- .../multidrawelements.c | 69 +-- 2 files changed, 50 insertions(+), 22 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index ce67d485b..3ca4ee74b 100644 --- a/tests

[Piglit] [PATCH 1/2] Test glMultiDrawArraysIndirect with non-VBO attribs

From: Marek Olšák --- tests/opengl.py | 6 ++ tests/spec/gl-3.0/multidrawarrays-vertexid.c | 64 +++- 2 files changed, 56 insertions(+), 14 deletions(-) diff --git a/tests/opengl.py b/tests/opengl.py index 6944fd79d..ce67d485b 100644 --- a/tests

Re: [Piglit] [PATCH v3] arb_compute_shader: test dispatch functions with display lists

Acked-by: Marek Olšák Marek On Wed, Jun 27, 2018 at 8:54 PM, Timothy Arceri wrote: > This change also splits apart some of the compute test common > functions to make them easier to use with display lists. > --- > > V3: I submitted a spec bug and it was decided the in

Re: [Piglit] [PATCH] general: better test display lists in attribute test

Reviewed-by: Marek Olšák Marek On Sat, Jun 23, 2018 at 9:52 PM, Timothy Arceri wrote: > We weren't really testing that the displays list worked since > the calls could have just been executed immediately. > --- > tests/general/attribs.c | 12 > 1 file changed

Re: [Piglit] [PATCH v2] arb_compute_shader: test dispatch functions with display lists

Sounds good. Marek On Tue, Jun 26, 2018 at 9:39 PM, Timothy Arceri wrote: > I'm going to hold this one back for the moment. I've filled a spec bug and > I'm hoping the indirect call will just be made to generate an error inside > display lists. > > > On 27/06/18 11:30,

Re: [Piglit] [PATCH] compatibility: test vertex color clamping in geom and tess shaders

Reviewed-by: Marek Olšák Marek On Fri, Jun 22, 2018 at 5:50 AM, Timothy Arceri wrote: > --- > .../tes-clamp-vertex-color.shader_test| 76 +++ > .../gs-clamp-vertex-color.shader_test | 47 > 2 files changed, 123 insertions(+) > cre

Re: [Piglit] [PATCH v2] arb_compute_shader: test dispatch functions with display lists

Acked-by: Marek Olšák Marek On Sun, Jun 24, 2018 at 9:40 PM, Timothy Arceri wrote: > This change also splits apart some of the compute test common > functions to make them easier to use with display lists. > > V2: make sure we dereference the data for indirect dispatch at >

Re: [Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

On Thu, Jun 21, 2018 at 12:12 AM, Timothy Arceri wrote: > > > On 21/06/18 14:05, Marek Olšák wrote: >> >> On Mon, Jun 18, 2018 at 12:50 AM, Timothy Arceri >> wrote: >>> >>> --- >>> tests/opengl.py | 1 + >

Re: [Piglit] [PATCH 2/2] arb_tessellation_shader: test tes interaction with fixed function fragment shader

For the series: Reviewed-by: Marek Olšák Marek On Sun, Jun 17, 2018 at 10:46 PM, Timothy Arceri wrote: > --- > .../compatibility/tcs-tes-ff-frag.shader_test | 63 +++ > 1 file changed, 63 insertions(+) > create mode 100644 > tests/spec/arb_tessellation_s

Re: [Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

On Mon, Jun 18, 2018 at 12:50 AM, Timothy Arceri wrote: > --- > tests/opengl.py | 1 + > .../arb_tessellation_shader/CMakeLists.gl.txt | 1 + > .../immediate-mode-draw-patches.c | 111 ++ > 3 files changed, 113 insertions(+) > create

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: test display list support

Acked-by: Marek Olšák Marek On Tue, Jun 19, 2018 at 6:07 AM, Timothy Arceri wrote: > --- > tests/opengl.py | 1 + > .../arb_gpu_shader_fp64/CMakeLists.gl.txt | 1 + > .../arb_gpu_shader_fp64/dlist-fp64-uniforms.c | 406 +

Re: [Piglit] [PATCH] arb_shader_subroutine: add simple display list test

Reviewed-by: Marek Olšák Marek On Tue, Jun 19, 2018 at 9:13 PM, Timothy Arceri wrote: > --- > .../simple-subroutine-dlist.shader_test | 92 +++ > 1 file changed, 92 insertions(+) > create mode 100644 > tests/spec/arb_shader_subroutine/execution/si

Re: [Piglit] [PATCH] arb_viewport_array: test display list support

Acked-by: Marek Olšák Marek On Wed, Jun 20, 2018 at 8:24 PM, Timothy Arceri wrote: > --- > tests/opengl.py | 1 + > .../spec/arb_viewport_array/CMakeLists.gl.txt | 1 + > tests/spec/arb_viewport_array/dlist.c | 355 +

Re: [Piglit] [Mesa-dev] GitLab migration of Piglit

I would say it's a sub-project of Mesa. Marek On Mon, Jun 4, 2018 at 11:48 AM, Jason Ekstrand wrote: > All, > > Sorry for the mess of GitLab e-mails but there are a lot of questions to > ask as this process moves forward. Today, we're discussing piglit. I've > included both the mesa and

Re: [Piglit] [PATCH 3/3] glsl-1.50: test compat built in constants

For the series: Reviewed-by: Marek Olšák Marek On Mon, May 28, 2018 at 8:59 PM, Timothy Arceri wrote: > I forgot to add this to OpenGL.py but I've fixed it locally. > > On 29/05/18 10:52, Timothy Arceri wrote: > >> --- >> tests/spec/glsl-1.50/minimum-maximums-co

Re: [Piglit] [RFC 00/10] Running dEQP tests without process isolation

This is the latest piglit branch being able to run dEQP without process isolation. It's "rebased" on master. My definition is "rebased" is pretty radical, but it's all I can do: https://cgit.freedesktop.org/~mareko/piglit/log/?h=deqp Marek On Wed, Oct 11, 2017 at 6:26 AM, Nicolai Hähnle wrote:

Re: [Piglit] [PATCH 2/3] framework: allow specifying the number of jobs for concurrency

On Wed, May 30, 2018 at 5:26 PM, Dylan Baker wrote: > Quoting Marek Olšák (2018-05-30 14:14:35) > > On Wed, May 30, 2018 at 4:21 PM, Dylan Baker > wrote: > > > > Quoting Marek Olšák (2018-05-30 13:04:47) > > > single = multiprocessing.d

Re: [Piglit] [PATCH 2/3] framework: allow specifying the number of jobs for concurrency

On Wed, May 30, 2018 at 4:21 PM, Dylan Baker wrote: > Quoting Marek Olšák (2018-05-30 13:04:47) > > From: Nicolai Hähnle > > > > The default remains the same: number of CPUs. But on systems with lots of > > cores but comparatively little (V)RAM it can make sense to re

[Piglit] [PATCH 2/3] framework: allow specifying the number of jobs for concurrency

From: Nicolai Hähnle The default remains the same: number of CPUs. But on systems with lots of cores but comparatively little (V)RAM it can make sense to reduce the number of jobs to avoid random failures caused by out-of-memory conditions. --- framework/options.py | 1 +

[Piglit] [PATCH 3/3] framework/resume: properly parse the no_retry option

From: Nicolai Hähnle --- framework/programs/run.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index bbc527b55..a970845dc 100644 --- a/framework/programs/run.py +++ b/framework/programs/run.py @@ -377,20

[Piglit] [PATCH 1/3] framework/html: guard against errors writing individual test results

From: Nicolai Hähnle v2: check ENAMETOOLONG --- framework/summary/html_.py | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/framework/summary/html_.py b/framework/summary/html_.py index f7fdc8576..14dd76fa8 100644 --- a/framework/summary/html_.py +++

[Piglit] [PATCH 2/3] framework: allow specifying the number of jobs for concurrency

From: Nicolai Hähnle The default remains the same: number of CPUs. But on systems with lots of cores but comparatively little (V)RAM it can make sense to reduce the number of jobs to avoid random failures caused by out-of-memory conditions. --- framework/options.py | 1 +

Re: [Piglit] [PATCH 3/3] arb_tessellation_shader: test display list support for glPatchParameterfv()

For the series: Reviewed-by: Marek Olšák Marek On Mon, May 28, 2018 at 6:36 AM, Timothy Arceri wrote: > --- > ...r-tessouter-inputs-quads-dlist.shader_test | 83 +++ > 1 file changed, 83 insertions(+) > create mode 100644 tests/spec/arb_tessellation_shader/exec

Re: [Piglit] [PATCH 2/2] ARB_tessellation_shader: test gl_*Color built-ins with tessellation shaders

For the series: Reviewed-by: Marek Olšák Marek On Sun, May 27, 2018 at 11:22 PM, Timothy Arceri wrote: > --- > tests/spec/gl-2.0/vertex-program-two-side.c | 157 ++-- > 1 file changed, 147 insertions(+), 10 deletions(-) > > diff --git a/tests/spec/gl-2.0/ver

Re: [Piglit] [PATCH] gl-3.2-compat: test gl_FogFragCoord built-in with geometry shaders

Acked-by: Marek Olšák Marek On Fri, May 25, 2018 at 3:03 AM, Timothy Arceri wrote: > This extends the fogscale test to test a gl_FogFragCoord value > passed via a geometry shader. > --- > tests/shaders/glsl-fs-fogscale.c | 100 +-- > 1 file changed

Re: [Piglit] [PATCH] gl-3.2-compat: test gl_ClipVertex built-in with geometry shaders

Tested-by: Marek Olšák <marek.ol...@amd.com> Acked-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, May 21, 2018 at 10:29 PM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > These tests have been adapted from the glsl-1.20 clipping tests. > > This tests

Re: [Piglit] [PATCH v2] gl-3.2-compat: test gl_TexCoord[] built-in with geometry shaders

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, May 21, 2018 at 8:59 PM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > This tests both setting gl_TexCoord[] in the geometry shader and > using the gs to passthrough the gl_TexCoord[] values from the > vertex sh

Re: [Piglit] [PATCH] gl-3.2-compat: test gl_*Color built-ins with geometry shaders

Tested-by: Marek Olšák <marek.ol...@amd.com> Acked-by: Marek Olšák <marek.ol...@amd.com> Marek On Mon, May 21, 2018 at 4:32 AM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > This updates the existing vertex shader test and makes it more > flexable. > --- > te

Re: [Piglit] [PATCH] gl-3.2-compat: test gl_*Color built-ins with geometry shaders

Nevermind. It does test those if I add some parameters. Marek On Tue, May 22, 2018 at 11:18 PM, Marek Olšák <mar...@gmail.com> wrote: > Hi Timothy, > > This doesn't test any gl_*Color builtins. ST_DEBUG=tgsi doesn't show a > shader using COLOR where it's not a FS output. &g

Re: [Piglit] [PATCH] gl-3.2-compat: test gl_*Color built-ins with geometry shaders

Hi Timothy, This doesn't test any gl_*Color builtins. ST_DEBUG=tgsi doesn't show a shader using COLOR where it's not a FS output. Marek On Mon, May 21, 2018 at 4:32 AM, Timothy Arceri wrote: > This updates the existing vertex shader test and makes it more > flexable. >

[Piglit] [PATCH 1/2] glslparsertest: support compatibility profile tests

From: Marek Olšák <marek.ol...@amd.com> --- framework/test/glsl_parser_test.py| 5 + tests/glslparsertest/glslparsertest.c | 18 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/framework/test/glsl_parser_test.py b/framework/test/glsl_parser_t

Re: [Piglit] [PATCH] gl-3.0: test glUniform*ui{v} functions are compiled into display lists

Acked-by: Marek Olšák <marek.ol...@amd.com> Marek On Wed, May 9, 2018 at 11:51 PM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78097 > --- > tests/opengl.py | 2 + > tests/spec/

Re: [Piglit] [PATCH 1/5] framework/html: guard against errors writing individual test results

On Wed, May 2, 2018 at 4:51 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Marek Olšák (2018-05-02 13:32:43) > > From: Nicolai Hähnle <nicolai.haeh...@amd.com> > > > > --- > > framework/summary/html_.py | 18 +++--- > >

[Piglit] [PATCH] piglit-util: use _exit to skip context destruction

From: Marek Olšák <marek.ol...@amd.com> --- tests/util/piglit-util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index ed7d21c95..01207ffa5 100644 --- a/tests/util/piglit-util.c +++ b/tests/util/piglit-util.c @@ -58,20

[Piglit] [PATCH 4/5] khr_gl45: add support for mustpass lists

From: Nicolai Hähnle --- tests/khr_gl45.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/khr_gl45.py b/tests/khr_gl45.py index 08e6280bb..95f474220 100644 --- a/tests/khr_gl45.py +++ b/tests/khr_gl45.py @@ -36,34 +36,37 @@

[Piglit] [PATCH 5/5] deqp_egl: add support for mustpass lists

From: Nicolai Hähnle --- tests/deqp_egl.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/deqp_egl.py b/tests/deqp_egl.py index 7422c82e3..ccd40b2af 100644 --- a/tests/deqp_egl.py +++ b/tests/deqp_egl.py @@ -19,36 +19,40 @@ # OUT

[Piglit] [PATCH 1/5] framework/html: guard against errors writing individual test results

From: Nicolai Hähnle --- framework/summary/html_.py | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/framework/summary/html_.py b/framework/summary/html_.py index f7fdc8576..512b42c24 100644 --- a/framework/summary/html_.py +++

[Piglit] [PATCH 2/5] framework: fix grouptools.commonprefix when len(args) == 1

From: Nicolai Hähnle --- framework/grouptools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/grouptools.py b/framework/grouptools.py index f28241d3c..ce2e97c79 100644 --- a/framework/grouptools.py +++ b/framework/grouptools.py @@ -82,21

[Piglit] [PATCH 3/5] framework: handle UnicodeDecodeError

From: Marek Olšák <marek.ol...@amd.com> This happens due to LLVM printing colored text into stdout/stderr on error. --- framework/test/base.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/test/base.py b/framework/test/base.py index 134b87245..f187c0210 100644 --- a/fra

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

On Tue, Apr 10, 2018 at 9:54 PM, Mark Janes <mark.a.ja...@intel.com> wrote: > Dylan Baker <dy...@pnwbakers.com> writes: > > > Quoting Marek Olšák (2018-04-10 14:22:10) > >> On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker <dy...@pnwbakers.com> > wrote: > &

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

On Tue, Apr 10, 2018 at 2:15 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Eric Anholt (2018-04-09 17:10:35) > > Marek Olšák <mar...@gmail.com> writes: > > > > > Is this use case affected? > > > > > > piglit run --deqp-mustpass-lis

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

On Thu, Apr 5, 2018 at 2:05 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > Quoting Marek Olšák (2018-04-04 16:37:47) > > Is this use case affected? > > > > piglit run --deqp-mustpass-list --process-isolation 0 -p gbm -c quick > cts_gl45 > > deqp_gles2 deqp_gl

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

Is this use case affected? piglit run --deqp-mustpass-list --process-isolation 0 -p gbm -c quick cts_gl45 deqp_gles2 deqp_gles3 deqp_gles31 Yes, that is just 1 command to run all those test suites at the same time. I use my personal "deqp" piglit branch that also disables process isolation for

Re: [Piglit] [PATCH 15/15] arb_tessellation_shader: add a test with an array in a struct in a per-vertex TCS out

On Tue, Apr 3, 2018 at 9:16 PM, Timothy Arceri <tarc...@itsqueeze.com> wrote: > > > On 27/03/18 10:32, Marek Olšák wrote: > >> From: Nicolai Hähnle <nicolai.haeh...@amd.com> >> >> This currently hits a bug in Mesa's GLSL-to-TGSI conversion. >>

[Piglit] [PATCH 13/15] arb_gpu_shader_int64: test two operands with indirect access simultaneously

From: Nicolai Hähnle This hits a bug in Mesa st/glsl_to_tgsi. --- .../indirect-array-two-accesses.shader_test| 61 ++ 1 file changed, 61 insertions(+) create mode 100644

[Piglit] [PATCH 11/15] glsl-1.50/linker: add explicit "link success" line to test section

From: Nicolai Hähnle --- .../linker/versions-mingled-multiple-shader-objects.shader_test| 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/spec/glsl-1.50/linker/versions-mingled-multiple-shader-objects.shader_test

[Piglit] [PATCH 05/15] ext_framebuffer_multisample-interpolation: fix single-sample centroid-edges

From: Nicolai Hähnle When num_samples == 0, the centroid qualifier is ignored. --- tests/spec/ext_framebuffer_multisample/interpolation.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[Piglit] [PATCH 04/15] adj-prims: beef up the test to tease out what nvidia hardware does

From: Nicolai Hähnle --- tests/spec/gl-3.2/adj-prims.c | 144 +- 1 file changed, 128 insertions(+), 16 deletions(-) diff --git a/tests/spec/gl-3.2/adj-prims.c b/tests/spec/gl-3.2/adj-prims.c index f4479c708..6faff74d2 100644 ---

[Piglit] [PATCH 14/15] arb_gpu_shader_fp64: add tests for frexp() corner cases

From: Nicolai Hähnle The only-{exponent,mantissa} tests hit a bug in Mesa's st/glsl_to_tgsi. --- .../fs-frexp-dvec4-only-exponent.shader_test | 37 + .../fs-frexp-dvec4-only-mantissa.shader_test | 38 +

[Piglit] [PATCH 09/15] arb_texture_query_levels: rename VS input to piglit_vertex

From: Nicolai Hähnle Using 'vertex' relies on undefined behavior, since shader_runner does not setup that attribute explicitly. --- .../spec/arb_texture_query_levels/execution/vs-baselevel.shader_test | 4 ++--

[Piglit] [PATCH 15/15] arb_tessellation_shader: add a test with an array in a struct in a per-vertex TCS out

From: Nicolai Hähnle This currently hits a bug in Mesa's GLSL-to-TGSI conversion. --- .../tcs-tes-array-in-struct.shader_test| 78 ++ 1 file changed, 78 insertions(+) create mode 100644

[Piglit] [PATCH 08/15] glsl-1.20/fs-structure: remove stray varying

From: Nicolai Hähnle --- .../glsl-1.20/execution/uniform-initializer/fs-structure.shader_test | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/spec/glsl-1.20/execution/uniform-initializer/fs-structure.shader_test

[Piglit] [PATCH 01/15] arb_gpu_shader5: add interpolateAt* tests with input in a struct

From: Nicolai Hähnle The fact that this should be allowed was clarified in GLSL 4.60. --- .../fs-interpolateAtCentroid-struct.shader_test| 59 .../fs-interpolateAtOffset-struct.shader_test | 63 ++

[Piglit] [PATCH 02/15] glsl-4.40: add tests for interpolateAt* with swizzles / array subscripts on vectors

From: Nicolai Hähnle For swizzles, the language changed in GLSL 4.40. For array subscripts, it's not entirely clear whether the clarification wrt interpolant being an l-value should be backdated even earlier or not. Keeping it a 4.40 test should be enough for practical

[Piglit] [PATCH 12/15] arb_shader_ballot: add missing extension

From: Nicolai Hähnle --- tests/spec/arb_shader_ballot/execution/fs-ballot.shader_test | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_shader_ballot/execution/fs-ballot.shader_test b/tests/spec/arb_shader_ballot/execution/fs-ballot.shader_test index

[Piglit] [PATCH 03/15] gl-3.2/adj-prims: fix expected vertex order for triangle strips with adjacency

From: Nicolai Hähnle The first two vertices are swapped for triangle strips with adjacency; see Table 10.1 of the OpenGL 4.5 (Compatibility Profile) spec. --- tests/spec/gl-3.2/adj-prims.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff

[Piglit] [PATCH 06/15] shader_tests: move input/output declarations above functions

From: Nicolai Hähnle The SPIRV conversion script gets confused otherwise. --- tests/shaders/glsl-vs-max-array-access-function.shader_test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/shaders/glsl-vs-max-array-access-function.shader_test

[Piglit] [PATCH 07/15] fs-inout-index-two-level: remove unnecessary and incorrect varying

From: Nicolai Hähnle --- .../shaders/out-parameter-indexing/fs-inout-index-two-level.shader_test | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/shaders/out-parameter-indexing/fs-inout-index-two-level.shader_test

[Piglit] [PATCH 1/2] arb_viewport_array/viewport_indices: allow float precision instead of double

From: Marek Olšák <marek.ol...@amd.com> Mesa will not use doubles for this state. --- tests/spec/arb_viewport_array/viewport_indices.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_viewport_array/viewport_indices.c b/tests/spec/arb_viewport

[Piglit] [PATCH 2/2] texunits: don't test glTexEnv with unusable texture units

From: Marek Olšák <marek.ol...@amd.com> The GL limit is MaxTextureCombinedUnits, but the real usable limit is MaxTextureCoordUnits. This is probably a spec bug. Mesa will ignore glTexEnv calls where unit >= MaxTextureCoordUnits. --- tests/general/texunits.c | 4 ++-- 1 file c

Re: [Piglit] [PATCH 3/3] arb_internalformat_query2: some formats are not compatible with TBOs

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro <apinhe...@igalia.com> wrote: > On those cases, the resource is not supported, so we should expect the > unsupported outcome. > --- > .../spec/arb_internalformat_que

Re: [Piglit] [v2 PATCH 1/3] arb_internalformat_query2: minmax GL_ALPHA8 deprecated on 3.1+

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro <apinhe...@igalia.com> wrote: > When ARB_compatibility is missing or the context is Core. > > v2: check for ARB_compatibility or core (Marek) > --- > tests/spe

Re: [Piglit] [v2 PATCH 2/3] arb_internalformat_query2: more than one way to support GEOMETRY_TEXTURE

Reviewed-by: Marek Olšák <marek.ol...@amd.com> Marek On Sat, Jan 27, 2018 at 10:44 AM, Alejandro Piñeiro <apinhe...@igalia.com> wrote: > v2: GL_EXT_geometry_shader should not be checked, as is only for GLES > (Ilia Mirkin) > --- > tests/spec/arb_internalformat_quer

  1   2   3   4   5   6   >