Re: [Piglit] [PATCH 1/4] cl: Add float type vstore test

2016-08-18 Thread Tom Stellard
On Sat, Jul 30, 2016 at 01:56:03PM -0400, Jan Vesely wrote: > Passes on intel, clover(AMD Turks,Kaveri), beignet, CUDA > > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> For the series: Acked-by: Tom Stellard <thomas.stell...@amd.com> Go ahead and commit. > --- >

Re: [Piglit] [PATCH 1/1] cl: skip get image info test if there's no image support

2016-05-02 Thread Tom Stellard
On Mon, May 02, 2016 at 10:01:43AM -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> Reviewed-by: Tom Stellard <thomas.stell...@amd.com> > --- > tests/cl/api/get-image-info.c | 25 +++-- > 1 file changed, 23 insertions(+),

Re: [Piglit] [PATCH] framework/test/{opencv, oclconform}: fix subprocess returning bytes

2016-02-10 Thread Tom Stellard
On Wed, Feb 10, 2016 at 01:42:12PM -0800, Dylan Baker wrote: > During the hybridization this little bit was missed, causing the to > subprocess to return bytes, while the rest of the code expected unicode. > This fixes most issues. I sent another patch for the remaining one. > cc:

[Piglit] [PATCH] oclconform: Encode regex with 'unicode_escape' instead for 'string_escape'

2016-02-10 Thread Tom Stellard
This fixes a run-time error with python 3.4. --- framework/test/oclconform.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/test/oclconform.py b/framework/test/oclconform.py index cad00dd..0a64499 100644 --- a/framework/test/oclconform.py +++

Re: [Piglit] [PATCH 1/1] cl: Don't warn when using deprecated functions.

2016-01-27 Thread Tom Stellard
On Fri, Jan 15, 2016 at 05:38:43PM -0500, Jan Vesely wrote: > Deprecated features are required to be supported until they are removed. > > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> Reviewed-by: Tom Stellard <thomas.stell...@amd.com> > --- > tests/c

Re: [Piglit] [PATCH 1/1] cl: Add scalar to constant load test

2016-01-27 Thread Tom Stellard
On Fri, Jan 15, 2016 at 05:37:42PM -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> Reviewed-by: Tom Stellard <thomas.stell...@amd.com> > --- > tests/cl/program/execute/constant-load.cl | 18 ++ > 1 file changed, 14 in

Re: [Piglit] [PATCH RESEND 1/1] cl: Extend program scope arrays with more types

2016-01-27 Thread Tom Stellard
gt; we should still test it. > > Jan > Reviewed-by: Tom Stellard <thomas.stell...@amd.com> > tests/cl/program/execute/program-scope-arrays.cl | 102 > ++- > 1 file changed, 98 insertions(+), 4 deletions(-) > > diff --git a/tests/cl/program

Re: [Piglit] [PATCH v2] cl: add clEnqueueFillImage

2015-09-29 Thread Tom Stellard
On Tue, Sep 29, 2015 at 10:05:41PM +0200, Serge Martin wrote: > Hello > > I think I will push it in a few days if no one objects > Feel free to push it right away if you want. -Tom > On Saturday 12 September 2015 16:37:04 Serge Martin wrote: > > --- > > It' a little more than a ping so here

[Piglit] [PATCH] framework/summary.py: Always print number of changes in console mode

2015-09-09 Thread Tom Stellard
The counts for changes, fixes, and regressions are now reported as zero when no changes are detect rather than being omitted from the output. This makes it easier for scripts to parse the output of piglit summary console, becuase now when there are no regressions piglit always outputs:

Re: [Piglit] [PATCH] framework/summary.py: Always print number of changes in console mode

2015-09-09 Thread Tom Stellard
On Wed, Sep 09, 2015 at 01:23:22PM -0700, Dylan Baker wrote: > On Wed, Sep 09, 2015 at 03:57:55PM -0400, Tom Stellard wrote: > > On Wed, Sep 09, 2015 at 12:52:22PM -0700, Dylan Baker wrote: > > > > I have a buildbot seti up to run piglit and the way it detects whether > >

Re: [Piglit] [PATCH] framework/summary.py: Always print number of changes in console mode

2015-09-09 Thread Tom Stellard
ething wrong: tstellar@localhost ~/piglit $ ./piglit summary csv -o out.csv results/master--150727-/ results/master-BONAIRE-150223-/ usage: piglit [-h] [-o ] piglit: error: unrecognized arguments: results/master-BONAIRE-150223-/ -Tom > Dylan > > On Wed, Sep 09, 2015 at 12:28:21PM +, To

Re: [Piglit] [PATCH] framework/summary.py: Always print number of changes in console mode

2015-09-09 Thread Tom Stellard
On Wed, Sep 09, 2015 at 12:52:22PM -0700, Dylan Baker wrote: > > I have a buildbot seti up to run piglit and the way it detects whether > > or no there have been piglit regressions is by running piglit summary > > console and then parsing the output. > > > > The CSV summary seems to only accept a

Re: [Piglit] [PATCH] cl: fix invalid platform test in create-context

2015-08-17 Thread Tom Stellard
On Fri, Aug 14, 2015 at 09:05:48PM +0200, Serge Martin (EdB) wrote: OpenCL objects are just pointers in the end, using random pointer value is likely to make an application crash. Also, all others tests use NULL as an invalid object. Reviewed-by: Tom Stellard thomas.stell...@amd.com See

Re: [Piglit] [PATCH] cl: test clEnqueueFillBuffer

2015-08-07 Thread Tom Stellard
On Fri, Aug 07, 2015 at 11:41:15PM +0200, Serge Martin (EdB) wrote: --- Reviewed-by: Tom Stellard thomas.stell...@amd.com tests/cl.py| 1 + tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api/enqueue-fill-buffer.c | 269

[Piglit] Error when using creating a summary with old results

2015-07-28 Thread Tom Stellard
Hi, I'm getting this error when I try to include older results in a summary: Warning: A python exception that should have been handled was not. This is bug and should be reported. BUG: No module supports file extensions .old Is there some way to fix this? Thanks, Tom

Re: [Piglit] Error when using creating a summary with old results

2015-07-28 Thread Tom Stellard
path that isn't deleting the .old files when it should? -Tom you can do piglit-summary-html (cat foo.old) That should hide the filename from python. Dylan: Looks like your logic is a bit *too* clever now :) On Tue, Jul 28, 2015 at 10:47 AM, Tom Stellard t...@stellard.net wrote: Hi

Re: [Piglit] [PATCH] cl/api: Avoid deprecated declarations warnings.

2015-07-08 Thread Tom Stellard
Reviewed-by: Tom Stellard thomas.stell...@amd.com -Tom On Wed, Jul 08, 2015 at 02:54:51PM +0100, Jose Fonseca wrote: --- tests/cl/api/create-image.c| 2 ++ tests/cl/api/unload-compiler.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/cl/api/create-image.c b/tests/cl/api

Re: [Piglit] [PATCH] cl: fix CL_KERNEL_GLOBAL_WORK_SIZE query

2015-07-07 Thread Tom Stellard
On Sun, Jun 14, 2015 at 05:02:26PM +0200, EdB wrote: this query is only valid for a custom device or a build-in kernel Reviewed-by: Tom Stellard thomas.stell...@amd.com --- tests/cl/api/get-kernel-work-group-info.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions

Re: [Piglit] [PATCH v2 2/3] cl: Add tests for common builtin functions

2015-04-20 Thread Tom Stellard
undefined Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- generated_tests/CMakeLists.txt| 4 + generated_tests/gen_cl_common_builtins.py | 154 ++ generated_tests/gen_cl_math_builtins.py

Re: [Piglit] [PATCH 1/3] cl: Fix generating tts tests

2015-04-20 Thread Tom Stellard
On Sat, Apr 11, 2015 at 09:16:57PM -0400, Jan Vesely wrote: That's just 'mix' at this moment Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Patches 1 and 2 are: Reviewed-by: Tom Stellard thomas.stell...@amd.com --- generated_tests/genclbuiltins.py | 16 +++- 1 file changed

[Piglit] [PATCH 1/2] cl: Add generated tests for fract

2015-04-07 Thread Tom Stellard
This uses a custom function to generate the kernel code in order to handle the output parameters correctly. --- generated_tests/gen_cl_math_builtins.py | 75 + generated_tests/genclbuiltins.py| 18 +++- 2 files changed, 91 insertions(+), 2 deletions(-)

Re: [Piglit] [PATCH 1/1] cl: Enable required extension before using double type

2015-03-30 Thread Tom Stellard
On Fri, Mar 27, 2015 at 07:36:26PM -0400, Jan Vesely wrote: Fixes failures on OCL-1.1 implementations that provide cl_khr_fp64 Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com --- generated_tests/cl/store/store-kernels-global.inc | 4

Re: [Piglit] [PATCH 1/3] cl: add acospi test

2015-03-26 Thread Tom Stellard
On Wed, Mar 25, 2015 at 01:33:49PM -0400, Jan Vesely wrote: copied from acos. tested on clover and intel ocl Signed-off-by: Jan Vesely jan.ves...@rutgers.edu For the series: Reviewed-by: Tom Stellard thomas.stell...@amd.com --- generated_tests/gen_cl_math_builtins.py | 10 ++ 1

[Piglit] [PATCH] Add test for accessing a varying array with a large negative offset

2015-03-24 Thread Tom Stellard
From: Marek Olšák marek.ol...@amd.com This tests for a bug causing either a crash or a mis-compile in the radeonsi compiler. Tom Stellard: - Decrease the offset to guarantee we hit the bug. --- ...rying-array-float-negative-index-rd.shader_test | 77 ++ 1 file changed, 77

[Piglit] [PATCH 2/2] cl: Add test for reqd_group_work_size attribute

2015-03-24 Thread Tom Stellard
--- tests/cl.py| 1 + tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api/enqueue-nd-range-kernel.c | 121 + 3 files changed, 123 insertions(+) create mode 100644 tests/cl/api/enqueue-nd-range-kernel.c diff --git

[Piglit] [PATCH 1/2] get-kernel-work-group-info: Check value of CL_KERNEL_COMPILE_WORK_GROUP_SIZE

2015-03-24 Thread Tom Stellard
Verify it returns {0,0,0} when the reqd_work_group_size attribute is not specified. --- tests/cl/api/get-kernel-work-group-info.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/cl/api/get-kernel-work-group-info.c b/tests/cl/api/get-kernel-work-group-info.c

[Piglit] [PATCH] Add test for accessing a varying array with a large negative offset

2015-03-19 Thread Tom Stellard
From: Marek Olšák marek.ol...@amd.com This tests for a bug causing either a crash or a mis-compile in the radeonsi compiler. Tom Stellard: - Decrease the offset to guarantee we hit the bug. --- ...rying-array-float-negative-index-rd.shader_test | 77 ++ 1 file changed, 77

Re: [Piglit] [PATCH 2/3] cl-program-tester: Avoid void pointer arithmetic.

2015-03-03 Thread Tom Stellard
on change. Reviewed-by: Tom Stellard thomas.stell...@amd.com --- tests/cl/program/program-tester.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/program/program-tester.c b/tests/cl/program/program-tester.c index 3905679..314871a 100644 --- a/tests/cl

Re: [Piglit] [PATCH] CL: Add support for generating double-precision tests

2015-02-12 Thread Tom Stellard
On Thu, Feb 12, 2015 at 09:31:11AM -0600, Aaron Watry wrote: Ping. I just realized that I had this sitting around in my local repository and never got any review (yay for the holidays causing things to get lost). Reviewed-by: Tom Stellard thomas.stell...@amd.com --Aaron On Wed, Dec 17

Re: [Piglit] [PATCH 1/1] cl: Fix tolerance for division in scalar arithmetic test

2015-02-06 Thread Tom Stellard
On Mon, Jan 26, 2015 at 03:20:34PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com --- RFC: I only tagged numerical results, it did not make sense to me to do it for NaNs and Infs I think this is fine. R600

[Piglit] [PATCH] cl: Add test case from opencv's knn_find_nearest kernel

2015-02-04 Thread Tom Stellard
--- tests/cl/program/execute/opencv-knearest.cl | 77 + 1 file changed, 77 insertions(+) create mode 100644 tests/cl/program/execute/opencv-knearest.cl diff --git a/tests/cl/program/execute/opencv-knearest.cl b/tests/cl/program/execute/opencv-knearest.cl new file

[Piglit] [PATCH] opencv: Automatically run tests concurrently when render-nodes are present

2015-02-04 Thread Tom Stellard
+24,8 @@ # Authors: Tom Stellard thomas.stell...@amd.com # -from tests.cl import profile +from tests.cl import profile, CL_CONCURRENT from framework.test import add_opencv_tests, add_oclconform_tests -add_opencv_tests(profile) +add_opencv_tests(profile, CL_CONCURRENT) add_oclconform_tests

Re: [Piglit] [PATCH 1/1] cl: Fix tolerance for SP division

2015-01-26 Thread Tom Stellard
On Fri, Jan 23, 2015 at 06:51:39PM -0500, Jan Vesely wrote: The specs say 2.5 ulp, but we only take integer values Pushed, thanks! Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- R600: Fail - Pass tests/cl/program/execute/vector-arithmetic-float4.program_test | 6 +++--- 1 file

Re: [Piglit] [PATCH v2 1/1] cl: add log10 test

2015-01-26 Thread Tom Stellard
On Fri, Jan 23, 2015 at 06:59:13PM -0500, Jan Vesely wrote: v2: Fix tolerance Pushed, thanks! Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH v2] cl: Add exp tests

2015-01-26 Thread Tom Stellard
On Sun, Jan 04, 2015 at 04:20:39PM +0800, Meng Mengmeng wrote: Signed-off-by: Meng Mengmeng mengmeng.m...@intel.com Pushed, thanks! --- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[Piglit] [PATCH 1/2] opencv: Automatically run tests concurrently when render-nodes are present

2015-01-23 Thread Tom Stellard
/quick_cl.py @@ -24,8 +24,8 @@ # Authors: Tom Stellard thomas.stell...@amd.com # -from tests.cl import profile +from tests.cl import profile, cl_can_do_concurrent from framework.test import add_opencv_tests, add_oclconform_tests -add_opencv_tests(profile) +add_opencv_tests(profile, cl_can_do_concurrent

[Piglit] [PATCH 2/2] Add quick_glcl test profile

2015-01-23 Thread Tom Stellard
The combines the gpu and quick_cl test profiles. --- tests/quick_glcl.py | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 tests/quick_glcl.py diff --git a/tests/quick_glcl.py b/tests/quick_glcl.py new file mode 100644 index 000..1ee2733 --- /dev/null +++ b/tests/quick_glcl.py

Re: [Piglit] [PATCH 2/2] Add quick_glcl test profile

2015-01-23 Thread Tom Stellard
On Fri, Jan 23, 2015 at 11:20:16AM -0800, Dylan Baker wrote: I'm against this, you can already pass multiple profiles to piglit to run at the same time: ./piglit run gpu quick_cl output I do not know that. Thanks for the tip. -Tom On Friday, January 23, 2015 12:54:59 Tom Stellard wrote

Re: [Piglit] [PATCH 1/2] update documentation to be clear about using multiple profiles

2015-01-23 Thread Tom Stellard
On Fri, Jan 23, 2015 at 12:10:09PM -0800, Dylan Baker wrote: Updates README and the help message to be clear about using multiple test profiles. Thanks. Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- README

Re: [Piglit] [PATCH v2] cl: add clLinkProgram test

2014-12-19 Thread Tom Stellard
On Fri, Dec 19, 2014 at 02:39:06PM +0100, EdB wrote: v2: Use piglit_cl_get_program_build_info instead of piglit_cl_get_program_info, I was expected it to fail so I didn't paid attention. Remove -invalid- --link-- options on CL_INVALID_OPERATION test. Reviewed-by: Tom Stellard thomas.stell

Re: [Piglit] [PATCH 1/2] CL: refactor genclbuiltins.py to allow TSS functions with different arg types

2014-12-17 Thread Tom Stellard
in the next commit, where ldexp(floatN,int) is introduced. This patch updates all multi-argument kernel generators to take an array of input types, instead of assuming that all inputs are of the same base type as the first argument. For the series: Reviewed-by: Tom Stellard thomas.stell...@amd.com

Re: [Piglit] [PATCH] cl: -cl-std=CL1.0 is not valid

2014-12-11 Thread Tom Stellard
On Wed, Dec 03, 2014 at 11:04:50PM +0100, EdB wrote: By OpenCL 1.2 spec, -cl-std= should only be CL1.1 or CL1.2 We were checking against the device version instead of the desired version Report by: yan.w...@linux.intel.com I've pushed this, thanks! -Tom ---

Re: [Piglit] [PATCH 1/5] cl: Fix signed/unsigned comparison warnings

2014-12-11 Thread Tom Stellard
On Wed, Dec 03, 2014 at 03:53:28PM -0500, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- I've pushed patches 1,2,4,and 5. Thanks! -Tom tests/cl/program/program-tester.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [Piglit] [PATCH v2] cl: add tests for clCompileProgram

2014-11-14 Thread Tom Stellard
On Fri, Nov 07, 2014 at 04:24:27PM +0100, EdB wrote: v2: Use clBuildProgram to create to program to attach kernel to I've pushed this, thanks! --- tests/cl.py| 1 + tests/cl/api/CMakeLists.cl.txt | 1 + tests/cl/api/compile-program.c | 366

Re: [Piglit] [PATCH] cl: split CL10/CL11+ optimization options testing

2014-11-14 Thread Tom Stellard
On Wed, Nov 12, 2014 at 03:31:28PM +0100, EdB wrote: because -cl-strict-aliasing options argument to clBuildProgram is no longer supported in OpenCL 1.1. I've pushed this, thanks! --- or may be we should just test this in api/build-program.c ---

Re: [Piglit] [PATCH 0/3] add CL_MEM_HOST_* releated tests

2014-11-14 Thread Tom Stellard
On Mon, Nov 10, 2014 at 03:24:58PM +0100, EdB wrote: change existing tests in order to add CL_MEM_HOST_* checks The fisrt two patches are standalone fixes EdB (3): cl: fix doxygen filename cl: fix test name cl: add CL_MEM_HOST_* releated tests I've pushed these, thanks!

Re: [Piglit] [PATCH v2] cl: fix clGetKernelWorkGroupInfo

2014-11-07 Thread Tom Stellard
On Sun, Nov 02, 2014 at 02:35:56PM +0100, EdB wrote: If there is only one device associed with the kernel and device arg is NULL you don't have to trigger CL_INVALID_DEVICE I've pushed this patch, thanks! -Tom v2: Test for CL_SUCCESS instead of disabling it (Jan Vesely) ---

Re: [Piglit] [PATCH v2] cl: add tests for clCompileProgram

2014-11-07 Thread Tom Stellard
On Fri, Nov 07, 2014 at 04:24:27PM +0100, EdB wrote: v2: Use clBuildProgram to create to program to attach kernel to Thanks for the patch, I'm not quite so familiar with clCompileProgram, so I'm going to give it a few days to see if anyone else has any comments. -Tom --- tests/cl.py

[Piglit] [PATCH] cl: Add test for clCreateProgramWithBinary() v2

2014-10-21 Thread Tom Stellard
v2: - Fix filename in doxygen comments - Remove redundant binary status check. --- tests/cl.py | 1 + tests/cl/api/CMakeLists.cl.txt| 1 + tests/cl/api/create-program-with-binary.c | 177 ++ 3 files changed, 179

[Piglit] [PATCH] cl: Add test for clCreateProgramWithBinary() v3

2014-10-21 Thread Tom Stellard
v2: - Fix filename in doxygen comments - Remove redundant binary status check. v3: - Add test cases for passing binary programs to clBuildProgram() and clCompileProgram(). --- tests/cl.py | 1 + tests/cl/api/CMakeLists.cl.txt| 1 +

[Piglit] [PATCH] cl: Add test for clCreateProgramWithBinary()

2014-10-14 Thread Tom Stellard
--- tests/cl.py | 1 + tests/cl/api/CMakeLists.cl.txt| 1 + tests/cl/api/create-program-with-binary.c | 189 ++ 3 files changed, 191 insertions(+) create mode 100644 tests/cl/api/create-program-with-binary.c diff --git

Re: [Piglit] [PATCH v2 1/1] cl: Run concurrent on Linux render nodes, or non-Linux

2014-10-01 Thread Tom Stellard
On Sun, Sep 28, 2014 at 04:30:34PM -0400, Jan Vesely wrote: v2: make the flag a module parameter Pushed, thanks! -Tom Signed-off-by: Jan Vesely jan.ves...@rutgers.edu --- This still restricts CPU implementations to run serial on linux machines without render nodes, but I guess those

Re: [Piglit] [PATCH 1/2] cl: Add cospi tests

2014-10-01 Thread Tom Stellard
On Mon, Sep 29, 2014 at 10:01:06AM -0500, Aaron Watry wrote: v2: Remove stray ', pi' in Arg0 list Reviewed-by: Tom Stellard thomas.stell...@amd.com CC: Bruno Jiménez brunoji...@gmail.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 10

Re: [Piglit] [PATCH V2] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-26 Thread Tom Stellard
On Fri, Sep 26, 2014 at 07:11:03AM +0800, xionghu@intel.com wrote: From: Luo xionghu@intel.com the option CL_KERNEL_GLOBAL_WORK_SIZE for clGetKernelWorkGroupInfo should call built in kernel or custom device according to the spec, this patch calls the built in kernel to query the

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-26 Thread Tom Stellard
at 7:28 PM, Tom Stellard t...@stellard.net wrote: On Wed, Sep 03, 2014 at 07:20:10PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com thanks, can you push it too? I don't have commit access

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-26 Thread Tom Stellard
On Fri, Sep 26, 2014 at 01:51:15PM -0400, Jan Vesely wrote: On Fri, 2014-09-26 at 07:22 -0700, Tom Stellard wrote: On Thu, Sep 25, 2014 at 10:19:16PM -0400, Jan Vesely wrote: Didn't notice somebody dropped Tom from the cc list. On Thu, 2014-09-04 at 10:28 -0400, Jan Vesely wrote

Re: [Piglit] [PATCH] cl: Add log1p tests

2014-09-26 Thread Tom Stellard
On Fri, Sep 26, 2014 at 01:05:35PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com --- Reviewed-by: Tom Stellard thomas.stell...@amd.com generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH] CL: Add atomic_add global tests

2014-09-26 Thread Tom Stellard
the return value is used or not. v2: Only use return variant for atomic_add-global-return Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com CC: Tom Stellard thomas.stell...@amd.com --- .../builtin/atomic/atomic_add-global-return.cl | 62

Re: [Piglit] [Beignet] [PATCH] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-25 Thread Tom Stellard
On Thu, Sep 25, 2014 at 09:18:18AM +0800, Zhigang Gong wrote: On Wed, Sep 24, 2014 at 08:03:10AM -0700, Tom Stellard wrote: On Wed, Sep 24, 2014 at 01:13:18AM +, Luo, Xionghu wrote: Hi Tom, According to the opencl-1.2 spec in page 165, the option CL_KERNEL_GLOBAL_WORK_SIZE

Re: [Piglit] [PATCH v2 1/1] cl: Merge tests with the same name.

2014-09-25 Thread Tom Stellard
On Thu, Sep 25, 2014 at 03:36:23PM -0400, Jan Vesely wrote: ping Pushed, thanks! -Tom On Tue, 2014-09-16 at 17:49 -0400, Jan Vesely wrote: ping this fixes duplicate subtest names in generated tests On Thu, 2014-09-04 at 17:16 -0400, Jan Vesely wrote: This fixes hidden

Re: [Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-25 Thread Tom Stellard
On Thu, Sep 25, 2014 at 06:50:46PM -0400, Jan Vesely wrote: On Mon, 2014-09-22 at 11:31 -0700, Tom Stellard wrote: On Fri, Sep 19, 2014 at 07:30:41PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu For the whole series: Reviewed-by: Tom Stellard

Re: [Piglit] [PATCH] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-24 Thread Tom Stellard
, because the CL_KERNEL_GLOBAL_WORK_SIZE enum value does not appear anywhere in this patch or in the file being patched. -Tom Luo Xionghu Best Regards -Original Message- From: Tom Stellard [mailto:t...@stellard.net] Sent: Friday, September 19, 2014 10:14 PM To: Luo, Xionghu Cc

[Piglit] [PATCH] oclconform: Join the bindir and executable name when running single tests

2014-09-22 Thread Tom Stellard
This fixes running oclconform tests that don't have subtests. --- framework/oclconform.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/oclconform.py b/framework/oclconform.py index 91a9e43..01e10d9 100644 --- a/framework/oclconform.py +++ b/framework/oclconform.py

Re: [Piglit] [PATCH v2 5/5] cl: i32-stack-array: Rename to avoid subtest conflicts

2014-09-22 Thread Tom Stellard
On Fri, Sep 19, 2014 at 07:30:41PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu For the whole series: Reviewed-by: Tom Stellard thomas.stell...@amd.com Do you need me to commit these? --- tests/cl/program/execute/i32-stack-array.cl | 20 ++-- 1

Re: [Piglit] [PATCH 4/5] cl: Run vXi32-stack subtest in parallel

2014-09-19 Thread Tom Stellard
On Wed, Sep 17, 2014 at 05:40:38PM -0400, Jan Vesely wrote: On Wed, 2014-09-17 at 07:47 -0700, Tom Stellard wrote: On Wed, Sep 03, 2014 at 08:51:39PM -0400, Jan Vesely wrote: Avoid duplicate subtest names For patches 4 and 5, I would rather just rename the tests than merge them

Re: [Piglit] [PATCH] fix CL_KERNEL_GLOBAL_WORK_SIZE bug.

2014-09-19 Thread Tom Stellard
On Wed, Sep 17, 2014 at 06:05:12AM +0800, xionghu@intel.com wrote: From: Luo xionghu@intel.com the option CL_KERNEL_GLOBAL_WORK_SIZE for clGetKernelWorkGroupInfo should call built in kernel or custom device according to the spec, this patch calls the built in kernel to query the

[Piglit] [PATCH] cl: Add tests for global atomc_add()

2014-09-19 Thread Tom Stellard
--- .../builtin/atomic/atomic_add-global.program_test | 46 ++ .../execute/builtin/atomic/atomic_add-local.cl | 70 -- .../builtin/atomic/atomic_add-local.program_test | 46 ++ .../program/execute/builtin/atomic/atomic_add.inc | 23 +++ 4

Re: [Piglit] [PATCH 4/5] cl: Run vXi32-stack subtest in parallel

2014-09-17 Thread Tom Stellard
On Wed, Sep 03, 2014 at 08:51:39PM -0400, Jan Vesely wrote: Avoid duplicate subtest names For patches 4 and 5, I would rather just rename the tests than merge them together. This keeps the tests simple and easy to debug if they fail. You should apply for commit access, so you can start

[Piglit] [PATCH 3/3] Remove all_cl profile

2014-09-09 Thread Tom Stellard
, ARISING FROM, -# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE -# SOFTWARE. -# -# Authors: Tom Stellard thomas.stell...@amd.com -# - -from tests.cl import profile -from framework.oclconform import add_oclconform_tests -from framework.opencv import add_opencv_tests

[Piglit] [PATCH 1/3] opencv: Add 'individual' option to piglit.conf

2014-09-09 Thread Tom Stellard
This replaces the individual parameter in add_opencv_tests() --- framework/opencv.py | 3 ++- piglit.conf.example | 10 ++ tests/all_cl.py | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/framework/opencv.py b/framework/opencv.py index cefc94c..a5201c9 100644

[Piglit] [PATCH 2/3] quick_cl: Add oclconform tests

2014-09-09 Thread Tom Stellard
--- tests/quick_cl.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/quick_cl.py b/tests/quick_cl.py index 17729b2..ea48a7a 100644 --- a/tests/quick_cl.py +++ b/tests/quick_cl.py @@ -25,6 +25,8 @@ # from tests.cl import profile +from framework.oclconform import

Re: [Piglit] [PATCH 1/1] cl: fix adding concurent tests

2014-09-03 Thread Tom Stellard
On Wed, Sep 03, 2014 at 07:20:10PM -0400, Jan Vesely wrote: Signed-off-by: Jan Vesely jan.ves...@rutgers.edu Reviewed-by: Tom Stellard thomas.stell...@amd.com --- seemed wrong. Wonder if we can use concurrent tests. If you have render-nodes enabled, then you can run the cl tests

[Piglit] [PATCH] oclconform: Add test class for ocl conformance tests v2

2014-08-19 Thread Tom Stellard
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +# SOFTWARE. +# +# Authors: Tom Stellard thomas.stell...@amd.com +# + +from __future__ import print_function + +import re +import subprocess +from os import listdir +from os.path import isfile, join +from sys import stderr + +from framework.core import

[Piglit] [PATCH 1/3] core: Initialize ConfigParser with allow_no_value=True

2014-08-18 Thread Tom Stellard
--- framework/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/core.py b/framework/core.py index d3922a9..950ed7e 100644 --- a/framework/core.py +++ b/framework/core.py @@ -37,7 +37,7 @@ __all__ = ['PIGLIT_CONFIG', 'parse_listfile']

[Piglit] [PATCH 2/3] oclconform: Add test class for ocl conformance tests

2014-08-18 Thread Tom Stellard
OR OTHER DEALINGS IN THE +# SOFTWARE. +# +# Authors: Tom Stellard thomas.stell...@amd.com +# + +import re +import subprocess +from os import listdir +from os.path import isfile, join + +from framework.core import PIGLIT_CONFIG +from framework.exectest import Test + +def get_test_section_name(test

[Piglit] [PATCH 3/3] all_cl: Add ocl conformance tests to test list

2014-08-18 Thread Tom Stellard
--- tests/all_cl.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/all_cl.py b/tests/all_cl.py index b62b6c1..45de569 100644 --- a/tests/all_cl.py +++ b/tests/all_cl.py @@ -25,6 +25,8 @@ # from tests.cl import profile +from framework.oclconform import add_oclconform_tests from

Re: [Piglit] [PATCH v2 1/1] cl: Extend float to long conversion test

2014-07-25 Thread Tom Stellard
On Fri, Jul 25, 2014 at 09:49:08AM -0400, Jan Vesely wrote: On Tue, 2014-07-15 at 10:22 -0400, Tom Stellard wrote: On Tue, Jul 15, 2014 at 09:03:18AM -0400, Jan Vesely wrote: a light poke Tom, Matt, sorry I forgot to CC you, this piglit tests the conversions submitted last week

[Piglit] [PATCH 1/2] cl: Add minimal tests for clCreateImage2D and clCreateImage3D

2014-07-23 Thread Tom Stellard
: Tom Stellard thomas.stell...@amd.com + * + */ + +#include piglit-framework-cl-api.h + +PIGLIT_CL_API_TEST_CONFIG_BEGIN + + config.name = clCreateImage; + config.version_min = 10; + + config.run_per_platform = true; + config.create_context = true

[Piglit] [PATCH 2/2] cl: Add minimal test for clCreateSampler

2014-07-23 Thread Tom Stellard
OR OTHER + * DEALINGS IN THE SOFTWARE. + * + * Authors: Tom Stellard thomas.stell...@amd.com + * + */ + +#include piglit-framework-cl-api.h + +PIGLIT_CL_API_TEST_CONFIG_BEGIN + + config.name = clCreateSampler; + config.version_min = 10; + + config.run_per_platform = true

[Piglit] [PATCH] clGetDeviceInfo: Check for minimum value of CL_DEVICE_MAX_CONSTANT_BUFFER_SIZE

2014-07-23 Thread Tom Stellard
--- tests/cl/api/get-device-info.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/cl/api/get-device-info.c b/tests/cl/api/get-device-info.c index 81ab11c..ca13fa1 100644 --- a/tests/cl/api/get-device-info.c +++ b/tests/cl/api/get-device-info.c @@ -59,6 +59,7 @@

Re: [Piglit] [PATCH v2 1/1] cl: Extend float to long conversion test

2014-07-15 Thread Tom Stellard
On Tue, Jul 15, 2014 at 09:03:18AM -0400, Jan Vesely wrote: a light poke Tom, Matt, sorry I forgot to CC you, this piglit tests the conversions submitted last week. Reviewed-by: Tom Stellard thomas.stell...@amd.com thank you, Jan On Tue, 2014-06-24 at 15:15 -0400, Jan Vesely wrote

Re: [Piglit] [PATCH] cl-api-get-platform-ids: Initialize variable.

2014-07-03 Thread Tom Stellard
; ^ = NULL Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/cl/api/get-platform-ids.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/api/get-platform-ids.c b/tests/cl/api/get-platform

[Piglit] [PATCH 3/4] cl: Add tests for cos builtin

2014-07-02 Thread Tom Stellard
--- generated_tests/generate-cl-math-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-math-builtins.py b/generated_tests/generate-cl-math-builtins.py index edf93da..d93f09f 100644 ---

[Piglit] [PATCH 2/4] cl: Add tests for atan builtin

2014-07-02 Thread Tom Stellard
--- generated_tests/genclbuiltins.py | 7 +-- generated_tests/generate-cl-math-builtins.py | 11 +++ tests/cl/program/program-tester.c| 1 - 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/generated_tests/genclbuiltins.py

Re: [Piglit] [PATCH] cl: Fix out-of-bounds write in get-num-groups

2014-06-25 Thread Tom Stellard
On Wed, Jun 25, 2014 at 12:35:50PM +0200, Lars-Dominik Braun wrote: --- Each work-item writes three values. 4*4*4*3 is 192. Reviewed-by: Tom Stellard thomas.stell...@amd.com I can commit this. -Tom I’m new to piglit and do not have commit access. tests/cl/program/execute/get-num

[Piglit] [PATCH] core: Catch all exceptions when collect_system_info() programs fail

2014-06-24 Thread Tom Stellard
Otherwise it is not possible to run piglit without X, because glxinfo will requires a running X server. --- framework/core.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/framework/core.py b/framework/core.py index de5afa0..af36d8c 100644 --- a/framework/core.py +++

[Piglit] Piglit build fails: NameError: global name 'fake_whitespace' is not defined

2014-06-24 Thread Tom Stellard
Hi, Building piglit fails for me with HEAD at 7e699cdb47f328206afa6dd454de8d6f28d7ffe9 Here is the error: [ 0%] Generating tests/util/piglit-dispatch-gen.c, tests/util/piglit-dispatch-gen.h, tests/util/piglit-util-gl-enum-gen.c debug: registry.gl: etree is xml.etree.cElementTree debug:

Re: [Piglit] [PATCH] cl: Add signbit(float) relational tests

2014-06-20 Thread Tom Stellard
through as a string without python attempting to handle it. v2: Add nan and -nan tests Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com CC: Tom Stellard thomas.stell...@amd.com --- generated_tests/genclbuiltins.py | 3

Re: [Piglit] [PATCH 4/5] cl: Add isnotequal(float, float) relational tests

2014-06-17 Thread Tom Stellard
On Tue, Jun 17, 2014 at 08:45:03AM -0500, Aaron Watry wrote: On Fri, Jun 13, 2014 at 3:52 AM, Bruno Jimenez brunoji...@gmail.com wrote: On Thu, 2014-06-12 at 19:32 -0400, Tom Stellard wrote: On Wed, Jun 11, 2014 at 02:14:14PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa

Re: [Piglit] [PATCH] cl: Add test for the r600g mapping bug

2014-06-12 Thread Tom Stellard
On Mon, May 19, 2014 at 06:23:30PM +0200, Bruno Jiménez wrote: --- tests/cl.py| 1 + tests/cl/custom/CMakeLists.cl.txt | 1 + tests/cl/custom/r600-mapping-bug.c | 95 ++ 3 files changed, 97 insertions(+) create mode 100644

Re: [Piglit] [PATCH 4/5] cl: Add isnotequal(float, float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:14PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/generated_tests/generate-cl-relational-builtins.py

Re: [Piglit] [PATCH 2/5] cl: Add isgreater(float, float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:12PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

Re: [Piglit] [PATCH 1/5] cl: Add TRUE definition with type dependent value for generated tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:11PM -0500, Aaron Watry wrote: Scalar true is 1, but vector true is -1. This means that getValue needs to know if we are requesting TRUE for a scalar or vector. Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com

Re: [Piglit] [PATCH 3/5] cl: Add isgreaterequal(float, float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:13PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH 5/5] cl: Add signbit(float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 02:14:15PM -0500, Aaron Watry wrote: Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 9 + 1 file changed, 9 insertions(+) diff --git a/generated_tests/generate-cl-relational-builtins.py

Re: [Piglit] [PATCH 1/3] cl: Add isequal(float) relational tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 05:12:29PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-relational-builtins.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/generated_tests

Re: [Piglit] [PATCH 2/3] cl: Add 3-arg TTS kernel type

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 05:12:30PM -0500, Aaron Watry wrote: For built-ins with (vec, vec, scalar) arguments (such as mix) Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/genclbuiltins.py | 20 +--- 1 file

Re: [Piglit] [PATCH 3/3] cl: Add mix tests

2014-06-12 Thread Tom Stellard
On Wed, Jun 11, 2014 at 05:12:31PM -0500, Aaron Watry wrote: Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Aaron Watry awa...@gmail.com --- generated_tests/generate-cl-math-builtins.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/generated_tests

Re: [Piglit] [PATCH] cl-program-tester: Fix regexec usage.

2014-06-12 Thread Tom Stellard
, pmatch, 0)) { ^ program-tester.c:33:0: /usr/include/regex.h:578:12: note: expected ‘struct regmatch_t * __restrict__’ but argument is of type ‘struct regmatch_t (*)[1]’ extern int regexec (const regex_t *__restrict __preg, ^ Reviewed-by: Tom Stellard thomas.stell...@amd.com

Re: [Piglit] [PATCH] cl-api-create-context-from-type: Remove unused variables.

2014-06-11 Thread Tom Stellard
’ [-Wunused-variable] cl_int errNo; ^ Reviewed-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/cl/api/create-context-from-type.c | 8 1 file changed, 8 deletions(-) diff --git a/tests/cl/api/create-context-from-type.c b

  1   2   3   >