Before submitting a pull request should I rebase my commits for patch on
master HEAD to check that there aren't any
new includes that involve the old headers?
Yes, that's a good idea.
Hi,
I am sending a pull request rebased on current master. I included it as
an attachment since I
On Fri, Jun 22, 2012 at 02:25:57AM +0200, Blaž Tomažič wrote:
Currently all utility libraries (piglitutil, piglitutil_gles1,
piglitutil_gles2) have built-in the same API-independent code and the
code from piglit-util.{c,h} contains OpenGL functionality. To share more
code across different APIs
Blaz,
Thanks for splitting the earlier patch into this series of 5. As a result, the
changes were much easier to review.
Everything looks good to me and is
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
When you feel that the review process is complete and are ready to commit this,
Currently all utility libraries (piglitutil, piglitutil_gles1,
piglitutil_gles2) have built-in the same API-independent code and the
code from piglit-util.{c,h} contains OpenGL functionality. To share more
code across different APIs (e.g. OpenCL, OpenGL) this code should be
split.
