NAK. Reasons below.
As an alternative to this patch's method, I would change PIGLIT_HAS_X11 to be a
cmake option, enabled by default on Linux, and base decisions on the option. I
generally frown on build systems that make decisions based on autodetected
dependencies.
On 10/18/2012 11:11 AM,
On Mon, Oct 22, 2012 at 11:52 PM, Chad Versace
chad.vers...@linux.intel.com wrote:
NAK. Reasons below.
As an alternative to this patch's method, I would change PIGLIT_HAS_X11 to be
a
cmake option, enabled by default on Linux, and base decisions on the option. I
generally frown on build
From: Adrian Marius Negreanu adrian.m.negre...@intel.com
The GL tests are compiled unconditionally.
This breaks on systems that dont't have a GL library
Signed-off-by: Adrian Marius Negreanu adrian.m.negre...@intel.com
---
CMakeLists.txt | 8 +++-
I missed one occurrence. I'll resend it
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
From d9660648e5c41b2381fc82953bfede8d8451d8a2 Mon Sep 17 00:00:00 2001
From: Adrian Marius Negreanu adrian.m.negre...@intel.com
Date: Thu, 18 Oct 2012 20:54:05 +0300
Subject: [PATCH] use X11_X11_LIB_FOUND instead of CMAKE_SYSTEM_NAME
don't add X11_X11_LIB on systems that
qualifies as Linux, but
